! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Plugin takes up too much space
Status:
CLOSED: FIXED
Severity:
enhancement
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description alium 2012-05-06 23:14:19 CEST
Created attachment 4401 
plugin in the panel

I use 4.10 and Xfce xfce4-netload-plugin 1.1.0. Plug-in panel - as you can see the attached picture - takes up too much space. This happens if you set "present data" as "values".

It would reduce the gap a little?
Comment 1 Harald Judt 2012-05-18 19:41:42 CEST
This is intended, the gap is there to keep the size constant. Otherwise, the plugin would shrink and expand and the other parts of the panel would change their position on network activity, which is annoying. The size has already been "tuned", so this is currently the best we can do.

For more information, please see bug #7804 and the git commit history.
Comment 2 Harald Judt 2012-05-24 03:00:38 CEST
Created attachment 4456 
xfce4-netload-plugin-minimize-label-border.patch

Ok, there is one thing we can do, that is to further reduce the border of the labels from 4 to 2 pixel, and to remove the border of the title label completely when the send and receive labels are shown.

This way it wastes a bit less space than before. Unfortunately, there's nothing we can do about the labels presenting the data because of the reasons mentioned before.

This patch might need attachment #4437  in bug #8917, I'm not sure. But it could be adapted easily if the maintainer decides #4437 should not get applied.
Comment 3 Mike Massonnet editbugs 2012-06-01 12:08:52 CEST
Ok for putting a 2 pixel padding around the plugin main container, but it's not going to fix this issue.

I'm confident that the spacing is quite huge when no traffic is going on (e.g. 0B/s), and there should be some more magic for expanding the width dynamically.
Comment 4 Harald Judt 2012-06-01 12:23:12 CEST
Yeah, maybe set a timeout after which the plugin resizes itself or hides the labels when there's no traffic (and especially when the interface is not available).

There's a problem with the label_set_width_chars approach anyway, please see my follow-up patches I sent you.
Comment 5 Mike Massonnet editbugs 2012-07-15 14:46:07 CEST
Hi,

It's fixed in git, you can see the commit here:

http://git.xfce.org/panel-plugins/xfce4-netload-plugin/commit/?id=dd0c73ff94c9697760831a13f0d12cbb33f5cabf

Thank you for your report.

Regards,
Mike

Bug #8842

Reported by:
alium
Reported on: 2012-05-06
Last modified on: 2012-07-15

People

Assignee:
Mike Massonnet
CC List:
2 users

Version

Attachments

Additional information