Created attachment 3781 patch Hello. I wrote patch for this feature. Can you add it to repo?
Created attachment 3782 screenshot
Created attachment 3819 patch-v2 First version of this patch haven't Show_Bars option in config file. I fixed this.
Patch works fine, but it takes a lot of space in the panel.
Maybe do you can guess a more good solution?
Problems: * It does not show the label anymore, even when unselecting "Show values". What if you got two interfaces (eth0, wlan0)? * The values are already shown in the tooltip. > Patch works fine, but it takes a lot of space in the panel. Suggestions: * Make unit names shorter (kByte => kiB). * Use smaller horizontal spaces. * Similar to the panel date and time plugin, make the font a little bit smaller. Then put both values on the right side of the bars and on top of each other, like this (it's a bit hard to do in ASCII, but I think you'll get the idea): [ ] || [ D: 0.0kiB ] [eth0] || [ ] [ ] || [ U: 0.0kiB ] * Another idea: Use colors for down and up, like those for the bars.
i will think
Created attachment 4042 0001-Add-option-to-show-text-values-in-panel.patch after looking at the patch: - re-added the option to show the interface name - this bug is about adding an option, there is no reason the attached patch should remove existing options - moved the "Show values" option under "Show bars" for aesthetic reason - changed "kByte" against "KiB/s" please test, diff will be pushed in the coming days
Hm ... with your version of the patch applet growing and shrinking. It hasn't constant size.
I reverted + gtk_label_set_width_chars(GTK_LABEL(global->monitor->rcv_label), 13); and + gtk_label_set_width_chars(GTK_LABEL(global->monitor->snd_label), 13); for myself. Maybe we can use width less than 13?
Created attachment 4045 Updated patch to show values in panel. * changed format_with_thousandssep into format_byte_humanreadable, used in labels and tooltip * set size of label (set to 10 chars for now) * set alignment of labels * fixed spelling mistakes in code Problems/annoyances left: * check boxes are not a good choice anymore for bars/labels; a combobox would be much better here (only bars, only values, both) * do the new byte units (Byte, KiB,...) need translation?
Check your patch. You used tabs. I think it should to use spaces.
Created attachment 4046 Untabified patch to show values in panel. * Untabified patch * Added german translation (I did not chang anything related to unit names though). * Set "show values" option to false by default, as to not mess up existing user's configuration. I hope that I did the right thing when reading in the config file, setting a parameter from TRUE to FALSE, please check this.
(In reply to comment #9) > I reverted > + gtk_label_set_width_chars(GTK_LABEL(global->monitor->rcv_label), 13); > and > + gtk_label_set_width_chars(GTK_LABEL(global->monitor->snd_label), 13); > for myself. Maybe we can use width less than 13? It didn't bug me, but you are right, it's better to avoid this. (In reply to comment #10) > Created attachment 4045 > Updated patch to show values in panel. > > * changed format_with_thousandssep into format_byte_humanreadable, used in > labels and tooltip > * set size of label (set to 10 chars for now) > * set alignment of labels > * fixed spelling mistakes in code > > Problems/annoyances left: > * check boxes are not a good choice anymore for bars/labels; a combobox would > be much better here (only bars, only values, both) > * do the new byte units (Byte, KiB,...) need translation? One issue per bug, with attachment 4046 , there is a change in the code with regard to 'format_with_thousandssep' (with untranslatable strings). Please open a new bug for this different issue. This bug should only add the option "Show values". Once it will be pushed, the commit will be marked in the log history with 'bug XXX: message'. This will keep the history clean.
Created attachment 4047 Patch to add and implement option "Show Values".
Created attachment 4048 Russian translation
Opened bug 8280 with separate follow-up patches for the byte units/space issue.
Created attachment 4053 Use combobox instead of checkboxes. This patch should apply on top of my previous patch 4047. If not, only small alterations will be needed. It removes the checkbox controls "show bars" and "show values" with a combobox providing three choices to present data. I think this looks more clean and has better and more uncomplicated behaviour than activating/deactivating other widgets.
Created attachment 4054 Updated german translation for patch 4053. Here's a patch to update the german translation. Again, I don't know if it applies cleanly, but theoretically it should. BTW: Are there documentation or guidelines on how to deal with po files? I have no experience modifying those, I usually change it and see if that works. Another thing I'd like to do is to update the mnemonics for the other widgets. Modifying the source code is trivial. However, this would force updates for most translations. What do you think?
I think we should before decide which patch we will apply. Only then do anything with translations file. And sure it's good idea to update all translations.
I think this can be done independently of this bug. Therefore, I opened a bug #8283 which adds mnemonics and updates msgids in translation files. It does not touch the translation strings so everything should look like before.
(In reply to comment #17) > Created attachment 4053 > Use combobox instead of checkboxes. > > This patch should apply on top of my previous patch 4047. If not, only small > alterations will be needed. > > It removes the checkbox controls "show bars" and "show values" with a combobox > providing three choices to present data. > > I think this looks more clean and has better and more uncomplicated behaviour > than activating/deactivating other widgets. Cool! It looks very more prefer for me. Only one thing. Maybe should use 'Present data as' instead of 'Present Data As'? 'Only' word in combobox also should write with lower-case first letter. Hm ... what about semicolon? Did you passed it? Or it is true?
Oh. My English. I meant 'colon' when I was saying 'semicolon'.
*said. ((( Today I am on 'top'.
I took the combobox choices from the places plugin and there they are capitalized ('Only Icon', 'Only Label', 'Icon and Label'). The Englishmen seem to capitalize everything these days, claiming it's easier to read that way. Since I use the German translation where it would be gramatically incorrect, it does not bother me and I try to match their preferences. About the colon: I did not notice, so feel free to add it if you miss it.
Have a look at another labels. It capitalized only first word.
I've looked places plugin. Really it capitalize each word. Also places plugin doesn't use colons.
(In reply to comment #26) > I've looked places plugin. Really it capitalize each word. Also places plugin > doesn't use colons. There is a wiki page that resumes the way strings should be inserted: http://wiki.xfce.org/style/strings
Labels Before Controls Like other text, the first word should be capitalized, while the rest are not. When the label is before a control, such as descriptive text to the left of a dropdown box, append a colon to the string, with NO SPACE between the last letter of the string and the colon. It's our case. Should use 'Present data as:'. So?
Created attachment 4069 Use combobox instead of checkboxes. Use string adhering to http://wiki.xfce.org/style/strings.
Created attachment 4070 Updated german translation for patch 4069.
Created attachment 4071 Updated german translation for patch 4069.
I don't sure about 'Bars Only'. What does Mike say?
We could remove 'only' completely: Present data as: 'Bars', 'Values', 'Bars and Values'
In vertical mode, the alignment of the upload label should be changed from left to right. For my taste, it still wastes too much space, except when you change the panel's orientation to vertical mode. Is there a reason not to put the labels on top of each other? I wonder how it copes with the new deskbar mode.
For me layout is very fine. I don't want to change something.
Created attachment 4072 Use combobox instead of checkboxes. Remove 'Only'.
Created attachment 4073 Updated german translation for patch 4072.
Oh ... 'Only' word good for me. But I don't like uppercase.
Created attachment 4074 Updated german translation for patch 4072. Forgot to save in previous version.
Created attachment 4075 Fix vertical alignment of sent label in vertical mode. This makes the "sent" label look better in vertical mode.
(In reply to comment #38) > Oh ... 'Only' word good for me. But I don't like uppercase. First, it's capitalized in xfce4-places-plugin. Second, I don't think it is needed. 'Only' can be deduced from the other choices and the fact that it is a combobox. Anyway, I feel a bit this is just nit-picking, and it would be great if the current maintainer could decide whether the patch is good enough now or tell us how to improve it.
Created attachment 4076 Add option to colorize values using bar colors Follow-up patch adding an option to colorize the values using the bar colors.
Pushed patches in git.
Translations will need to be uploaded through Transifex[1] or sent to me. [1] https://translations.xfce.org/projects/p/xfce4-netload-plugin/c/master/
Thanks! It's best present on New Year days for me.