! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Reorganize code in monitor_new, setup_monitor and monitor_set_orienta...
Status:
CLOSED: FIXED
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Harald Judt 2012-05-19 05:27:01 CEST
Created attachment 4437 
xfce4-netload-plugin-rewrite-widget-creation-and-setup.patch

The current state is a bit messy. Widget re-/creation is spread over various functions. With this patch, only monitor_new creates the widgets, while setup_monitor controls which widgets will be shown, and monitor_set_orientation will deal with the orientation of the widgets. I think this way the plugin will be easier to adapt to the new panel versions (>=4.9).

Additionally, the event box is set invisible and above its children, so that the context menu is accessible by right-clicking on any part of the plugin.

I've wrote this patch after I submitted the patches in bugs #8914 and #8915, so these will be needed to apply, sorry for that. However, this patch has the changes of those two included, so you might simply apply all three consequently before committing and forget about the two older bugs.
Comment 1 Mike Massonnet editbugs 2012-05-29 23:09:06 CEST
fixed in git b6efbf1..e098eaa

thank you for your patch

Bug #8917

Reported by:
Harald Judt
Reported on: 2012-05-19
Last modified on: 2012-07-15

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Attachments

Additional information