! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch] Hide browser by default and add files with gtk_file_chooser
Status:
RESOLVED: FIXED

Comments

Description Matias De lellis 2012-04-25 06:05:52 CEST
Created attachment 4364 
Hide Browser and use gtk file chooser

Now, the file browser of xfburn is limited:
 * Bug 7946 - Refresh navigation panel
 * Bug 4884 - Xfburn should be able to display/sort by additional file information like date,size,type 
 * Bug 7922 - Feature request: Allow drag and drop [1]
 * Bug 6857 - Special folder icons not used 

These are the bugs here. Could add more personal appreciations, but maybe not. =)

mmm..
I would love to improve the browser, but it escapes my ability. :(

Well, this patch adds a new possibility to add files. When the browser is hidden, it shows a gtk file chooser to select files to add to the composition.

Advantages?
 * Searches through tracker.
 * Sorting by size and modification date.
 * Use of gtk bookmarkes.

Bonus: This is optional, if the browser is present, xfburn behaves as usual

[1] I think this works, and the bug is wrong

Regards.
Comment 1 Matias De lellis 2012-04-25 06:14:16 CEST
Fix another problem in xfburn.
Now when the browser is hidden, and therefore nothing is selected, when clicking the button add xfburn try to add the entire home!. Bad!.
Comment 2 David Mohr 2012-05-05 18:18:27 CEST
Thanks for the patch. I had already considered doing exactly the same thing. I'll probably use this for the next release.
Comment 3 David Mohr 2012-07-08 02:13:09 CEST
Thanks for the patch Matias, but I ended up implementing this on my own. The feature is now enabled by default, but exiting settings will still show the file browser. You can turn that off in the settings though and you'll get the new behavior.

commit e18bcd65f8b02514c8f1ef8ec96b183a721fa727
Author: David Mohr <david@mcbf.net>
Date:   Fri Jul 6 23:01:10 2012 -0600

    Add dialog for files and folders.
    
    Inspired by audacious' ui_fileopener.c

commit 36050be23614f17422afa1e9f2bded7f5d8a5abf
Author: David Mohr <david@mcbf.net>
Date:   Tue Jul 3 22:00:10 2012 -0400

    Show select file dialog on add while browser is hidden.

Bug #8775

Reported by:
Matias De lellis
Reported on: 2012-04-25
Last modified on: 2012-07-08

People

Assignee:
Xfburn Bug Triage
CC List:
1 user

Version

Version:
unspecified

Attachments

Hide Browser and use gtk file chooser (4.44 KB, patch)
2012-04-25 06:05 CEST , Matias De lellis
no flags

Additional information