! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
UCA only works on local files
Status:
RESOLVED: FIXED

Comments

Description Bert Vermeulen 2011-05-23 23:44:26 CEST
Thunar skips user customizable actions on remote filesystems. However there's no real reason for this; the patch that does this is part of a five-year old commit. I suspect the reason is that this did not work with the old Thunar VFS, but it works fine now with GIO.

I'm attaching a patch which removes the local check.
Comment 1 Bert Vermeulen 2011-05-23 23:45:20 CEST
Created attachment 3692 
thunar-enable-remote-uca.patch
Comment 2 Jannis Pohlmann editbugs 2011-05-25 23:17:35 CEST
Extending UCA to other URI schemes is not as straight-forward as it seems.

Most custom actions do not support URIs yet. %u and %U are supported but not documented. This information needs to be added to the UCA edit dialog. 

It is unclear whether we should expand %d, %D, %f and %F to URIs. Changing the behavior of these placeholders might break existing custom actions, so I think we have to introduce URI alternatives for %d and %D at least. This is even more important as some URIs and URI schemes cannot be converted to local paths, even if gvfs-fuse is available. So e.g. for some trash:// smb:// URIs (generally all URIs for which g_file_get_path() returns NULL), only custom actions that support URI parameters should be displayed.
Comment 3 Jérôme Guelfucci editbugs 2011-06-03 14:17:55 CEST
*** Bug 7305 has been marked as a duplicate of this bug. ***
Comment 4 Jérôme Guelfucci editbugs 2011-06-03 14:18:31 CEST
Patch proposed in a duplicate: https://bugzilla.xfce.org/attachment.cgi?id=3482&action=diff
Comment 5 Harald Judt editbugs 2015-04-17 17:59:07 CEST
*** Bug 10635 has been marked as a duplicate of this bug. ***
Comment 6 Harald Judt editbugs 2015-04-17 18:56:04 CEST
*** Bug 7936 has been marked as a duplicate of this bug. ***
Comment 7 haarp 2015-04-18 11:54:26 CEST
(In reply to Jérôme Guelfucci from comment #4)
> Patch proposed in a duplicate:
> https://bugzilla.xfce.org/attachment.cgi?id=3482&action=diff

I can confirm this patch as working.
Comment 8 Daniel Reichelt 2015-04-18 13:30:16 CEST
+1, v1.6.3 (Debian Jessie)
Comment 9 Daniel Reichelt 2015-04-18 13:31:38 CEST
PS: Thanks, Ambroz!!
Comment 10 Harald Judt editbugs 2015-04-22 13:57:26 CEST
The patch from some duplicate doesn't seem to work for me?
Comment 11 haarp 2015-06-09 13:17:39 CEST
(In reply to Harald Judt from comment #10)
> The patch from some duplicate doesn't seem to work for me?

Hmm, weird. It works very well for me.


I just discovered a case that's not covered by this patch however. The "Image" tab in file properties of pictures is shown only for local files, even with the patch.
Comment 12 Git Bot editbugs 2018-03-04 22:53:50 CET
Ambroz Bizjak referenced this bugreport in commit eb0fa0aa0944cef940533acdf4752fed5feb68e4

Thunar User Configurable Actions do not work for remote locations (bug #7652), patch from (bug#7305)

https://git.xfce.org/xfce/thunar/commit?id=eb0fa0aa0944cef940533acdf4752fed5feb68e4
Comment 13 Git Bot editbugs 2018-03-04 23:25:56 CET
Ambroz Bizjak referenced this bugreport in commit 46b4f0212f72b0971bfd49f9c9610285d60e0f0b

Thunar User Configurable Actions do not work for remote locations (bug #7652), patch from (bug#7305)

https://git.xfce.org/xfce/thunar/commit?id=46b4f0212f72b0971bfd49f9c9610285d60e0f0b
Comment 14 alexxcons editbugs 2018-03-04 23:30:57 CET
@Ambroz Bizjak 
Thanks alot for the patch and sorry for the very very late reply !

I just tested the patch, and for me it works flawlessly, so I pushed it to:
- branch master, to be released as thunar 1.8.0
- branch xfce-4.12, to be released as thunar 1.6.15
Comment 15 alexxcons editbugs 2018-04-19 10:46:04 CEST
*** Bug 14344 has been marked as a duplicate of this bug. ***

Bug #7652

Reported by:
Bert Vermeulen
Reported on: 2011-05-23
Last modified on: 2018-04-19
Duplicates (4):
  • 7305 Thunar User Configurable Actions do not work for remote locations
  • 7936 Consider adding an SSH open-remote-terminal when using SFTP
  • 10635 User Actions don't work in gvfs mounts
  • 14344 Thunar does not show custom actions on network shares

People

Assignee:
Jannis Pohlmann
CC List:
10 users

Version

Attachments

thunar-enable-remote-uca.patch (940 bytes, patch)
2011-05-23 23:45 CEST , Bert Vermeulen
no flags

Additional information