! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
button layout customization broken (4.5.91)


Description Zenwalk 2008-11-02 13:27:04 CET
With latest svn (aka 4.5.91) , no way to change the button layout in xfwm settings.

Drag and drop of buttons doesn't work anymore.
Comment 1 Olivier Fourdan editbugs 2008-11-02 16:15:13 CET
It works fine here. 

Not all themes support customization though, and there is a regression in current code compared to previous settings dialogs, in that when a theme cannot be customized, the older dialog made the button layout insensitive whereas the new one doesn't, possibly leading to user confusion.

What theme are you using?
Comment 2 Zenwalk 2008-11-02 16:45:59 CET
The problem occurs with all themes.

confirmed with fresh svn28580.

What's special to my system ? no xfce-gtk-engines ...

Comment 3 Zenwalk 2008-11-02 16:59:31 CET
The config :)

<?xml version="1.0" encoding="UTF-8"?>

<channel name="xfwm4" version="1.0">
  <property name="general" type="empty">
    <property name="activate_action" type="string" value="bring"/>
    <property name="borderless_maximize" type="bool" value="true"/>
    <property name="box_move" type="bool" value="false"/>
    <property name="box_resize" type="bool" value="false"/>
    <property name="button_layout" type="string" value="O|SHMC"/>
    <property name="button_offset" type="int" value="0"/>
    <property name="button_spacing" type="int" value="0"/>
    <property name="click_to_focus" type="bool" value="false"/>
    <property name="focus_delay" type="int" value="835"/>
    <property name="cycle_draw_frame" type="bool" value="true"/>
    <property name="cycle_hidden" type="bool" value="true"/>
    <property name="cycle_minimum" type="bool" value="true"/>
    <property name="cycle_workspaces" type="bool" value="false"/>
    <property name="dbl_click_time" type="int" value="400"/>
    <property name="double_click_action" type="string" value="maximize"/>
    <property name="easy_click" type="string" value="true"/>
    <property name="focus_hint" type="bool" value="true"/>
    <property name="focus_new" type="bool" value="true"/>
    <property name="frame_opacity" type="int" value="100"/>
    <property name="full_width_title" type="bool" value="true"/>
    <property name="inactive_opacity" type="int" value="100"/>
    <property name="maximized_offset" type="int" value="0"/>
    <property name="move_opacity" type="int" value="100"/>
    <property name="placement_ratio" type="int" value="20"/>
    <property name="placement_mode" type="string" value="center"/>
    <property name="popup_opacity" type="int" value="100"/>
    <property name="prevent_focus_stealing" type="bool" value="false"/>
    <property name="workspace_names" type="array">
      <value type="string" value="Workspace 1"/>
      <value type="string" value="Workspace 2"/>
    <property name="raise_delay" type="int" value="250"/>
    <property name="raise_on_click" type="bool" value="true"/>
    <property name="raise_on_focus" type="bool" value="false"/>
    <property name="raise_with_any_button" type="bool" value="true"/>
    <property name="repeat_urgent_blink" type="bool" value="true"/>
    <property name="resize_opacity" type="int" value="100"/>
    <property name="restore_on_move" type="bool" value="true"/>
    <property name="scroll_workspaces" type="bool" value="true"/>
    <property name="shadow_delta_height" type="int" value="0"/>
    <property name="shadow_delta_width" type="int" value="0"/>
    <property name="shadow_delta_x" type="int" value="0"/>
    <property name="shadow_delta_y" type="int" value="0"/>
    <property name="shadow_opacity" type="int" value="66"/>
    <property name="show_app_icon" type="bool" value="true"/>
    <property name="show_dock_shadow" type="bool" value="true"/>
    <property name="show_frame_shadow" type="bool" value="false"/>
    <property name="show_popup_shadow" type="bool" value="false"/>
    <property name="snap_resist" type="bool" value="false"/>
    <property name="snap_to_border" type="bool" value="true"/>
    <property name="snap_to_windows" type="bool" value="false"/>
    <property name="snap_width" type="int" value="10"/>
    <property name="theme" type="string" value="Zenwm"/>
    <property name="title_alignment" type="string" value="center"/>
    <property name="title_horizontal_offset" type="int" value="0"/>
    <property name="title_shadow_active" type="string" value="false"/>
    <property name="title_shadow_inactive" type="string" value="false"/>
    <property name="title_vertical_offset_active" type="int" value="0"/>
    <property name="title_vertical_offset_inactive" type="int" value="0"/>
    <property name="toggle_workspaces" type="bool" value="false"/>
    <property name="unredirect_overlays" type="bool" value="true"/>
    <property name="use_compositing" type="bool" value="false"/>
    <property name="workspace_count" type="int" value="2"/>
    <property name="wrap_cycle" type="bool" value="true"/>
    <property name="wrap_layout" type="bool" value="true"/>
    <property name="title_font" type="string" value="Sans Bold 9"/>
Comment 4 Olivier Fourdan editbugs 2008-11-02 17:51:06 CET
And does the config reflect the actual settings? Doe sit change when yu modify the layout using the dialog?
Comment 5 Zenwalk 2008-11-02 17:56:21 CET
md5sum ./.config/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml 

config mod with GUI

md5sum ./.config/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml 

Indeed :) nothing changes
Comment 6 Olivier Fourdan editbugs 2008-11-02 18:15:53 CET
And other settings work?
Comment 7 Zenwalk 2008-11-02 18:21:32 CET
Yes :

jpgu[~]$ md5sum ./.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml 
13aafcdf6f791cc5661967a8c3069261  ./.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml

Changing wallpaper through GUI ...

jpgu[~]$ md5sum ./.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml 
761d3b54326f1b8304962bd5adb08188  ./.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml
Comment 8 Olivier Fourdan editbugs 2008-11-02 18:24:33 CET
No, you misunderstood, my question is not about settings in general, but rather do other *window manager* settings work?

Chaning the theme, the font, focus model, etc. does that work?
Comment 9 Zenwalk 2008-11-02 18:29:46 CET
No other xfwm settings don't work (didn't notice in the first place.
Comment 10 Olivier Fourdan editbugs 2008-11-02 18:34:40 CET
Ok, can you tell how you run the settings dialog?

Can you try running the settings dialog from a terminal:

    $ xfwm4-settings
Comment 11 Zenwalk 2008-11-02 18:56:42 CET
It seems that you got it :)

When I start xfwm4-settings from xfce4-settings-manager -> doesn't work

When I issue : xfwm4-settings from terminal : it works
Comment 12 Olivier Fourdan editbugs 2008-11-02 20:40:22 CET
I suspect an installation problem. Can you check if you have only one version of the binary installed?
Comment 13 Zenwalk 2008-11-02 22:20:56 CET
find /usr/ -name xfwm4-settings

nothing else :(

I can launch both xfwm4-settings from CLI and from the panel, I get  :

jpgu     4038  0.9  1.5  27048 16188 pts/0    S    23:19   0:00 xfwm4-settings
jpgu     4039  0.6  1.3  23868 13672 ?        S    23:19   0:00 xfce4-settings-manager
jpgu     4040  0.7  1.4  26504 15428 ?        Ss   23:19   0:00 xfwm4-settings --socket-id=48234759
Comment 14 Olivier Fourdan editbugs 2008-11-02 23:07:43 CET
Then adding Jannis to the list to see if he has an idea, he wrote that part of the code.
Comment 15 Jannis Pohlmann editbugs 2008-11-02 23:12:41 CET
It's a known problem that DND doesn't work in xfce4-settings-manager. Unfortunately I don't have a clue what might be wrong in the code. Stephan wrote it, so maybe he knows.

I'm adding the bug report about DND as a dependency to this one. Not marking as a duplicate though because I think the regression has to be fixed as well.
Comment 16 Zenwalk 2008-11-09 17:06:01 CET
I have to add that , even when launching xfwm4-settings from terminal, I can't change the focus parameters.

Comment 17 Olivier Fourdan editbugs 2008-11-09 17:58:58 CET
Well, first thing is to check if the xfconf data is updated when you change the settings in the gui. It's xml files, so it's easy to inspect the content.
Comment 18 Zenwalk 2008-11-09 18:09:07 CET
No, changes in the UI have no impact on the xml file.

Comment 19 Stephan Arts editbugs 2008-11-09 22:32:39 CET
(In reply to comment #17)
> Well, first thing is to check if the xfconf data is updated when you change the
> settings in the gui. It's xml files, so it's easy to inspect the content.

Actually, no... xfconfd writes the xml files asynchronously (to reduce file-writes) so a change in the properties does not necessary mean the file has changed too.

run xfconf-query to analyse the properties instead.
Comment 20 Zenwalk 2008-11-10 11:06:13 CET
Results :

1) xfconf-query --monitor --channel xfwm4

2) I launch xfce-settings-manager -> Window Manager

3) Shown settings don't reflect actual configuration ("Click to focus" is checked, but I experience "Focus follow mouse")

4) I check "Focus follow mouse" : no event in xfconf-query --monitor

5) I check "Click to focus" : I get "Property '/general/click_to_focus' changed" , focus is configured correctly now

6) I close the xfce-settings-manager

7) I reopen it and change to "Focus follow mouse" : Property '/general/click_to_focus' changed

8) I close the xfce-settings-manager

9) I reopen it : "Click to focus" is checked :( (should be "Focus follow mouse" )
Comment 21 Jannis Pohlmann editbugs 2008-11-10 13:14:06 CET
I've fixed the click_to_focus bug now:

  Author: jannis
  Date: 2008-11-10 13:10:52 +0000 (Mon, 10 Nov 2008)
  New Revision: 28712

  Fix the /general/click_to_focus radio button synchronization with
  xfconf. The two radio buttons are now properly updated when the
  /general/click_to_focus property is changed outside of the dialog.

However, this has nothing to do with the button layout customization problem which was originally reported. The problem seems to be that by embedding the dialog into the main settings dialog, drag-and-drop does no longer work. I'll try different techniques to set up dragging *after* the dialog has been embedded and not *before*. If this doesn't work, we'll have to remove the pluggin feature from the window manager dialog. But I really don't want to do that because it's inconsistent.
Comment 22 Zenwalk 2008-11-10 13:57:13 CET
Hum ... thinking of :

sed -i 's/X-XfcePluggable=.*/X-XfcePluggable=false/g'  /usr/share/applications/xfc*settings*

I would prefer a simple applet launcher rather than the wizard style.

Comment 23 Jannis Pohlmann editbugs 2008-11-10 14:00:23 CET
(In reply to comment #22)
> Hum ... thinking of :
> sed -i 's/X-XfcePluggable=.*/X-XfcePluggable=false/g' 
> /usr/share/applications/xfc*settings*
> I would prefer a simple applet launcher rather than the wizard style.

Well, that's not going to happen in Xfce itself. If you want to do that for your distribution, you can do that.
Comment 24 Brian J. Tarricone (not reading bugmail) 2008-12-14 11:21:07 CET
*** Bug 4718 has been marked as a duplicate of this bug. ***
Comment 25 Olivier Fourdan editbugs 2009-01-24 18:50:20 CET
It's a dup. of #4524 or vice versa.
Comment 26 Nick Schermer editbugs 2009-01-25 16:34:59 CET

*** This bug has been marked as a duplicate of bug 4524 ***

Bug #4556

Reported by:
Reported on: 2008-11-02
Last modified on: 2009-07-14
Duplicates (1):
  • 4718 xfce4-setting-manager, window manager, buttons not moved.


Olivier Fourdan
CC List:
4 users


4.5.91 (4.6 beta 1)


Additional information