! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Can't edit button layout on any theme


Description Jeremy Leland 2008-10-27 01:02:23 CET
You cannot edit the button layout for any theme. The controls are not disabled; you can click and drag the various buttons from Active to Hidden, but upon release they go right back where they started. This happened with all the themes I tried.

1) Open "Window Manager" settings -> Style
2) Click on (for example) the "Shade" button in the "Active" area and drag it into the "Hidden" area.

Expected: The "Shade" button will now be in the "Hidden" area
Actual: The "Shade" button reappears in the "Active" area
Comment 1 Brian J. Tarricone (not reading bugmail) 2008-10-27 05:08:40 CET
Yeah, this is pretty broken.  I can sometimes get it to work, but even when I can, the drag icons are really messed up (like the icon will show two of the buttons or something).
Comment 2 Wade Nelson 2009-01-24 16:18:01 CET
I have same issue.  However, when I switch Xfwm theme to "Default-4.4" I can drag-drop the buttons.  I then can switch back to the theme I want the button settings stick.
Comment 3 Olivier Fourdan editbugs 2009-01-24 18:50:23 CET
It's a dup. of #4556 or vice versa.
Comment 4 Olivier Fourdan editbugs 2009-01-24 20:52:47 CET
For DnD to work with an embedded window, gtk_drag_dest_set_proxy() must be called.

gtk_drag_dest_set_proxy() is called automatically from gtk_socket_add_window() but to work it requires a protocol that it gets from gdk_drag_get_protocol().

Adding some traces in xfwm_settings_create_plug(), it shows that gdk_drag_get_protocol() fails, that would explain why gtk_drag_dest_set_proxy() is not called and DnD fails when the window is embedded in the settings manager.

Now, the question is why gdk_drag_get_protocol() fails...
Comment 5 Mike Massonnet editbugs 2009-01-25 09:32:31 CET
*** Bug 4554 has been marked as a duplicate of this bug. ***
Comment 6 Olivier Fourdan editbugs 2009-01-25 12:01:10 CET
Ok, the problem comes from the use of GTK_TARGET_SAME_APP. Removing that flags makes the DnD signals work, but that triggers other errors. Still investigating.
Comment 7 Nick Schermer editbugs 2009-01-25 16:34:59 CET
*** Bug 4556 has been marked as a duplicate of this bug. ***
Comment 8 Nick Schermer editbugs 2009-01-25 16:38:52 CET
Sending        NEWS
Sending        settings-dialogs/xfwm4-settings.c
Transmitting file data ..
Committed revision 29347.

Bug #4524

Reported by:
Jeremy Leland
Reported on: 2008-10-27
Last modified on: 2009-07-14
Duplicates (2):
  • 4554 DND actions don't work when the dialogs are plugged in
  • 4556 button layout customization broken (4.5.91)


Stephan Arts
CC List:
4 users


4.5.91 (4.6 beta 1)


Additional information