! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Vertical slider bar for volume control is too large
Status:
RESOLVED: FIXED
Product:
Xfce4-mixer
Component:
Panel Plugin

Comments

Description Robby Workman editbugs 2006-09-04 19:30:57 CEST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: 

In xfce 4.4rc1 on Slackware 11.0 RC4, the vertical volume slider bar is too tall - it does not look like the other bars for system load, memory, etcetera.  All components compiled with -O2 -march=i486 -mtune=i686.

Screenshot:  http://rlworkman.net/images/volume_bar.jpg

Reproducible: Always

Steps to Reproduce:
1. Enable the Volume Control plugin.

Actual Results:  
Slider bar is too tall - see screenshot

Expected Results:  
Slider bar should match the height of other panel plugin bars.
Comment 1 dannym editbugs 2006-09-05 18:19:35 CEST
I'd say the others are too short :)

see bug # 1552

fight it out :)
Comment 2 Mike Massonnet editbugs 2006-09-09 17:56:19 CEST
Created attachment 781 
Add a border around the volume slider

This patch adds a border, as for the several other plugins: systemload, netload, battery, mpd-playlist (oh no, this one is unofficial :)).

Enjoy.
Comment 3 Robby Workman editbugs 2006-09-10 20:32:18 CEST
(In reply to comment #2)
> Created an attachment (id=781) [edit]
> Add a border around the volume slider

Thanks, Mike.  Applying that patch does make the height of the volume bar the same as the others.  :)
Comment 4 Robby Workman editbugs 2006-11-15 21:41:20 CET
Danny,
I just noticed that 1552 - http://bugzilla.xfce.org/show_bug.cgi?id=1552 - was resolved, but I have already built the mixer with Mike's patch, so I'm curious - did closing 1552 have any effect on this one?  In other words, is his patch still needed for what I think is the "correct" behavior (regardless of whether it is indeed correct)?  :-)
Comment 5 Chris Carlin 2006-11-15 22:40:35 CET
*** Bug 2553 has been marked as a duplicate of this bug. ***
Comment 6 Laurent Meunier 2007-03-20 12:26:28 CET
I'm currently using xfce4-mixer 4.4.0, and I've still this bug. Could the patch from Mike Massonnet be included in the next Xfce release (4.4.1)?
Comment 7 Lalo Martins 2007-05-11 07:05:03 CEST
Ideally, for full consistency with other bars, I'd like to be able to:

- choose a colour
- show a label rather than image for the button (optionally of course)
- or hide the button entirely (my personal preference)
Comment 8 Lalo Martins 2007-05-14 16:42:11 CEST
Created attachment 1142 
Patch to do everything suggested below

Here's my patch; it adds the features I suggested, except for the ability to show text instead of the icon.  Please review.
Comment 9 Lalo Martins 2007-05-14 16:43:11 CEST
Created attachment 1143 
Generated files, companion to above patch (you don't need this if you want to run gob yourself)
Comment 10 Mike Massonnet editbugs 2007-10-06 22:35:33 CEST
(In reply to comment #7)
> Ideally, for full consistency with other bars, I'd like to be able to:
> 
> - choose a colour
> - show a label rather than image for the button (optionally of course)
> - or hide the button entirely (my personal preference)
> 

That's out of scope for this bug report, you should move it to a new bug.
Comment 11 Mike Massonnet editbugs 2007-10-06 22:45:14 CEST
Created attachment 1387 
border around monitor

According to the bug #3587 I agree that for consistency we should have a 2 pixel border around a GtkProgressBar used as monitor.
Comment 12 Robby Workman editbugs 2008-06-09 21:02:04 CEST
*** Bug 2320 has been marked as a duplicate of this bug. ***
Comment 13 dannym editbugs 2009-01-11 15:17:39 CET
I applied Mike's patch to the 4.4 branch right now. I don't know how to please everyone, but I guess I'll just fix this bug and wait for the new one asking me to do the inverse come in ;-)

As for Lalo Martins' patch, I understand why you want to do it, but I cannot do such changes in a stable branch. The chance to subtly break something (config changes between minor versions etc) are just too high. So I didn't do that (I even felt somewhat overconfident when applying Mike's patch :-)). 

There's a new xfce4-mixer in trunk, maybe apply it there?
Comment 14 dannym editbugs 2009-01-11 16:16:30 CET
*** Bug 3112 has been marked as a duplicate of this bug. ***

Bug #2267

Reported by:
Robby Workman
Reported on: 2006-09-04
Last modified on: 2009-07-14
Duplicates (3):
  • 2320 Make volume control bar more consistent with other plugins
  • 2553 Mixer too tall
  • 3112 Height of volume control is too large compared to other plugins

People

CC List:
4 users

Version

Attachments

Additional information