! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Risk to activates first item of right click menu accidentally
Status:
RESOLVED: INVALID

Comments

Description jack_the_pirate 2020-01-17 07:27:43 CET
Before I write this bug, I have searched for help on XFCE Forum, where I created this topic searching for help:
https://forum.xfce.org/viewtopic.php?id=13681

After some replies, I open this bug report as sugested by the forum moderator ToZ in this reply to the same topic here:
https://forum.xfce.org/viewtopic.php?pid=56124#p56124

Because of time constraints, I am going to explain the bug using copy-paste from that forum post.
This is a bit long, but it explains rather well the situation and also there are links to screenshots that are very ilustrative.

=============================================
jack_the_pirate 
2020-01-14 09:45:40 WET

IMHO the default XFCE file manager (Thunar) righ-click menu has a serious drawback that must be corrected:

- when the mouse right-click is used, the right-click menu appears

- and an entry (command) of that menu is already automatically selected by default

- this is very bad because if you inadvertedly press left-click or right-click again, that command is going to run

This has happened to me several times, some without serious consequences, and some more serious.

Also, the problem is more difficult to solve because the automatically selected menu entry changes when the right-click is done near the edges ot the screen, especially the bottom.

And it can be much worse if you are like me and have many Thunar custom-actions that make the right-click menu very big.

For example, I have a custom-action with a script that moves the selected file(s) or folder(s) to a specific folder.
When I right-clicked a Virtualbox VDI file to copy it, I inadvertedly pressed right-click again and it was being copied to that folder and I had to restart immediately my computer to stop it.
I know this was my fault, but it never would happen with another file manager because the second right-click would do nothing when pressed.
The same has happened multiple times to me, but with minor files or folders.

At first, I thought it was my fault for inadvertedly pressing left-click or right-click again.

But now I think it is really a problem of Thunar's design for the motive that this does doesn't happen with other file managers.

Also, I remember reading someone in another forum complaining about Thunar because of this precise situation, and that was when I started paying attention to this more seriously as a Thunar bad feature.

Today, before writing this post, I've tested various operative systems I have in various Virtualbox machines, and only Thunar has this dangerous behaviour:
- Debian 9 XFCE
- Debian 10 XFCE
- CentOS 7 (CentOS doesn't have a XFCE version, but I installed it)

This does NOT happen with:
- Linux with file manager PC Man FM
- Linux with MATE default file manager (can't remember the name, but I've tested it)
- Linux with Gnome Classic default file manager (can't remember the name, but I've tested it)
- Windows (all versions: Vista, 7, 10, etc) with file manager Explorer

Because this is so serious, I am goig to repeat it:
- this only happens in Thunar
- does doesn't happen with other file managers
- is everybody wrong, but Thunar?...

Lastly, I would like to know if someone knows how to change this in Thunar.

Last edited by jack_the_pirate (2020-01-14 09:47:25)

=============================================
ToZ
2020-01-14 12:39:07

Exactly what versions of Xfce and thunar are you running that this is happening with?

This is the second report in a week about this issue (see also: https://forum.xfce.org/viewtopic.php?id=13662). I can't replicate this on any of my systems (4.12 or 4.14 with numerous different versions of thunar), but given that multiple people are seeing the issue, I think its time to create a bug report and see what the developer can determine.

I'll give debian another run in a VM to see if I can replicate it there.

Edit: Which GTK (Appearance) and Window Manager themes are you using? Or:

xfconf-query -c xsettings -lv

Last edited by ToZ (2020-01-14 14:55:31)

=============================================
jack_the_pirate 
2020-01-15 10:56:51

Here is the info:

*********************************************
Debian 9 XFCE
Thunar 1.6.11
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName            Classic-Flat-White
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Xfce-basic
/Xft/Antialias                  1
/Xft/Hinting                    1
/Xft/HintStyle                  hintslight
/Xft/RGBA                       none

*********************************************
Debian 10 XFCE - DOES have the issue
Thunar 1.8.4
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName           
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/MonospaceFontName          Monospace 10
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Xfce
/Xft/Antialias                  -1
/Xft/HintStyle                  hintnone
/Xft/Hinting                    -1
/Xft/RGBA                       none

*********************************************
Debian 10 XFCE - does NOT have the issue after changing theme to Adwaita
Thunar 1.8.4
Xfce 4.12

$ xfconf-query -c xsettings -lv
/Gtk/ButtonImages               true
/Gtk/CanChangeAccels            false
/Gtk/ColorPalette               black:white:gray50:red:purple:blue:light blue:green:yellow:orange:lavender:brown:goldenrod4:dodger blue:pink:light green:gray10:gray30:gray75:gray90
/Gtk/CursorThemeName           
/Gtk/CursorThemeSize            0
/Gtk/DecorationLayout           menu:minimize,maximize,close
/Gtk/FontName                   Sans 10
/Gtk/IconSizes                 
/Gtk/KeyThemeName               
/Gtk/MenuBarAccel               F10
/Gtk/MenuImages                 true
/Gtk/MonospaceFontName          Monospace 10
/Gtk/ToolbarIconSize            3
/Gtk/ToolbarStyle               icons
/Net/CursorBlink                true
/Net/CursorBlinkTime            1200
/Net/DndDragThreshold           8
/Net/DoubleClickDistance        5
/Net/DoubleClickTime            400
/Net/EnableEventSounds          false
/Net/EnableInputFeedbackSounds  false
/Net/IconThemeName              Tango
/Net/SoundThemeName             default
/Net/ThemeName                  Adwaita
/Xft/Antialias                  -1
/Xft/HintStyle                  hintnone
/Xft/Hinting                    -1
/Xft/RGBA                       none

*********************************************
CentOS 7
Thunar 1.6.16
Xfce 4.12

=============================================
jack_the_pirate 
2020-01-15 10:58:29

Also, please take a look at this screenshots:

[url=http://imgbox.com/TkqlmHnQ][img]https://thumbs2.imgbox.com/1c/ab/TkqlmHnQ_t.png[/img][/url] 
[url=http://imgbox.com/Q9AQXhkf][img]https://thumbs2.imgbox.com/1b/57/Q9AQXhkf_t.png[/img][/url] 
[url=http://imgbox.com/ICp1qsme][img]https://thumbs2.imgbox.com/02/49/ICp1qsme_t.png[/img][/url] 
[url=http://imgbox.com/KIbzFXjT][img]https://thumbs2.imgbox.com/12/ae/KIbzFXjT_t.png[/img][/url] 
[url=http://imgbox.com/UTVBDzz7][img]https://thumbs2.imgbox.com/af/01/UTVBDzz7_t.png[/img][/url] 
[url=http://imgbox.com/Y9T1UAjA][img]https://thumbs2.imgbox.com/c8/35/Y9T1UAjA_t.png[/img][/url] 
[url=http://imgbox.com/uYKlxO4U][img]https://thumbs2.imgbox.com/24/b4/uYKlxO4U_t.png[/img][/url] 
[url=http://imgbox.com/F2ovH5Kw][img]https://thumbs2.imgbox.com/86/95/F2ovH5Kw_t.png[/img][/url] 
[url=http://imgbox.com/3Sn2YX4R][img]https://thumbs2.imgbox.com/85/32/3Sn2YX4R_t.png[/img][/url] 
[url=http://imgbox.com/YRmrhzU0][img]https://thumbs2.imgbox.com/7e/08/YRmrhzU0_t.png[/img][/url] 
[url=http://imgbox.com/FqRijOUo][img]https://thumbs2.imgbox.com/fd/6c/FqRijOUo_t.png[/img][/url] 
[url=http://imgbox.com/YkOJVNNo][img]https://thumbs2.imgbox.com/7c/8f/YkOJVNNo_t.png[/img][/url] 
[url=http://imgbox.com/Ogq3BSHy][img]https://thumbs2.imgbox.com/b4/06/Ogq3BSHy_t.png[/img][/url] 
[url=http://imgbox.com/TR5rDs4Z][img]https://thumbs2.imgbox.com/45/79/TR5rDs4Z_t.png[/img][/url] 
[url=http://imgbox.com/YbZY4PPP][img]https://thumbs2.imgbox.com/b4/21/YbZY4PPP_t.png[/img][/url]

Last edited by jack_the_pirate (2020-01-15 10:58:57)

=============================================
jack_the_pirate 
2020-01-15 11:07:40

As you can see, in some screenshots, the Thunar right-click menu entry, which is nearer the mouse cursor, appears automatically selected (incorrect) and in other screenshots it doesn't (correct).

I think that the issue is solved in Thunar 1.8.4, which is the version that comes in Debian 10.
However, that version is buggy because the custom actions don't work in the Desktop folder (as you can see in the above screenshots) and that's why I have also posted right-click menu screenshots of Debian 10 inside a folder (/etc).

However, I don't like this Thunar version because the right-click menu (context menu) occupies too much vertical space.
I have created a topic about this a few months ago here:
https://forum.xfce.org/viewtopic.php?id=13239
Just compare these two screenshots and you can see that the Thunar custom actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10

Also, it would be great if this could be solved because Debian 9 LTS will still be active two and a half more years (06-2022) and CentOS 7 will also be active until 2024.
I use these distros stable versions (Debian 9 instead of Debian 10, and CentOS 7 instead of CentOS 8) very much in some work situations, and I prefer them because they are much more stable.
And having Thunar custom actions working right is a must because they save much time.

Last edited by jack_the_pirate (2020-01-15 11:18:12)

=============================================
ToZ
2020-01-15 12:47:00

--------------
jack_the_pirate wrote:

"As you can see, in some screenshots, the Thunar right-click menu entry, which is nearer the mouse cursor, appears automatically selected (incorrect) and in other screenshots it doesn't (correct)."

--------------
ToZ

The Thunar 1.8.x series is built on GTK3 - which means it uses the GTK3 appearance settings. Themes like "Xfce" are a GTK2-only theme. If the issue is solved by using a theme like Adwaita, then you will need to find and use a GTK3-compatible theme.

--------------
jack_the_pirate wrote:

"I think that the issue is solved in Thunar 1.8.4, which is the version that comes in Debian 10.
However, that version is buggy because the custom actions don't work in the Desktop folder (as you can see in the above screenshots) and that's why I have also posted right-click menu screenshots of Debian 10 inside a folder (/etc)."

--------------
ToZ

This was an unfortunate packaging error. Thunar 1.8.x use the version 3 thunarx api and you need xfdesktop at least 4.13 development series. Since Debian won't package development releases, this will be an unfortunate issue for this debian version. You may wish to raise this as a bug in debian to see if they would be willing to cherry-pick some xfdesktop 4.13 commits to make it work.

--------------
jack_the_pirate wrote:

"However, I don't like this Thunar version because the right-click menu (context menu) occupies too much vertical space.
I have created a topic about this a few months ago here:
https://forum.xfce.org/viewtopic.php?id=13239
Just compare these two screenshots and you can see that the Thunar custom actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10

Also, it would be great if this could be solved because Debian 9 LTS will still be active two and a half more years (06-2022) and CentOS 7 will also be active until 2024.
I use these distros stable versions (Debian 9 instead of Debian 10, and CentOS 7 instead of CentOS 8) very much in some work situations, and I prefer them because they are much more stable.
And having Thunar custom actions working right is a must because they save much time.

--------------
ToZ

With respect to the custom actions on the desktop, you will probably need to follow-up with the debian devs to see if they can address the issue. Feel free to also create a bug report against xfdesktop to see if they are willing to or if it is even possible to backport the version 3 thunarx api to the xfdesktop 4.12 branch to address this issue

With respect to auto-clicking of a menu item, you may need to use a GTK3-compatible theme like Adwaita (or Arc, or Greybird, or others).

=============================================
alcornoqui
2020-01-15 16:30:09

There's this Debian Stable bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930520

"Debian Bug report logs - #930520
xfdesktop4: regression : doesn't have the Thunar's custom actions
Package: xfdesktop4
Reported by: Johann <j.rios@laposte.net>
Date: Fri, 14 Jun 2019 11:33:02 UTC
Severity: normal
Found in version xfdesktop4/4.12.4-2"

=============================================
jack_the_pirate
2020-01-15 19:11:10

Above, where it reads (incorrect):
--------------
jack_the_pirate wrote:
Just compare these two screenshots and you can see that the Thunar custom actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/uYKlxO4U - Debian 9
http://imgbox.com/3Sn2YX4R - Debian 10
--------------

Read this instead (correct):
Just compare these two screenshots and you can see that the Thunar custom actions on Debian 10 doesn't show all, but Debian 9 yes:
http://imgbox.com/UTVBDzz7 - Debian 9
http://imgbox.com/F2ovH5Kw - Debian 10

Last edited by jack_the_pirate (2020-01-15 19:11:33)

=============================================
kreemoweet
2020-01-16 08:36:47

I'm another afflicted with this Thunar bug. Ubuntu 18.04, xfdesktop4 4.12.3-ubuntu2, Thunar 1.6.15.
Theme is a slightly modified Greybird.
The menu item erroneously executed is usually, but not always, the one immediately adjacent to the cursor position.
Quite frequently, but not always, right-clicking the same item again, after dismissing or undoing the unwanted results
of the first right-click, will bring up a normal context menu with no items selected (as should always be the case), or
with the adjacent item selected but not executed.

=============================================
ToZ
2020-01-16 09:53:05

Someone who is affected by this should create a bug report.

=============================================
CwF
2020-01-16 09:53:05

Maybe use an xinput test to show there are no extra clicks or any positional drift while clicking in thunar.

=============================================
Comment 1 alexxcons editbugs 2020-01-18 08:36:48 CET
Thanks for reporting !

Sorry, I cannot reproduce the bug (double right-click does not execute something for me)
As well for me nothing is selected automatically.

Please note that only the context menu inside a thunar window is the thunar context menu. If you right-click on somewhere outside of the thunar window, its e.g. the context menu of xfdesktop(which looks very similar), or of the panel.

So this bug as well shows for you when using xfdesktop context menu or panel context menu ?

I tried different setups, but so far I had no luck to reproduce the bug. In order to fix such a bug, I first need to know how to reproduce it. So:
- Does the bug show with default Greybird / Adwaita theme ?
- Does the bug show with some different icon theme ?
- Does the bug show when another monitor resolution is selected ? (Possibly related to clickable area)


Bug #14216 seems to be related to this bug, which got fixed a while ago.

Patches would be very welcome !

( Please next time focus a bit, nobody want to read such a wall of text ! Links to forum posts are sufficient, you dont need to copy + paste everything)
Comment 2 alexxcons editbugs 2020-01-18 08:47:47 CET
> As well for me nothing is selected automatically.
For some reason I dont understand yet, the "area taken by your mouse-pointer" seems to be increased. So that your mouse pointer directly is located on the first item. Possibly you did some costumization related to the active mouse area ?

- You are using some high-res monitor ? (Possibly "active mouse area" is different there)

- Does it always happen, or just sometimes ? (Possibly it is related to your mouse sensitivity .. on the other hand, the distance from mouse pointer to context menu seems to be the same for e.g. thunar and nautilus )

- You mentioned other file managers for which it did not heppen. Which file managers you tried ? Does it happen for nautilus ?
Comment 3 alexxcons editbugs 2020-01-18 08:48:45 CET
*** Bug 16389 has been marked as a duplicate of this bug. ***
Comment 4 jack_the_pirate 2020-01-18 14:39:31 CET
Created attachment 9394 
Thunar custom actions file (uca.xml) with 100 custom actions for test purposes
Comment 5 jack_the_pirate 2020-01-18 14:40:05 CET
This happens both in the Desktop and inside Thunar.

Successful replication of this bug can be made if you follow these steps.

Pay attention to the mouse arrow in steps 2 and 5.

I have done this today exactly like written below.
And took the following 14 screenshots:

http://imgbox.com/ntgdZxTM Debian
http://imgbox.com/n3HSZ5E9 Debian
http://imgbox.com/8M74ecbQ Thunar
http://imgbox.com/inRWD6BB Thunar
http://imgbox.com/VOrp3Nko Thunar
http://imgbox.com/WO84w2xT Thunar
http://imgbox.com/ye1r0OoI Thunar
http://imgbox.com/C2Anzw1X Thunar
http://imgbox.com/bSqvJb4l Thunar
http://imgbox.com/dDKtERXH Thunar
http://imgbox.com/ECrcv82s Nautilus 1-2
http://imgbox.com/QuUt6oIa Nautilus 2-2
http://imgbox.com/YfK01K2A PCManFM 1-2
http://imgbox.com/7s0cR7BD PCManFM 2-2
---------------------------------------------
step 1

debian-9.11.0-amd64-xfce-CD-1.iso
in Virtualbox, install Debian 9.11 9 XFCE
and activate a mirror during installation for upgrades
so that the final result is a Debian 9 fully updated system

downloaded from this page:
https://cdimage.debian.org/mirror/cdimage/archive/9.11.0/amd64/iso-cd/

download link:
https://cdimage.debian.org/mirror/cdimage/archive/9.11.0/amd64/iso-cd/debian-9.11.0-amd64-xfce-CD-1.iso

screenshots
http://imgbox.com/ntgdZxTM
http://imgbox.com/n3HSZ5E9

---------------------------------------------
step 2

without changing anything at all (themes, config files, etc), do this:
- in the Desktop, right-click in upper half of the screen
- in the Desktop, right-click in lower half of the screen
- open a folder with Thunar and right-click in upper half of the screen
- open a folder with Thunar and right-click in lower half of the screen

screenshots
http://imgbox.com/8M74ecbQ
http://imgbox.com/inRWD6BB
http://imgbox.com/VOrp3Nko
http://imgbox.com/WO84w2xT

---------------------------------------------
step 3

- create a lot of Thunar custom actions

I have created 100 in this test, which are in fact the same (just a simple "mkdir screenshots")

if you prefer, you can use the attached file (uca.xml) to replace the default custom actions file

default custom actions file location:
/home/YOUR-USER/.config/Thunar/uca.xml

---------------------------------------------
step 4

- logout
- login
to be completely sure that the new custom actions file will be work both in the Desktop and in Thunar

---------------------------------------------
step 5

after logging in, do this again like in step 2:
- in the Desktop, right-click in upper half of the screen
- in the Desktop, right-click in lower half of the screen
- open a folder with Thunar and right-click in upper half of the screen
- open a folder with Thunar and right-click in lower half of the screen

screenshots
http://imgbox.com/ye1r0OoI
http://imgbox.com/C2Anzw1X
http://imgbox.com/bSqvJb4l
http://imgbox.com/dDKtERXH

---------------------------------------------
At this point, as anybody that performed these steps will see, the problem is that a menu entry (which in fact is a command) of the right-click menu is automatically selected by default.

To my knowledge, this does NOT happen in other file managers in Linux or Windows or BSD or Apple.

Nautilus and PCManFM also have custom actions and that does NOT happen in them, as you can see here (also tested in the same Debian 9 system):

Nautilus
http://imgbox.com/ECrcv82s
http://imgbox.com/QuUt6oIa

PCManFM
http://imgbox.com/YfK01K2A
http://imgbox.com/7s0cR7BD

I can only understand the right-click menu automatically selecting a menu entry by default in special situations:
- if there are NO custom actions present
- if the user wants it and set it so

To fully understand the bad consequences of this, please read what I wrote above in the forum post at time "2020-01-14 09:45:40 WET"

=============================================
Comment 6 alexxcons editbugs 2020-01-18 18:04:04 CET
I overlooked that you reporting as well for debian 9.

Debian 9 uses thunar 1.6.11 .. that's from the stoneage. Even for the xfce4.12 branch, there is already thunar 1.6.18 available ... same for CentOS 7.  Thunar 1.6.x is out of support from my side.

Before I start installing & testing a vm, please just answer the remaining questions I asked above (I prefer short and pregnant answers):
- Does the bug show with default Greybird / Adwaita theme ?
- Does the bug show with some different icon theme ?
- Does the bug show when another monitor resolution is selected ? 
- You are using some high-res monitor ?

(I am currently using a debian 11 on all of my maschines, and I used to run debian 10 before .. never saw that bug. Thats why I guess it has something to do with your setup, e.g. your monitor resolution. )
Comment 7 jack_the_pirate 2020-01-19 04:44:35 CET
(In reply to alexxcons from comment #6)
> I overlooked that you reporting as well for debian 9.
> 
> Debian 9 uses thunar 1.6.11 .. that's from the stoneage. Even for the
> xfce4.12 branch, there is already thunar 1.6.18 available ... same for
> CentOS 7.  Thunar 1.6.x is out of support from my side.
> 
> Before I start installing & testing a vm, please just answer the remaining
> questions I asked above (I prefer short and pregnant answers):
> - Does the bug show with default Greybird / Adwaita theme ?
> - Does the bug show with some different icon theme ?
> - Does the bug show when another monitor resolution is selected ? 
> - You are using some high-res monitor ?
> 
> (I am currently using a debian 11 on all of my maschines, and I used to run
> debian 10 before .. never saw that bug. Thats why I guess it has something
> to do with your setup, e.g. your monitor resolution. )

---------------------------------------------
Question
"- Does the bug show with default Greybird / Adwaita theme ?"

Answer
Greybird: Debian 9 XFCE doesn't have a theme with this name.
Adwaita: Yes, the exact same thing happens.
I also tried with other themes and the same thing happens.
Note:
In Debian 10 with Thunar 1.8.4 with Adwaita theme and Adwaita icon theme this does NOT happen, as stated above.

---------------------------------------------
Question
"- Does the bug show with some different icon theme ?"

Answer
Yes, it happens with the Adwaita icon theme also.
And also with Gnome, HighContrast and Tango (there are no more icons themes in Debian 9 XFCE).

---------------------------------------------
Question
"- Does the bug show when another monitor resolution is selected ?"

Answer
Yes, it does: 1600 x 1200, 1400 x 1050, 800 x 600.

---------------------------------------------
Question
"- You are using some high-res monitor ?"

Answer
No, I'm not.
My monitor is a 4:3 1600 x 1200 (NEC MultiSync LCD 2170NX).

---------------------------------------------
Comment 8 alexxcons editbugs 2020-01-19 09:10:49 CET
Thanks alot for the answers !

(In reply to jack_the_pirate from comment #7)
> ---------------------------------------------
> Question
> "- Does the bug show with default Greybird / Adwaita theme ?"
> 
> Answer
> Greybird: Debian 9 XFCE doesn't have a theme with this name.
sudo apt-get install greybird-gtk-theme
.. thats the default xfce theme nowadays (but you dont need to test .. see below))

> Adwaita: Yes, the exact same thing happens.
> I also tried with other themes and the same thing happens.
> Note:
> In Debian 10 with Thunar 1.8.4 with Adwaita theme and Adwaita icon theme
> this does NOT happen, as stated above.
Haha, sorry, I did not get that very important detail :P (that's why I prefer short, pregnant information, instead huge walls of text) 
Somewhere in your first commet you wrote the opposite:

> Debian 10 XFCE - DOES have the issue
> Thunar 1.8.4
> Xfce 4.12
That's why I thought it is still a bug in the current version.

I suppose the fix of Bug #14216 as well would fix your problem in Debian 9. The fix only was applied to the 1.8.x branch, not to the 1.6.x branch, since it was considered to be a regression.
As said above, thunar 1.6.x will not get any further bugfixes from me.  Even if I would push bugfixes to the 1.6.x branch, Debian 9 and CentOS 7 even now dont use the latest bugfix version of the thunar 1.6.x branch (which is 1.6.18).

So I think the options you have are:
- Update your system to Debian10 / Cent OS8, where the bug does not show (I would advice so, since you anyhow need to do that sooner or later)
- Install thunar 1.6.x from source and apply the patch of Bug #14216 to check if it helps
Comment 9 jack_the_pirate 2020-01-19 23:13:30 CET
(In reply to alexxcons from comment #8)
> Thanks alot for the answers !
> 
> (In reply to jack_the_pirate from comment #7)
> > ---------------------------------------------
> > Question
> > "- Does the bug show with default Greybird / Adwaita theme ?"
> > 
> > Answer
> > Greybird: Debian 9 XFCE doesn't have a theme with this name.
> sudo apt-get install greybird-gtk-theme
> .. thats the default xfce theme nowadays (but you dont need to test .. see
> below))

- when you say nowadays, you are not talking about Debian 9, and Debian 9 is the point!
- in Debian 9, the default theme is Xfce, ok? 
- not Greybird
- Greybird is not even installed by default.
- so, there is a bug!
- and this bug happens in ALL themes and ALL themes icons: Adwaita, etc

- in Debian 10, this also happens with the default Debian 10 theme (Xfce)
- so there is a bug!
- BUT if you change the theme to Adwaita, this does NOT happen
- I have said that above in the wall of text (as you call it)

- also, Debian 10 does NOT display the custom actions on the Desktop, in ALL themes and ALL theme icons!

Like stated here in the Debian Forum:
http://forums.debian.net/viewtopic.php?f=10&t=143220

Or here, in the Arch Forum:
https://bbs.archlinux.org/viewtopic.php?pid=1807697#p1807697

- I guess that's a bug too, isn't it?

- but I guess that's not a bug worth solving to you, because if everybody uses the latest version of Debian and XFCE and Thunar, there is no bug!

- wonderful for the millions of users that use LTS releases out there that rely on XFCE and Thunar!:

- Debian 9 LTS is supported until June-2020
https://wiki.debian.org/LTS

- CentOS 7 is supported until June-2024
https://wiki.centos.org/About/Product

Not to mention all the distros that rely on Debian 9 and CentOS 7!
 
 
> > Adwaita: Yes, the exact same thing happens.
> > I also tried with other themes and the same thing happens.
> > Note:
> > In Debian 10 with Thunar 1.8.4 with Adwaita theme and Adwaita icon theme
> > this does NOT happen, as stated above.
> Haha, sorry, I did not get that very important detail :P (that's why I
> prefer short, pregnant information, instead huge walls of text) 
> Somewhere in your first commet you wrote the opposite:
> 
> > Debian 10 XFCE - DOES have the issue
> > Thunar 1.8.4
> > Xfce 4.12
> That's why I thought it is still a bug in the current version.

Read again the wall of text if you want, because I said that's related to the Xfce theme and NOT Adwaita.
There are two parts:
- Debian 10 XFCE - DOES have the issue
[theme Xfce / icon theme Tango]
- Debian 10 XFCE - does NOT have the issue after changing theme to Adwaita
[theme Adwaita / icon theme Tango]



> I suppose the fix of Bug #14216 as well would fix your problem in Debian 9.
> The fix only was applied to the 1.8.x branch, not to the 1.6.x branch, since
> it was considered to be a regression.
> As said above, thunar 1.6.x will not get any further bugfixes from me.  Even
> if I would push bugfixes to the 1.6.x branch, Debian 9 and CentOS 7 even now
> dont use the latest bugfix version of the thunar 1.6.x branch (which is
> 1.6.18).
> 
> So I think the options you have are:
> - Update your system to Debian10 / Cent OS8, where the bug does not show (I
> would advice so, since you anyhow need to do that sooner or later)

Like I said above, the custom actions don't work in the Desktop on Debian 10!
So that's not an option for people that use a lot of custom actions and also on the Desktop!



> - Install thunar 1.6.x from source and apply the patch of Bug #14216 to
> check if it helps

What patch? 
I read the post and I didn't see any patch!
I only see your comments saying "it only happens if" 4 times but not solving anything!


Also, in Google you can find other users complaining about this issue. 

The problem is that everybody call this bug something different, and call the menu different names:
- right-click menu
- service menu
- custom actions menu
- etc

And may this be solved or not, but the truth is that this is affecting everybody that uses CentOS 7 (Thunar and Desktop), Debian 10 (in the Desktop) and Debian 9 (Thunar and Desktop).

And these distros are used by people that do not want bleeding edge distros!
For that, there is Fedora and Ubuntu!

The point of stable LTS distros is for everything work well and like it is intended for their software versions!

Finally, I've made this bug report for me, but also for the other people of the XFCE forum, that posted there in the initial post, and asked there for this bug to be reported!
Comment 10 alexxcons editbugs 2020-01-20 13:20:46 CET
(In reply to jack_the_pirate from comment #9)
> - when you say nowadays, you are not talking about Debian 9, and Debian 9 is
> the point!
> - in Debian 9, the default theme is Xfce, ok?
> - not Greybird
Yes, I guess the default theme for xfce 4.12 was the Xfce theme (that's a gtk2 theme by the way, dont use it with xfce 4.14)

> - so, there is a bug!
I never said something different. There is bug and seems to be fixed in the current version (see linked patch)
 
> - in Debian 10, this also happens with the default Debian 10 theme (Xfce)
If you install Debian 10 with xfce, the theme "Xfce" should not be available any more. (If debian 10 still installs the theme "Xfce" as default, please report a bug in the debian bugtracker. The default theme for Xfce4.14 is greybird. (As well known to work well with adwaita))

> - also, Debian 10 does NOT display the custom actions on the Desktop, in ALL
> themes and ALL theme icons!
That's a known version incompartibility between thunar 1.8.x and xfdesktop 4.12.x. Is fixed since xfdesktop 4.13. Thunar 1.8.x was released a bit to early, without xfdesktop in mind. Sorry for that, (there was already a closed bug for that on thunar or xfdesktop, though I cannot find it any more) .. though IMO no reason to get uppish.

> - wonderful for the millions of users that use LTS releases out there that
> rely on XFCE and Thunar!:
Well, I did not choose to be part of a LTS release. Actually I provided patches for the thunar 1.6.x branch and did releases for it until half a year ago. But whats the point to do so if these bugfix versions are not used by the LTS distros ?

As I said above, there IS ALREADY a thunar 1.6.18, but it is not used by the LTS releases .. I dont know why. Ask your distro.

> > - Install thunar 1.6.x from source and apply the patch of Bug #14216 to
> > check if it helps
> 
> What patch? 
> I read the post and I didn't see any patch!
> I only see your comments saying "it only happens if" 4 times but not solving
> anything!
Dude, its not like it is hidden or something like that .. just check the second comment on the bugzilla bug I already linked:
https://git.xfce.org/xfce/thunar/commit?id=fad4aedea9a0454fb0c18c1ef1b55cf9538bd476

You might want to compile thunar 1.6.x from source, see if the patch helps, and if so, you may ask your distro to apply at least that patch, if they are not going for the latest bugfix version of thunar for some reason.
Comment 11 jack_the_pirate 2020-01-20 13:37:53 CET
(In reply to alexxcons from comment #10)

Ok, alexxcons. 

Sorry for my bad mood above and thank you for your help and ideas.

I will try that.
Comment 12 alexxcons editbugs 2020-02-01 19:10:57 CET
*** Bug 13397 has been marked as a duplicate of this bug. ***

Bug #16388

Reported by:
jack_the_pirate
Reported on: 2020-01-17
Last modified on: 2020-02-01
Duplicates (2):
  • 13397 Long right clicks onto a file execute an action other than just open context menu for that file
  • 16389 Thunar righ-click menu has a serious drawback that must be corrected

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Additional information