Created attachment 7783 thunar_iconview_too_small.png Currently Thunars maximum thumbnail size doesn't allow to be setted any higher than 128. This makes it sometimes really hard to guess whats roughly inside the picture or what this is. Too a little bigger thumbnails makes browsing a lots easier, especially on laptop and beamer. This is not only about preview as in pictures but also goes for e.g. folders. I installed other filemanagers and looked at what they allow and I found out that: * Nautilus is maxed at ~170px (longest side scaled) * Dolphin is maxed at ~250px (shortest side scaled) Attached descriptive screenshot. I have to admit 170 is mostly enough to see something, but there may be persons preferring a little higher. This is not about default value but more options for users. I would be very happy if values of e.g. ~170,200,256 are getting added. Made some searches too and I saw that many people asked in various forums quite the same question, why they can't make it any bigger. But nobody seemed to reported it yet. Too found a two week old forum entry on manjaro forums (which is about hidpi, but still shows the problem): https://forum.manjaro.org/t/thunar-icon-size/48421 It also has a screenshot and quite like what I would prefer Thunar to also allow in terms of icon size. As far as I can see this is all about the values in this enum: https://git.xfce.org/xfce/thunar/tree/thunar/thunar-enum-types.h#n133 Plus additional strings to describe the values. So this shouldn't be all too hard? Notice: This all isn't about hidpi or scaling on hidpi screens. Really only about the icon size values. Sorry if this is a duplicate, searched but couldn't find something: https://bugzilla.xfce.org/buglist.cgi?bug_status=__all__&content=icon&no_redirect=1&order=Importance&product=Thunar&query_format=specific
Created attachment 7784 Adding 170, 200, 256, 512, but not for thumbnails There is more to change than just this enum. Attached a patch which does this first step. Already works fine for folder/file icons. (Actually these two enums IMO should be merged to one) As well the text-size should be changed accoringly For thumbnails something else needs to be changed, so far I dont know what. If you have time to figure out, please let us know ! Further patches are welcome !
*** Bug 13507 has been marked as a duplicate of this bug. ***
Created attachment 7787 Change thumbnail-size to large Hah, found it ! "large" will use a size of 265 instead of 128(normal). It looks like "large" is the maximum here: https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#THUMBSIZE So I will remove the 512px option from the first patch to stay consistent. Will modify this patch in order to have the option to set the thumbnail-size in xfce4-settings-editor ... automatic text-size adjustment still missing.
Created attachment 7788 folder/file vs thumbnail > For thumbnails something else needs to be changed, so far I dont know what. If you have time to figure out, please let us know ! From what I have understood, is that tumbler gets command for "do thumbnail for that" but is somewhat limited to 128px? :D > As well the text-size should be changed accoringly > ... automatic text-size adjustment still missing. Sorry I don't get this one. Text-Size doesn't change when zooming in or out. Do you mean the invisible rectangle where text is placed in or really as in font size? Have to admit that if I have some more bigger options available, and especially the roughly ~170px for thumbnails. Even if 170 seems not to be some standard size it feels good, not small like 128 not big like 256 - good in the middle. Tried to find out where this 170 comes from or whats the exact value but had no success yet. It only looks like nautilus uses 128px for folder/file icons, but at the same time allows thumbnails to be 170px at that level. I think Thunar is here (if gets merged) then superior because it is consistent with icon and thumbnail size.
Created attachment 7789 values Thanks for fast response and working on it by the way! Did quick calcluations with multiples of 8. What I would suggest are 168 (instead of 170) and 208 (instead of 200)
Created attachment 7810 Fully featured fix @Gregor, you are welcome .. "larger thumbnails" anyhow was on my personal TODO-List ;) I took 192px and 256px, since they corresponds to a zoom-level of 300% and 400% when 64px is used as 100%. Here a fully featured patch, ready to be tested. The details: * added two additional zoom-levels and icon-sizes (192px and 256px) * introduced an enum and Properties to maintain thumbnail-size * added usage of "large" thumbnails (max 256px x 256px) * automatically use large thumbnails for icon-size > 128px * renamed zoom-levels, usage of percentage values (dont know what could be larger than "LARGEST" ... this kind of naming was just limiting us ) * renamed icon-size values, count in pixels
Uh, I did not add automatic text-size adjustment so far .. but IMO the current patch is good enough for the first. Since this is a feature, and thunar currently is in feature-freeze mode, the patch will be applied to master after xfce4.14 got released. So if you want to take a try, you will need to build thunar from source.
Thanks for working on it! Have compiled it here on Arch Linux, git version + patch. No problems here. Zooming in/out works, and sizes are accordingly. When started thunar shows sidebar and content with 256px. Maybe go here with something like 16px+64px per default? Just one personal notice - 128 somewhat feels small, 192 feels big, but no sweat spot in between. This is a feature? Feels more like a improvement! :D Sad to hear that, especially since 4.14 seems not to be really in sight. I don't know, waiting like 1-2 years to get something like this in sounds bad to potential contributors :D.
Hi Alex, those improvements are very welcome, thanks for working on this! I gave it try (didn't have time to review the code), here are my results: - As noted by Gregor, the default size is 256px, that's way too large. - Changing icons size while in Detailed view is kinda broken, the row height is not updated correctly As for the feature freeze, this is not a big thing, high risk change, I think we can ship it in a 1.8.x release once it's stable, let's just discuss on #xfce-dev with other devs how we should manage stable and development releases.
Thanks for testing both ! - Yes, I will add 160px ( zoom level 250% ) - Not sure yet where the default of 256px comes from ( seems to be related with reading old-style enum-value-names from settings), I will investigate. - Will check if I can do something for the detailed view row-height Regarding releases, it looks like we can already have a 4.14 branch for the 1.8.x series and tag 1.9.x dev releases in master. So even if we dont ship this improvement with 1.8.x I guess at least for Arch users there will be no problem to use the latest development release. @Gregor 4.14 is not that far, my personal estimate would be, before end of this year.
ok! tell when something/patch/branch available to test. will tell when find some problen
Created attachment 7812 patch to fix the bug Here my next try: - added 160px as IconSize/ZoomLevel 250% - bypass problem with "g_value_transform" ... on unknown values, like "THUNAR_ZOOM_LEVEL_NORMAL", g_value_transform just picks the last value of the GEnumValue List instead of returning false. The last value till now was always the maximum value ... meh, another bug I have to report on gtk3 - I modified the patch slightly to match for master ( patch will conflict with older versions because of my recent push of Bug #14433 ) - So far I did not find the right property to control the detailed view row-height. However for me it seems to behave correctly. @Andreldm maybe you have some screenshot ? Would be great if you could have a try !
Have compiled git-master + this patch and works for me here
Here is a video of the detail view bug I described before: https://youtu.be/SuvOHpNgQZ4 It still happens with the latest patch, seems like a synchronization problem. Also, as soon as Thunar starts with the changes introduced, the icons are bit bigger than before, maybe there should be logic to convert old values to new ones. In the same sense, under Preferences -> Side Pane both comboboxes have no values, one has to select something.
Thanks for testing & the video ... yes, this really looks broken =( . Will do some attempts to reproduce it. "Icons a bit bigger" is, because currently I use a fixed default if the old enum-string is not found. Yes, possibly best is to provide as well the old enum-strings, pointing to the new enum values, so the transition to the new values will be even smoother / not be recognized at all. For the empty combo-boxes I have to check. Possibly a similar issue.
Created attachment 7831 patch ok, here my next try. - Full support of old icon sizes and zoom-levels (fixes as well empty combo boxes) I am not able to reproduce the detailed-view bug, however I have an assumption what could be the cause .. will add an separate patch for it.
Created attachment 7832 attempt to fix broken row height Here the second one. @Andre Miranda, could you please give it a try ?
Created attachment 7844 hopefully final patch ... and another try. Hopefully the last one - The messed up height in the icon view should be fixed by Bug #14548 - Fixed a problem in thunar_zoom_level_to_thumbnail_size which caused a reload on each zoom-level change - Fixed styling
Even after fixing #14548 "messed up icon-view" still is an issues occasionally when "fixed_columns" are used and the attached patch is applied. - By far not as bad as it was before, but clearly there is room for improvement. - F5 will fix all graphical glitches - It looks like a timing problem. "reload" seems to be triggered to fast (other calls are queued, but reload is not)
Latest push on bug #14548 fixed all remaining issues .. after another review I think the code looks good to get pushed.
Alexander Schwinn referenced this bugreport in commit 95a5c2559f45f662e0a4c1826cf77f863286c46f More options for thumbnail size (Bug #14451) - added three additional zoom-levels and icon-sizes (160px, 192px and 256px) - added usage of "large" thumbnails (max 256px x 256px) - automatically use large thumbnails for icon-size > 128px - renamed zoom-levels, usage of percentage values - renamed icon-size values, count in pixels - support for old naming https://git.xfce.org/xfce/thunar/commit?id=95a5c2559f45f662e0a4c1826cf77f863286c46f
Alexander Schwinn referenced this bugreport in commit e2beb62be49de60a7a02ca43aacfbb0c0ffe98be More options for thumbnail size (Bug #14451) - added three additional zoom-levels and icon-sizes (160px, 192px and 256px) - added usage of "large" thumbnails (max 256px x 256px) - automatically use large thumbnails for icon-size > 128px - renamed zoom-levels, usage of percentage values - renamed icon-size values, count in pixels - support for old naming https://git.xfce.org/xfce/thunar/commit?id=e2beb62be49de60a7a02ca43aacfbb0c0ffe98be
*** Bug 14057 has been marked as a duplicate of this bug. ***
I'm using it for some days now and it solves what I reported plus even more. Thanks for work on this!
*** Bug 14798 has been marked as a duplicate of this bug. ***
*** Bug 1596 has been marked as a duplicate of this bug. ***
Using Thunar 1.8.14-1 on Ubuntu 20.10 and the thumbnails are tiny in normal zoom level. The small thumbnails of Thunar is only useful for distinguishing between media files (ex. distinguishing images from videos) but not useful for identifying the file itself. To achieve the useful size (taking Windows 7 as standard) I have to zoom the view 300% which makes folders huge too. Would like to have bigger thumbnails within normal zoom level.
Please open a new bug for that. I have no idea how windows 7 looks like, would be good if you could provide a screenshot.
@alexxcons https://bugzilla.xfce.org/show_bug.cgi?id=14057