Created attachment 7772 very incomplete patch To select whether thunar will draw black frames around thumbnails ( disabled in thunar 1.8.0 ) Drawing these frames around thumbnails looks neat, but will delay the first draw a bit, specially on older systems, on folders with many pictures this may be annoying. Attached a very incomplete patch which I will finish later
Just to keep in mind: We agreed that the checkbox will be on Preferences --> first page, on top of "Sort folders before Files"
Alexander Schwinn referenced this bugreport in commit e859b82dfef46eefb3af95f5b632222526c9293e Disable thumbnail frame for the 1.8.0 release, since it may have an performance impact. (Bug #14433) https://git.xfce.org/xfce/thunar/commit?id=e859b82dfef46eefb3af95f5b632222526c9293e
Created attachment 7782 Patch to add preferences item Attached a patch. To be applied after xfce4.14 got released
Works fine here, just a couple of comments: 1) if the property is toggled, it only takes effect when each Thunar window is focused (obviously when the preferences dialog loses focus). I have no idea if there's a signal that could be globally emitted to request a redraw or refresh. But I would not worry about it. 2) small formatting issue in thunar-icon-factory.c, around line 481, the "if" statement (should have one space before parenthesis and none inside them). Other than that, everything LGTM, well done!
Alexander Schwinn referenced this bugreport in commit 6e2b1d762ba177fba19e0bb4d466f5a1ed524df4 Add property to enable/disable frames on thumbnails (Bug #14433) https://git.xfce.org/xfce/thunar/commit?id=6e2b1d762ba177fba19e0bb4d466f5a1ed524df4
Thanks for review ! I as well fixed 1) now, since I learned how to reload thumbnails in Bug #14451 :)
Alexander Schwinn referenced this bugreport in commit c27af662247e56d283c7a41190bec65faea05031 Add property to enable/disable frames on thumbnails (Part II) (Bug #14433) - Fix GLib-GObject-CRITICAL at startup https://git.xfce.org/xfce/thunar/commit?id=c27af662247e56d283c7a41190bec65faea05031