! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-terminal hangs on setting title dialog box
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Aaditya Bagga 2017-11-11 20:35:56 CET
Hi,

If I try to set the title for a tab in xfce4-terminal, it stops responding (hangs completely).

Steps to reproduce:
-------------------

1. Open xfce4-terminal.
2. Create a tab in it (Ctrl + t).
3. Try to set the title of a tab by double clicking on it.

What happens:
-------------

Irrespective of whether the title is entered and set or not, xfce4-terminal hangs.

System details:
---------------

$ xfce4-terminal -V      
xfce4-terminal 0.8.6 (Xfce 4.12)

Distro:
Slackware 14.2

xfce4-terminal 0.8.6 was self compiled by me.
vte version is vte-0.50.1.

If I need to provide more details or do some debugging please let me know.
Comment 1 Igor editbugs 2017-11-11 20:59:29 CET
Hi, what is your gtk3 version?

Could you please run 'xfce4-terminal --disable-server' from another terminal and see if there is any console output when setting tab title?
Comment 2 Aaditya Bagga 2017-11-11 21:08:47 CET
Hi Igor,

gtk3 is gtk+3-3.18.9

I get the following output in the parent terminal on setting tab title:

(xfce4-terminal:3555): Gtk-CRITICAL **: gtk_widget_get_toplevel: assertion 'GTK_IS_WIDGET (widget)' failed

Looks like your thinking is correct that it may have something to do with the gtk3 version and apologize if that is the case; I should have thought of it since the minimum supported gtk3 version is 3.20.
Comment 3 Igor editbugs 2017-11-13 16:04:09 CET
Hi Aaditya,

I have downgraded gtk3 version to 3.18.9 on my Ubuntu system, and I can reproduce the bug here. Let me dig into it, and thanks for the report!
Comment 4 Igor editbugs 2017-11-13 16:37:30 CET
I've found this bug files against gtk3 that looks kind of similar to ours: https://bugzilla.gnome.org/show_bug.cgi?id=766323
It's talking about popovers and Gtk-CRITICAL messages.

The bug has been fixed by this commit: https://github.com/GNOME/gtk/commit/76a5e3fc3cefebff397a2dcf94f4699c32087979
The commit seems to have been included into gtk3 version 3.20.6.
My assumption that this bug may be related can be confirmed by fact that I have no issues with gtk3 versions 3.20.8 and higher.

Aaditya, can you try gtk3 3.20.6 or higher, or apply the patch to gtk3 in case you're building it from sources? Thanks!
Comment 5 Igor editbugs 2017-11-16 16:37:11 CET
Hi Aaditya,

Any update? Thanks.
Comment 6 Aaditya Bagga 2017-11-16 17:36:43 CET
Hi Igor,

I just tested with old gtk (3.18.9) patched with above patch, the issue is still there.

However if it works with at your end with gtk3 3.20.6+, I think it can be marked as resolved :-)

When I switch to slackware-current or next slackware version (currently gtk 3.22 is there), will check if the bug exists.

Warm regards,
Aaditya
Comment 7 Git Bot editbugs 2017-11-27 17:15:37 CET
Igor referenced this bugreport in commit e38461b93f4edad2b9bd83920caea9711d7885f0

Bump required GTK+ version to 3.20.8

https://git.xfce.org/apps/xfce4-terminal/commit?id=e38461b93f4edad2b9bd83920caea9711d7885f0
Comment 8 Igor editbugs 2017-11-27 17:16:47 CET
I've bumped the required GTK+ version to 3.20.8 that doesn't seem to suffer from this bug.
Comment 9 Igor editbugs 2018-01-17 14:51:21 CET
*** Bug 14170 has been marked as a duplicate of this bug. ***
Comment 10 Igor editbugs 2018-01-23 14:30:16 CET
*** Bug 14188 has been marked as a duplicate of this bug. ***

Bug #13996

Reported by:
Aaditya Bagga
Reported on: 2017-11-11
Last modified on: 2018-01-23
Duplicates (2):
  • 14170 Terminal freezes when trying to rename tab in existing window
  • 14188 Terminal freezes after being set title

People

CC List:
2 users

Version

Attachments

Additional information