! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
gtk 2.24.31 regression - folders grayed out in wallpaper choose dialog
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Philip Müller 2016-09-10 11:06:53 CEST
Created attachment 6828 
Screenshot of grayed out folder selection

Seems with gtk 2.24.31 a lot of filechooser changes[1] got added. However I already created a bugreport [2]. Gnome devs didn't react. The culeprint is the addition of MODEL_COL_IS_SENSITIVE[3]. Can it be checked, what is needed to fix the grayed out folders in the dialog to choose the wallpaper based on the comparement[4].

kind regards, Philip

[1] https://github.com/GNOME/gtk/raw/gtk-2-24/NEWS
[2] https://bugzilla.gnome.org/show_bug.cgi?id=769445
[3] https://git.gnome.org/browse/gtk%2B/commit/?id=5c03d6a9437d92acf89d43109e82e628ef822251
[4] https://github.com/GNOME/gtk/compare/2.24.30...2.24.31
Comment 1 Philip Müller 2016-09-10 15:40:14 CEST
After a short discussion with Eric we found a working patch for this matter: https://git.xfce.org/users/eric/xfdesktop/commit/?h=the-long-road-to-gtk3&id=cc311b61b82b7510a3a6cb0952d3a331e3551e05
Comment 2 Eric Koegel editbugs 2016-09-18 09:28:14 CEST
Thanks for pointing the issue out! Pushed to master in:
commit 726b34c0b37e778a4983866602cc20cfa4172b99
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Mon Jun 13 15:08:11 2016 +0300

    Settings: Allow directories to be selected (Bug #12832)
    
    Gtk 2.24.31 imported some Gtk3 code that breaks directory
    selection when using a file filter while in directory mode.
    We need to add directories to the filter for the
    GtkFileChooser, otherwise you can't select directories
    while in directory mode...
    Cherry-picked from:
    https://git.xfce.org/users/eric/xfdesktop/commit/?h=the-long-road-to-gtk3&id=cc311b61b82b7510a3a6cb0952d3a331e3551e05

https://git.xfce.org/xfce/xfdesktop/commit/?id=726b34c0b37e778a4983866602cc20cfa4172b99

We need to do another point release. Hopefully I'll get to that soon.
Comment 3 poma 2016-09-18 16:17:11 CEST
Fix for gtk_micro_version breakage - GTK+ 2,
also for all Fedora, 23-26.


Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.

Albert Einstein


Only(?) three things are infinite, the universe, human stupidity and GTK+ breakage, and I'm not sure about the 1st, but I'm sure for a 3rd.

poma
Comment 4 Skunnyk editbugs 2017-06-02 22:09:16 CEST
*** Bug 12969 has been marked as a duplicate of this bug. ***
Comment 5 Skunnyk editbugs 2017-06-21 12:53:53 CEST
*** Bug 13671 has been marked as a duplicate of this bug. ***
Comment 6 Git Bot editbugs 2017-06-21 13:42:46 CEST
Eric Koegel referenced this bugreport in commit 157f5b55cfc3629d595ef38984278de5915aac27

Settings: Allow directories to be selected (Bug #12832)

https://git.xfce.org/xfce/xfdesktop/commit?id=157f5b55cfc3629d595ef38984278de5915aac27
Comment 7 Eric Koegel editbugs 2017-07-18 07:32:05 CEST
*** Bug 13554 has been marked as a duplicate of this bug. ***

Bug #12832

Reported by:
Philip Müller
Reported on: 2016-09-10
Last modified on: 2017-07-18
Duplicates (3):
  • 12969 broken wallpaper chose dialog
  • 13554 Cannot select wallpaper subfolder
  • 13671 xfdesktop-settings dose not allow to chose path/image

People

Assignee:
Eric Koegel
CC List:
5 users

Version

Version:
4.12.3

Attachments

Screenshot of grayed out folder selection (32.24 KB, image/jpeg)
2016-09-10 11:06 CEST , Philip Müller
no flags

Additional information