! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar confuses files
Status:
RESOLVED: FIXED

Comments

Description Stefan Wagner 2016-02-04 05:20:55 CET
Created attachment 6602 
inkonsistency between view and status bar

Working with Inkscape, I often export an image, which is saved as xy.svg as xy.png to the same directory. 

Viewing it in Thunar, the thumbnail preview (didn't test for other views) shows the files in some order (by age, descending) and I mark the first one, which is displayed as xy.svg. 

However the status bar shows xy.png. 

Opening the details box, it is xy.png too. 

Doing something with the file, i.e. opening it with inkscape, which handles both formats opens the .png-file. 

Hitting the 'refresh' icon doesn't change the view, but leaving the directory and entering it again solves the problem.

I marked this as a major issue, since you can delete serious amounts of work by accident that way. 

I add two screenshots as attachments, if that works. :) 

Ah, I see, only one attachment possible.
Comment 1 Stefan Wagner 2016-02-04 05:24:50 CET
Created attachment 6603 
Inconsistency thumbnail view and details box
Comment 2 Vladimir 2016-12-15 20:30:22 CET
I can confirm this strange behaviour of Thunar during last several months. However, I would like to add my small observation. On my system Thunar does not confuse the files with similar name only -- it confuses arbitrary files with each other. It happens every time when a file is added to the folder or rewritten by some application.
Comment 3 alexxcons editbugs 2018-01-24 16:31:23 CET
*** Bug 13440 has been marked as a duplicate of this bug. ***
Comment 4 Stefan Wagner 2018-01-25 07:09:25 CET
The bug is reported at launchpad/ubuntu too: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1300398/comments/13 - I don't know if this is interesting to someone.
Comment 5 alexxcons editbugs 2018-03-22 22:03:30 CET
Possibly same bug is described in Bug 14288 and Bug 14173
Comment 6 alexxcons editbugs 2018-03-26 23:26:23 CEST
Created attachment 7648 
patch fixing the problem

On the first glance it looks like the order was just wrong ( first trigger redraw on view and after that tell the new order to the view )

As well strange that redraw was triggered for all files, not only for files which changed. I need to do some more investigation before applying this patch to prevent possible side-effects.
Comment 7 alexxcons editbugs 2018-03-26 23:29:07 CEST
*** Bug 14173 has been marked as a duplicate of this bug. ***
Comment 8 alexxcons editbugs 2018-03-26 23:29:42 CEST
*** Bug 14288 has been marked as a duplicate of this bug. ***
Comment 9 alexxcons editbugs 2018-03-26 23:31:17 CEST
For the record: The duplicates Bug 14173 and Bug 14288 both provide nice testcases to reproduce the bug
Comment 10 alexxcons editbugs 2018-03-26 23:49:28 CEST
Another possible duplicate: Bug 13786
Comment 11 alexxcons editbugs 2018-03-26 23:55:25 CEST
*** Bug 13627 has been marked as a duplicate of this bug. ***
Comment 12 alexxcons editbugs 2018-03-26 23:57:34 CEST
*** Bug 13399 has been marked as a duplicate of this bug. ***
Comment 13 alexxcons editbugs 2018-03-27 20:54:44 CEST
Looks like bug was introduced by this optimization: https://git.xfce.org/xfce/thunar/commit/?id=4569ffdb7e8bb441c9485db58aece581444487be
... did some test with the patch. So far it seems to work fine.
Comment 14 Git Bot editbugs 2018-03-28 23:45:59 CEST
Alexander Schwinn referenced this bugreport in commit 7e4f4a0c0be5ac0c503ca4aedf8aee8676006177

Thunar confuses files (bug #12435)

https://git.xfce.org/xfce/thunar/commit?id=7e4f4a0c0be5ac0c503ca4aedf8aee8676006177
Comment 15 Git Bot editbugs 2018-03-29 00:09:12 CEST
Alexander Schwinn referenced this bugreport in commit d86b704fec69b79aebf6521f4591aea6b8c6d9f3

Thunar confuses files (bug #12435)

https://git.xfce.org/xfce/thunar/commit?id=d86b704fec69b79aebf6521f4591aea6b8c6d9f3
Comment 16 alexxcons editbugs 2018-03-29 00:15:09 CEST
Fixed with slight modification to prevent another glitch  (thanks Andreldm !)

Will be released in the next days within
thunar 1.6.15
and within
thunar 1.7.2 (dev release, rc for 1.8.0)
Comment 17 Stefan Wagner 2018-03-30 02:43:59 CEST
Great to hear! Thanks, guys!
Comment 18 newhoa 2018-03-31 11:33:40 CEST
Awesome, thanks so much! This has been confusing me for some time! I just built the master and tried it out -- works great now!

I did have a question about the test files in bug#14288 though. The files included symbolic links.

When you change a source file that has a symlink pointing to it, the preview and sort order of the changed source file updates. But the preview and sort order of the symlink does not. A reload fixes this, but shouldn't the symlink update also?

When you right click to rename or go to delete a file based on the icon preview it could become a bit confusing since the preview in the "rename" dialogue is still the old preview. Still nowhere near as dangerous as the previous behavior though. But the preview is wrong, and the sort order is then not true Sort by Modify Date until you reload.

Also to note, when I open a symlink and change the file, the source file preview is updated and sorted, but the symlink I clicked on appears unchanged in both preview and sort order.

Anyway, just curious about the way symlinks update. This is a great fix. Thanks again so much!
Comment 19 alexxcons editbugs 2018-03-31 21:30:34 CEST
You are welcome !

I agree that it would be nice to update the sort order and the thumbnails for symlinks ... though I think it would require quite some work.
Could you please open a new bug for it ?
Comment 20 alexxcons editbugs 2018-04-08 21:18:21 CEST
*** Bug 13786 has been marked as a duplicate of this bug. ***

Bug #12435

Reported by:
Stefan Wagner
Reported on: 2016-02-04
Last modified on: 2018-08-07
Duplicates (6):
  • 13399 icons don't update according to sort by modification date
  • 13440 Thunar confuses files. I select a file and it is not really what it should be.
  • 13627 wrong file ordering after edits create inconsistencies
  • 13786 Thunar crashes with libgobject error 4 when deleting many image files.
  • 14173 Thunar Crashed with segfault when deleting file from terminal
  • 14288 Thunar Sort by Modification Date displays modified files incorrectly

People

Assignee:
alexxcons
CC List:
12 users

Version

Version:
1.6.10

Attachments

inkonsistency between view and status bar (52.35 KB, image/png)
2016-02-04 05:20 CET , Stefan Wagner
no flags
Inconsistency thumbnail view and details box (60.34 KB, image/png)
2016-02-04 05:24 CET , Stefan Wagner
no flags
patch fixing the problem (1.72 KB, patch)
2018-03-26 23:26 CEST , alexxcons
no flags

Additional information