! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar Crashed with segfault when deleting file from terminal
Status:
RESOLVED: DUPLICATE

Comments

Description Jakub Jankiewicz 2018-01-19 20:53:44 CET
So I have this directory listing:

$ ls
 8864753032_e9788b8417_o.jpg   jakub-jankiewicz-cv-page1.pdf
 cv2.pdf                       jakub-jankiewicz-cv-page2.pdf
 cv2.svg                       jakub-jankiewicz-cv-page2.svg
 cv3.svg                       Jakub_Jankiewicz_CV.pdf
 cv4.svg                       jakub-jankiewicz-cv-resume-design-eng.png
 cv5_eng.svg                   jakub_jankiewicz_cv_resume_design.pdf
 cv5.svg                      '~~jakub-jankiewicz-cv-resume-design.png'
 cv.abw                        jakub-jankiewicz-cv-resume-design.png
 CV-goldenline.pdf             jakub_jankiewicz_cv_resume_design.svg
 cv.pdf                        jakub-jankiewicz-cv.svg
 CV_proste.svg                 jakub-jankiewicz.pdf
 cv_resume.svg                 List_Motywacyjny.pdf
 cv.svg                        List_Motywacyjny.svg
 cv.txt                        logo.svg
 Jakub_Jankiewicz_CV.doc       zdjecie.jpg
 Jakub_Jankiewicz_cv_eng.pdf

and I have open that directory in Thunar and one file jakub-jankiewicz-cv-page2.svg in Inkscape

I've saved as new pdf file that overwrite existing file jakub-jankiewicz-cv-page2.pdf and in terminal I've called this:

$ rm jakub-jankiewicz-cv.pdf
$ pdfmerge jakub-jankiewicz-cv-page{1,2}.pdf jakub-jankiewicz-cv.pdf

As soon as I've called rm (different file that saved in Inkscape) Thunar crashed (happen 2 or 3 times) with this in `dmesg`:

[1057816.448009] Thunar[9413]: segfault at 48 ip 0000560af95b7540 sp 00007fffe38b8b18 error 4 in thunar[560af957e000+b5000]
[1057973.358543] Thunar[2772]: segfault at 48 ip 000055d26bdd0540 sp 00007ffda7cbd9a8 error 4 in thunar[55d26bd97000+b5000]
[1058217.083488] Thunar[2974]: segfault at 1300002800 ip 00007fb39576f927 sp 00007ffd8d407c58 error 4 in libgobject-2.0.so.0.5200.3[7fb39573b000+51000]

version:
$ Thunar --version
Thunar 1.6.13 (Xfce 4.12)

OS:
Fedora 26

I can compile Thunar from git and see if this still happen in this version. Don't know if this is related to #6222
Comment 1 alexxcons editbugs 2018-01-22 09:59:55 CET
I cannot reproduce that for thunar-master.
Following steps done ( tried some variations):
1. Open folder in thunar
2. Open folder in terminal
3. Generate some pdf with e.g. gimp ( file.pdf )
4. Open inkscape --> save as --> select pdf --> overwrite file.pdf 
5. In terminal: rm file.pdf

Does the bug trigger for you with the exact steps I took ?  Or is the pdfmerge somehow required ? ( Since you wrote thunar crashed already on "rm" )

> I can compile Thunar from git and see if this still happen in this version.
This would be great !
Comment 2 alexxcons editbugs 2018-01-22 10:07:57 CET
Err ... ok, I have to delete a different file, but still cannot reproduce:
1. Open folder in thunar
2. Open folder in terminal
3. Generate 2 pdf with e.g. gimp ( file1.pdf and file2.pdf ) and close gimp
4. Open inkscape --> save as --> select pdf --> overwrite file2.pdf 
5. In terminal: rm file1.pdf

Does the bug trigger for you with these steps ?
Comment 3 Andre Miranda editbugs 2018-01-23 01:33:18 CET
It would help a lot if you (Jakub) could attach a zip with files the cause the crash, of course only if the files do not contain any sensitive info.
Comment 4 Jakub Jankiewicz 2018-01-23 08:54:03 CET
Found more info, you need to sort directory by time and both files need to be at the end so you first need to generate the file that you need to delete and then save as pdf from inkscape.
Steps:

create file-delete.pdf
save-as file.pdf
delete file-deleted.pdf from terminal (the file-delete.pdf need to be generated before you save as pdf)
Comment 5 Jakub Jankiewicz 2018-01-23 09:02:33 CET
Created attachment 7556 
Directory listing

Directory listing that make Thunar crash.

1. Open directory in Thunar
2. Sort by time
3. in terminal run make
4. open jakub-jankiewicz-cv.svg in Inkscape
5. save as jakub-jankiewicz-cv-page1.pdf
6. run rm jakub-jankiewicz-cv-full.pdf or make
Comment 6 alexxcons editbugs 2018-01-23 23:04:31 CET
Still no success .. however I had to do some modification to the makefile to get it to run for me, since I have no glue from where to get "pdfmerge". I have "pdfunite" which I quess does the same and comes with the package "poppler-utils".
Could you take a try if this modification matters ? ... attached the modified makefile

1. Open directory in Thunar
2. Sort by time
3. in terminal run make  ( use right-click - open terminal here ? )  ( First delete jakub-jankiewicz-cv-full.pdf so that makefile does something ? )
4. open jakub-jankiewicz-cv.svg in Inkscape
5. save as jakub-jankiewicz-cv-page1.pdf
6. run rm jakub-jankiewicz-cv-full.pdf or make
Comment 7 alexxcons editbugs 2018-01-23 23:05:16 CET
Created attachment 7560 
modified makefile (pdfunite)
Comment 8 Andre Miranda editbugs 2018-01-24 02:57:47 CET
I'm using Alex's Makefile due pdfunite and the following commands:

touch *.pdf && sleep 1 && make && sleep 1 && rm *full.pdf

I can't reproduce with neither Thunar from master nor 1.6.13. I'm using the Detailed List view sorted by ascending Date Modified (i.e. jakub-jankiewicz-cv-full.pdf is the last file).
Can you reproduce with those commands?
Comment 9 Jakub Jankiewicz 2018-01-24 09:15:30 CET
The touch is working maybe it's related to Inkscape that do something unexpected. See https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1300398


I've tried to test on 1.17 and build from source but I can't find exo-2 on Fedora only exo is is there and I've installed devel 64bit version.
Comment 10 alexxcons editbugs 2018-01-24 17:14:06 CET
I am afraid you as well will need to build exo from source (same for debian) and install it.

Did you manage to reproduce the bug with pdfunite instead of pdfmerge ? Can it be replaced by something more simple, like "cp" for reproduce ?
Comment 11 Jakub Jankiewicz 2018-01-24 18:18:51 CET
I've replaced pdfmerge with cp + touch and it also crash.

New info for directory to crash it need to be opened from places applet for xfce panel. Because I've called:

Thunar . &
make

and it didn't crashed.

And it seems that it crash only for those windows that was open from same window that was "linked" to the one opened from click in places, because I now have one directory after crash (but I've got crash report  link in notification abot crash of Thunar).

Maybe places create new Thunar process that's somehow different.

And I've notice one more thing I had 2 directories open and it didn't crashed but when I closed them and open from places it crashed. And I had one crash when I was saving in Inkscape before rm.
Comment 12 alexxcons editbugs 2018-01-24 21:43:57 CET
Created attachment 7562 
places applet ?

This is the "Places applet" ?  Or is it something else ?
Comment 13 alexxcons editbugs 2018-01-24 21:44:16 CET
ummm .. this is getting a bit confused..
Maybe you can provide a detailed list of steps what exactly to do now ? ( simplest possible case to provoke crash )
Comment 14 Jakub Jankiewicz 2018-01-24 22:42:00 CET
My laptop break, it wont turn on, so I'm using right now old Xubuntu 17.04 with my old laptop, but the issue is the same.  Only the time before Thunar crash is longer. It freezes for few seconds and the crash.

Steps to reproduce:

1. Extract files from provided tar ball into test directory.
2. You need to have Places applet (I have translated to pl as Miejsca) included in xfce panel
3. Open any directory (may be home) from Places applet and navigate to test directory 
4. Set sorting by time
5. In terminal open test directory
6. execute cp jakub-jankiewicz-cv-full.pdf copy.pdf (so you will be able copy it back in last step)
7. Open in Inkscape jakub-jankiewicz-cv.svg
8. Save as pdf jakub-jankiewicz-cv-page1.pdf
9. In terminal execute:

test -e jakub-jankiewicz-cv-full.pdf && rm jakub-jankiewicz-cv-full.pdf
cp copy.pdf jakub-jankiewicz-cv-full.pdf
touch jakub-jankiewicz-cv-full.pdf

cp and touch is only needed if you want to repeat it again, so you can remove the file after you save that other file from inkscape.

The problem is that when you save from inkscape the files are swapped if you click on  *full.pdf it show page1.pdf in status bar at the bottom.
Comment 15 alexxcons editbugs 2018-01-24 23:48:03 CET
Still cannot reproduce :F ... getting a bit out of ideas
Comment 16 Andre Miranda editbugs 2018-01-25 01:47:46 CET
Alex, he means this panel plugin:
https://git.xfce.org/panel-plugins/xfce4-places-plugin

After half an hour, following your instructions to the letter and trying other crazy stuff, no crash at all.
I even switched back to Thunar 1.6.13 to no avail.

I really appreciate your time and effort to report bugs, if it's not asking too much, could you record a small video of your steps, perhaps we're missing one little important detail. Just one more question, is this 100% reproducible? I mean, it happens every time or once in a couple?
Comment 17 Jakub Jankiewicz 2018-01-25 08:51:53 CET
It happen every time, will try to create video later today.
Comment 18 Jakub Jankiewicz 2018-01-27 16:16:44 CET
Sorry about the delay, I've created a video that demonstrate the issue http://jcubic.pl/Thunar-crash.ogv .

I've forget about one step. Before you save from Inkscape, you need to touch the full.pdf file, so it will show last.

In video after save from inkscape the status bar for files show wrong files.
Comment 19 alexxcons editbugs 2018-01-27 16:44:01 CET
Gna, for unknown reason I cannot add the xfce4-places-plugin to my panel.

Installed it via apt-get, but it does not show if I select "add new element ...".

Looks like I first need to investigate this before I can try another attempt to reproduce. O_o
Comment 20 Andre Miranda editbugs 2018-02-12 20:53:09 CET
Created attachment 7592 
test.tar.gz

Thanks Jakub for the video, now I can reproduce the bug!
Alex, you won't need xfce4-places-plugin, just grab the attached tar and run test.sh, pay attention to the instructions it outputs.
Also notice that this bug doesn't occur with Detailed List, you need to use either Icons or Compact List and make sure it's using this sorting: View -> Arrange Items -> Sort By Modification Date (Ascending).

The top of backtrace is:

#0  0x00005555555b8f5a in thunar_list_model_get_value (model=0x555555a960c0, iter=<optimized out>, column=<optimized out>, value=0x7fffffffc6c0) at thunar-list-model.c:683
#1  0x00007ffff79ab4de in exo_icon_view_set_cell_data (icon_view=icon_view@entry=0x555555e2e330, item=item@entry=0x555555bdd1e0) at exo-icon-view.c:5390
#2  0x00007ffff79aeb84 in exo_icon_view_paint_item (icon_view=icon_view@entry=0x555555e2e330, item=item@entry=0x555555bdd1e0, cr=cr@entry=0x555555cf2000, x=155, y=7, draw_focus=1) at exo-icon-view.c:4115
#3  0x00007ffff79b6e25 in exo_icon_view_draw (widget=0x555555e2e330, cr=0x555555cf2000) at exo-icon-view.c:2039
#4  0x00007ffff69bbc00 in  () at /usr/lib/libgtk-3.so.0
#5  0x00007ffff678fb2f in gtk_container_propagate_draw () at /usr/lib/libgtk-3.so.0
#6  0x00007ffff678fc13 in  () at /usr/lib/libgtk-3.so.0
#7  0x00007ffff68ea53e in  () at /usr/lib/libgtk-3.so.0
#8  0x00007ffff6794e4d in  () at /usr/lib/libgtk-3.so.0
#9  0x00007ffff6799c58 in  () at /usr/lib/libgtk-3.so.0
#10 0x00007ffff68e8782 in  () at /usr/lib/libgtk-3.so.0
#11 0x00005555555ea38c in thunar_standard_view_draw (widget=0x555555dc7eb0, cr=0x555555cf2000) at thunar-standard-view.c:1114

The offending line (thunar-list-model.c:683) contains _thunar_assert (THUNAR_IS_FILE (file)); So it suggests that the swapped files in status bar is very likely related. It makes no difference if you refresh the view before removing the pdf file. Needs more investigation...
Comment 21 Andre Miranda editbugs 2018-02-12 21:01:22 CET
Created attachment 7593 
test.tar.gz

Even simpler reproducer, no need to open inkscape.
Comment 22 alexxcons editbugs 2018-02-13 19:49:41 CET
Thanks, nice! Now I as well can reproduce.
Comment 23 alexxcons editbugs 2018-03-22 22:04:00 CET
Possibly same bug than described in Bug 12435 and Bug 14288
Comment 24 alexxcons editbugs 2018-03-26 23:29:07 CEST
Found a fix \o/  ... and found out that this bug definitively is a duplicate of 12435
I added a patch there.

*** This bug has been marked as a duplicate of bug 12435 ***

Bug #14173

Reported by:
Jakub Jankiewicz
Reported on: 2018-01-19
Last modified on: 2018-03-26

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
1.6.13

Attachments

Directory listing (97.49 KB, application/gzip)
2018-01-23 09:02 CET , Jakub Jankiewicz
no flags
modified makefile (pdfunite) (306 bytes, application/octet-stream)
2018-01-23 23:05 CET , alexxcons
no flags
places applet ? (27.55 KB, image/png)
2018-01-24 21:43 CET , alexxcons
no flags
test.tar.gz (4.60 KB, application/gzip)
2018-02-12 20:53 CET , Andre Miranda
no flags
test.tar.gz (4.56 KB, application/gzip)
2018-02-12 21:01 CET , Andre Miranda
no flags

Additional information