This service is used by Firefox's "Open Containing Folder" for downloaded files, and also by Eclipse. Currently with Firefox, Thunar opens the directory without selecting the file since xdg-open is used instead of the dbus service. Not having this services is also causing weird issues for users that also have Nautilus installed. See https://bugzilla.mozilla.org/show_bug.cgi?id=1106916. The details for the specification is here: http://www.freedesktop.org/wiki/Specifications/file-manager-interface/ I think these overlap nicely with org.xfce.FileManager, so they shouldn't be hard to do. It would be really nice to get support for this. The service is currently supported by Nautilus and Dolphin.
Hi, https://github.com/dirk-olmes/dbus-file-manager Not ideal, but I'm out of a hurry .. ;)
*** Bug 13406 has been marked as a duplicate of this bug. ***
*** Bug 15003 has been marked as a duplicate of this bug. ***
Created attachment 8221 wip patch WIP implementation of org.freedesktop.FileManager1
Created attachment 8233 filemanager1.patch Complete patch, soon to be merged and released in 1.8.3, but I'm posting it here for testers/reviewers.
Created attachment 8239 Updated patch Updated patch, better handling for malformed URIs.
Andre Miranda referenced this bugreport in commit ec15879865962489c29043c7e4908d500e4220d9 Add support for org.freedesktop.FileManager1 (Bug #12414) https://git.xfce.org/xfce/thunar/commit?id=ec15879865962489c29043c7e4908d500e4220d9
Andre Miranda referenced this bugreport in commit c06074065460e63cf78ef1c5b7eb819fa6a86430 Add support for org.freedesktop.FileManager1 (Bug #12414) https://git.xfce.org/xfce/thunar/commit?id=c06074065460e63cf78ef1c5b7eb819fa6a86430
*** Bug 11024 has been marked as a duplicate of this bug. ***
The newly added service file conflicts with the one shipped by Nautilus. To be exact: > thunar: /usr/share/dbus-1/services/org.freedesktop.FileManager1.service exists in filesystem (owned by nautilus) How should this be handled by Linux distros (with no Debian-like alternatives system)?
(In reply to Git Bot from comment #8) > Andre Miranda referenced this bugreport in commit > c06074065460e63cf78ef1c5b7eb819fa6a86430 > > Add support for org.freedesktop.FileManager1 (Bug #12414) > > https://git.xfce.org/xfce/thunar/ > commit?id=c06074065460e63cf78ef1c5b7eb819fa6a86430 while installing nautilus and thunar, there is a conflict of /usr/share/dbus-1/services/org.freedesktop.File Manager 1.service
One possibility would be to add "Thunar"/"Nautilus" to the name of the file ... but that seems to be no good solution, and is not recommended by freedesktop either: From https://dbus.freedesktop.org/doc/dbus-daemon.1.html > If a particular service is found in more than one <servicedir>, the first directory listed in the configuration file takes precedence. > If two service files providing the same well-known bus name are found in the same directory, it is arbitrary which one will be chosen > (this can only happen if at least one of the service files does not have the recommended name, which is its well-known bus name > followed by ".service"). So in this case, it would be arbitrary which filemanager is called .. not very nice. What about just overwriting the file and dont remove it after package uninstall ( ok, this is bad if the filemanager got uninstalled ) Or the other way around : Dont overwrite, remove on package uninstall ( could lead to the question "why is this filemanager used, and not that?" ) The cleanest solution comming to my mind would be, to provide one dbus-1 <servicedir> per filemanager(package) installation. So the first directory listed in the configuration file would win. I am not a packager .. this dbus problem smells like it already must have been solved in some way. Thunar probably is not the first package which provides some dbus service which is provided by multiple packages. How it is done for other dbus services which are provided by multiple packages ?
(In reply to alexxcons from comment #12) > One possibility would be to add "Thunar"/"Nautilus" to the name of the file > ... but that seems to be no good solution, and is not recommended by > freedesktop either: > > From https://dbus.freedesktop.org/doc/dbus-daemon.1.html > > > If a particular service is found in more than one <servicedir>, the first directory listed in the configuration file takes precedence. > > If two service files providing the same well-known bus name are found in the same directory, it is arbitrary which one will be chosen > > (this can only happen if at least one of the service files does not have the recommended name, which is its well-known bus name > > followed by ".service"). > > So in this case, it would be arbitrary which filemanager is called .. not > very nice. > > > What about just overwriting the file and dont remove it after package > uninstall ( ok, this is bad if the filemanager got uninstalled ) > > Or the other way around : Dont overwrite, remove on package uninstall ( > could lead to the question "why is this filemanager used, and not that?" ) > > The cleanest solution comming to my mind would be, to provide one dbus-1 > <servicedir> per filemanager(package) installation. So the first directory > listed in the configuration file would win. > > I am not a packager .. this dbus problem smells like it already must have > been solved in some way. Thunar probably is not the first package which > provides some dbus service which is provided by multiple packages. How it is > done for other dbus services which are provided by multiple packages ? Dolphin uses /usr/share/dbus-1/services / org.kde.dolphin.File Manager 1.service
IMO not an optimal solution. So it will be random which FileManager will be picked. But at least it would solve your conflict ... will do some testing and see if I can provide a patch this or next evening. Did you as well open a bug for Nautilus ?
(In reply to alexxcons from comment #14) > IMO not an optimal solution. So it will be random which FileManager will be > picked. > But at least it would solve your conflict ... will do some testing and see > if I can provide a patch this or next evening. > > Did you as well open a bug for Nautilus ? No, I didn't open anything.....only here wrote
Created attachment 8264 rename service file Attached a patch to rename the service file accordingly to org.xfce.Thunar.FileManager1.service
(In reply to alexxcons from comment #16) > Created attachment 8264 > rename service file > > Attached a patch to rename the service file accordingly to > org.xfce.Thunar.FileManager1.service build the package with this patch drops make[2]: *** No rule to make target 'org.freedesktop.FileManager1.service.in', needed by 'org.freedesktop.FileManager1.service'. Stop. make[2]: *** Waiting for unfinished jobs.... GEN org.xfce.FileManager.service GEN org.xfce.Thunar.service
I've opened a bug on Debian BTS against Nautilus. We'll definitely have issues there (even with a renaming): https://bugs.debian.org/920460 Apparently Nautilus doesn't automatically start on GNOME session, it's DBus activated so they'll definitely have the issue. In Xfce I think Thunar should be started by default and take ownership of the DBus name.
@vladimir Cannot reproduce. Just checked: The string "org.freedesktop.FileManager1.service" is not found in the sources after patching. Possible you just need to run ./autogen.sh again or "make clean" before make. The following build from scratch works fine for me: git clone --branch thunar-1.8.3 https://git.xfce.org/xfce/thunar cd thunar curl https://bugzilla.xfce.org/attachment.cgi?id=8264 | git apply ./autogen.sh make @ Yves-Alexis Perez Thanks for the bug ! Curious to where it will lead ;)
Alexander Schwinn referenced this bugreport in commit 250ceaa18561fe25046176a33617c85ec0700b3c renamed org.freedesktop.FileManager1.service.in to org.xfce.Thunar.FileManager1.service.in to avoid name clashes (Bug #12414) https://git.xfce.org/xfce/thunar/commit?id=250ceaa18561fe25046176a33617c85ec0700b3c
Alexander Schwinn referenced this bugreport in commit f0c0ab425b9825c975c9de0db94c179395835b28 renamed org.freedesktop.FileManager1.service.in to org.xfce.Thunar.FileManager1.service.in to avoid name clashes (Bug #12414) https://git.xfce.org/xfce/thunar/commit?id=f0c0ab425b9825c975c9de0db94c179395835b28
Just did a "emergency" release of 1.8.4 with renamed .service file and a bugfix .. majorly because of Bug #15088 (sorry for all that confusion)