! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Maximize window when dragged to top of screen
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Jarrett Chisholm 2013-03-17 15:39:04 CET
Hey all

I know there is supposed to be a tiler that will make the window 1/2 of the screen (when dragged to the top).  I think it's in 4.10.  I would like to suggest that we, instead, maximize the window when dragged to top of the screen by default.

I'm not sure of other users' experiences, but using other WMs, I found this to be a very useful feature.

Any thoughts?
Comment 1 Diego 2013-03-25 22:02:47 CET
I think that proposed behavior is the proper way. It's very frustrating to see start the horizontal tiling on the drag up the window
Comment 2 Vincenzo Salmena 2013-03-25 22:28:09 CET
I totally agree with this proposal.
Maybe this can be improved by adding a little tool to let the user customize easily this behaviour.
Comment 3 Edoardo Maria Elidoro 2013-03-26 08:22:12 CET
(In reply to comment #2)
> Maybe this can be improved by adding a little tool to let the user customize
> easily this behaviour.

It would be nice indeed, but even a simple change to maximize the window would be fine.
Comment 4 Ross Cooper 2013-05-21 05:53:15 CEST
+1. I would love a option to change this behavior somewhere in 'Settings Manager->Window Manager Tweaks->Accessibility' or elsewhere.

Changing the default behavior is a different discussion altogether. Personally, I see the current behavior (tile on top half) as somewhat inconsistent, as we are not able to tile windows by dragging them to the bottom of the screen . If both the top and bottom edges tiled windows to 1/2 of the screen accordingly, the current behavior would make sense. As it stands, though, the top half of the screen is a unique edge, so in my opinion it should do something unique. 

An option is absolutely needed, regardless.
Comment 5 Ross Cooper 2013-05-21 08:13:54 CEST
(In reply to comment #4)
> Changing the default behavior is a different discussion altogether.
> Personally, I see the current behavior (tile on top half) as somewhat
> inconsistent, as we are not able to tile windows by dragging them to the
> bottom of the screen . If both the top and bottom edges tiled windows to 1/2
> of the screen accordingly, the current behavior would make sense. As it
> stands, though, the top half of the screen is a unique edge, so in my
> opinion it should do something unique. 

Disregard this, apparently the bottom does tile a window on the bottom half of the screen. It didn't when I tested it while writing this up, must've been a fixed window or something.
Comment 6 Cédric Leporcq 2014-06-04 15:12:31 CEST
It is a duplicate to this  enhancement:
https://bugzilla.xfce.org/show_bug.cgi?id=8380

I proposed a patch for this feature here:
https://bugzilla.xfce.org/show_bug.cgi?id=9611
Comment 7 Andre Miranda editbugs 2014-08-21 01:29:16 CEST
I do believe that the current behavior is not the most desirable by the majority of the users(IMHO). People that come from others VMs(or even Windows) are used to maximize the window by dragging it to top edge, so XFCE is the awkward one by splitting the window. Maybe a key modifier(Alt or Shift) could be used here to switch between the current and proposed behavior.

@Cédric: I don't think this is bug is related to 8380 or 9611, as in this case, the window is not maximized and we want to maximize it by just dragging to the top edge. I might be mistaken, but your patch doesn't seem to accomplish this.

What does work is the proposed hack here: https://forum.xfce.org/viewtopic.php?pid=32441#p32441

The only problem is if you drag the window to the top and then drag to any other edge, it won't resize anymore, you must drop release the window and drag again. I didn't test, maybe Cédric's patch helps here.
Comment 8 Andre Miranda editbugs 2014-08-22 01:10:54 CEST
s/VMs/DEs
Comment 9 Cédric Leporcq 2014-08-24 15:50:39 CEST
@André: maybe some explanations are needed. To implement this feature we need to fix #9611 bug first for consistancy.

my patch consisting of two commits:
-[PATCH 1/2] Make tile on move working for maximized windows
This should fix tiling for maximized windows

-[PATCH 2/2] Add maximize on move option.
This commit implement the feature you want with an option.

If such option is active : the windows will be maximazed when dragging to the top screen edge, horizontal tilling will be disabled.

It work for me, you can try it to test it.

link to the patch:
https://bugzilla.xfce.org/show_bug.cgi?id=9611
Comment 10 Andre Miranda editbugs 2014-08-28 01:40:50 CEST
Created attachment 5616 
maximize hack

@Cédric: I've applied the patch from bug 9611, seems to work nicely, but I can't review the code to say if it's right or not. I have also added the hack from the forum but it didn't work well with your patch, however the attached patch seems to be suffice to fix.

Regarding the key modifiers, it's a matter of taste. IMHO the proposed behavior is more consistent and should be default without an alternative to the current behavior.
Comment 11 exebetche 2014-09-09 17:46:26 CEST
I agree as well, beside the argument that it is the behaviour on most sytem it's not fit for a common usage: when you start draging a window in most cases, it's either to put it in front to work with it full size or to put it in the backgroung to work with an other one. So the default behaviour should be IMHO:
- maximise the windows when they touch the top of the screen so you can work in it
- reduce the maximized windows to a predefined fixed size when you drag them down from the top of the screen so you can put it away and grab an other one on the background or click icons on your desktop
That would be a consistant behaviour and very convenient if you work with many windows, because it allow you to bring them in the background/foreground in just one mouvement with the mouse.
I can't see many example when you need to use two windows at the same timeand it might be usefull but anyway that should be an alternative behaviour not the default one.
Comment 12 Andre Miranda editbugs 2015-02-20 00:36:42 CET
I guess this has been fixed by now, can you guys confirm?
Note: I'm using xfwm4 from git.
Comment 13 Olivier Fourdan editbugs 2015-02-20 08:38:56 CET
Yes, this is now coupled with tiling, ie moving a window to the top border of the screen will maximize it if tiling on move is enabled.
Comment 14 Olivier Fourdan editbugs 2015-02-20 08:53:05 CET
*** Bug 8380 has been marked as a duplicate of this bug. ***
Comment 15 Woi 2015-10-21 19:30:05 CEST
Just updated from XFCE 4.10 to 4.12 (Fedora 21 to 22) and noticed that this bug fix changes a behaviour I was very used too. I started looking for a configuration option to get back the old behaviour, but couldn't find one.
I might have overlooked something, but if this patch really landed without an option to get back the old behaviour, I'd like to reopen this bug until such an configuration option is available for two reasons:
* It's not user friendly to change a default behaviour which some users need for there daily work. Doing so without an option to get back the old behaviour is affronting.
* The new behaviour is inconsistent and unintuitive, because windows are tilled if moved to any other edge or corner.

Also keep in mind that with the next Xubuntu LTS arriving in ~6 month, a hugh  user base will switch from XFCE 4.10 to 4.12 and might be surprised by this change.

Regards
Woi

Bug #9927

Reported by:
Jarrett Chisholm
Reported on: 2013-03-17
Last modified on: 2015-10-21
Duplicates (1):
  • 8380 Maximizing by dragging windows

People

Assignee:
Olivier Fourdan
CC List:
12 users

Version

Version:
unspecified

Attachments

maximize hack (504 bytes, patch)
2014-08-28 01:40 CEST , Andre Miranda
no flags

Additional information