Add the ability to undecorate maximized windows to save vertical space on screen.
Implemented here https://bitbucket.org/thesame/xfwm4-titleless
(In reply to comment #1)
> Implemented here https://bitbucket.org/thesame/xfwm4-titleless
Please attach patches here if you want this upstream (can't really teach changes from another git repo,not convenient...)
Note, title-less maximization is already covered by EWMH, so this needs to be implemented via the standard, making it an unconditional option in not the right way to add this feature.
1. add support for EWMH standard for borderless maximization
2. make sure it's not just the title, but border as we'll (ie there is already an option to show or hide borders on maximization, make sure this work in any case)
3. once the feature supports the standard, we can add a user option to set the default behaviour, for apps that don't specify their desired maximization mode via the standard.
Created attachment 4959
Adds ability to hide titles of maximized windows
(In reply to comment #3)
> Note, title-less maximization is already covered by EWMH, so this needs to
> be implemented via the standard, making it an unconditional option in not
> the right way to add this feature.
I couldn't find appropriate EWMH atom to show/hide titles of maximized windows. My solution isn't unconditional, it adds new checkbox (initially unchecked) to WM tweaks.
> 1. add support for EWMH standard for borderless maximization
> 2. make sure it's not just the title, but border as we'll (ie there is
> already an option to show or hide borders on maximization, make sure this
> work in any case)
My solution covers both full and vertical titleless maximizations. I'd be glad if someone tested it with me. It works for me and I already use it.
I have applied this to xfwm4 4.10.1 from debian/testing and it work like a charm.
Patch little bit messy, it would be better to split it into pieces.
(In reply to comment #5)
> I couldn't find appropriate EWMH atom to show/hide titles of maximized
> windows. My solution isn't unconditional, it adds new checkbox (initially
> unchecked) to WM tweaks.
True, indeed, I got confused.
But gtk+ has a mechanism for that: "_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED"
Would be great to have that as well, so that apps that use this get undecorated when maximized even if the user has not specified the option (so we geta consistent behavior with gtk+ apps at least)
Created attachment 5092
Diff against current git master. Must be applied on top of previous patch.
Nobody seems to care :(
I do care and I really like it! ;)
This should be merged upstream I think.
Hello, I've worked on this patch made by Viktor Semykin and I've made some improvements and fixes for xfwm4 4.10 and 4.11.
If you are interested it's available here: https://github.com/cedl38/xfwm4-titleless.
Created attachment 5245
add xfwm4 titleless option for maximized windows - 4.10.1
Comment on attachment 5245
add xfwm4 titleless option for maximized windows - 4.10.1
patch for xfwm4 version 4.10.1
Created attachment 5246
hide title and top border on maximized features - 4.10.1
Patch for xfwm4 version 4.10.1
Add titleless maximization feature and extra functionalities:
- Change top border creation for hiding capabilities (add frameTopBorder and frameTitle functions)
- Split title-*.xpm into title and top border part if top-3-active.xpm don't exist
- add optional top_border_height and top_border_maximize parameters.
Created attachment 5247
hide title and top border on maximized features - 4.11.0
Patch for xfwm4 version 4.11.0
Add titleless maximization feature and extra functionalities.
Created attachment 5292
Screenshot of misrendered decorations
Using the latest patch by Cédric Leporcq now. Works great on most system, though it interferes with bug 10049 . Uploading a screenshot of misrendered decorations, please compare with the upload from the other bug. Any ideas what could have caused this?
Can you please tell me witch theme are you using ? I’m wondering if this bug can be related to a specific theme.
My latest patch have made some changes regarding the theme implementation to allow top border hiding. Theses changes d’ont affect theme rendering for most of them. I noticed some glitch on few themes (like metabox) for very particular reason that can be easily fixed with theme updates.
(my latest revisions can be found here : https://github.com/cedl38/xfwm4-titleless)
this is a customized version of Curve, but plain Curve from xfwm4-themes suffers the same issue. Looks like this happens whenever just one visible pixel in a row...
I do see this in a virtualbox with guest additions installed. Bare metal with intel hardware in uneffected, so not sure if the is a xfwm4 or driver problem.
What did you change for Metabox? Perhaps that gives me any idea how to fix it.
Probably worst one is Cruxish... It misses the title entirly. title-3-(in)?active.xpm is just one pixel wide, so it fits my theory.
Created attachment 5296
I can’t reproduce yours bugs on my system. To test your theory you can change the pixmaps wide from 1 pixel to 3 for example with a text editor. This change does not affect the theme appearance.
For metabox there is a bug in the theme, but only visible with my patch.
To fix it change number 2 by 3 in title_5_active_xpm with a text editor:
"8 21 2 1",
" c None",
". c #000000",
"+ c #5B80AD s active_color_1",
"8 21 2 1", should be "8 21 3 1", because there are three colors in this pixmap
I think my xpm images are ok.
Looks like this only happens when X.org VESA driver is in action (which is also true for virtualbox guests whith vboxvideo). So possibly we do not have a xfwm4 bug but a X.org driver one.
*** Bug 7436 has been marked as a duplicate of this bug. ***
Implemented with commit 2c77f62