! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
quicklauncher.desktop needs update for xfce4-panel 4.7
Status:
RESOLVED: FIXED
Product:
Xfce4-quicklauncher-plugin
Component:
General

Comments

Description Christoph Wickert editbugs 2010-12-19 21:45:56 CET
Created attachment 3291 
patch for xfce4-panel >= 4.7

quicklauncher.desktop needs an update for xfce4-panel >= 4.7:
- Syntax has changed again
- Location changed from $(libdir)/xfce4/panel-plugins to $(libdir)/xfce4/panel/plugins
- gnome-fs-executable is application-x-executable in the latest freedesktop icon naming spec.

BTW: Location of the desktop files has changed too, from $(datadir)/xfce4/panel-plugins to $(datadir)/xfce4/panel/plugins. This is not yet included in the patch because it happened just a few minutes ago. See bug 7013 for more info.
Comment 1 Mike Massonnet editbugs 2011-11-04 19:17:28 CET
Comment on attachment 3291 
patch for xfce4-panel >= 4.7

desktop.in.in file has to be renamed to desktop.in and the sed command in Makefile.am dropped.
Comment 2 Landry Breuil editbugs 2014-11-23 21:42:55 CET
Mass-reassign all bugs from florian@ to goodies-dev@, thanks for the maintenance work! (and sorry for the bugmail spam..)
Comment 3 Steve Dodier-Lazaro editbugs 2015-02-16 21:00:41 CET
This patch has not been applied yet, and Mike's comments indicate that more work is needed. Could someone please propose a new patch?
Comment 4 Robby Workman editbugs 2015-02-18 00:01:24 CET
Created attachment 5960 
Fix bz7015

I also removed the Depreated Encoding key...
Comment 5 Landry Breuil editbugs 2015-02-18 20:55:19 CET
Main problem with smartbookmark (besides being unmaintained) is that it still uses xfcegui4..

I started porting it to xfce4ui and doing more or less the same as your patch, but porting to xfce4ui proved to be too much.

As for your patch, it still builds the plugin as a binary instead of a module like all others do.. Willing to also tackle that issue while here ? That part isnt really hard.
Comment 6 Landry Breuil editbugs 2015-02-18 22:04:22 CET
Anyway, applied your patch in f9cd0ba. Port to building as a module and use xfce4ui can happen later...

Bug #7015

Reported by:
Christoph Wickert
Reported on: 2010-12-19
Last modified on: 2015-02-18

People

Assignee:
Robby Workman
CC List:
4 users

Version

Version:
unspecified

Attachments

patch for xfce4-panel >= 4.7 (1.17 KB, patch)
2010-12-19 21:45 CET , Christoph Wickert
no flags
Fix bz7015 (2.83 KB, patch)
2015-02-18 00:01 CET , Robby Workman
no flags

Additional information