Comment 1 Ali Abdallah 2009-10-06 13:44:22 CEST

Totally weired, i'm loading the following icon name for displaying on the media list when a media is playing.

"player_play" // if does not exist, then gtk-media-play-ltr.

Try please to see what player_play icon is in you icon theme.

Comment 2 Mike Massonnet 2009-10-06 19:59:07 CEST

Ok, thanks for the info, I'll let you know soonish.

Comment 3 Mike Massonnet 2009-10-06 20:37:59 CEST

I ran a small test code, and what I get is a play button :-/

using Gtk;
int main(string[] args) {
	Gtk.init (ref args);
	var win = new Gtk.Window(Gtk.WindowType.TOPLEVEL);
	var img = new Gtk.Image.from_icon_name("player_play", Gtk.IconSize.BUTTON);
	win.add(img);
	win.show_all();
	Gtk.main();
	return 0;
}

Comment 4 Ali Abdallah 2009-10-07 10:55:09 CEST

Created attachment 2586 
Disable play pixbuf when playing.

It it the weirdest bug i ever have, i don't know from where the stop button in coming, let's proceed by elimination, try the attached patch, it should not draw any pixbuf on the playlist when playing.

Comment 5 Mike Massonnet 2009-10-07 19:42:10 CEST

When I start a song the Pause icon is displayed and when I stop it then it is blank.

Now looking at it, and I covered it. Xfce themed icon load is doing some crap. In fact I extended my test program, and I added a Xfce.Icon.load("player_play", 16) under the Gtk.Image.from_icon_name and what I now see is a play button and a ... stop button!

If there is no good reason to keep xfce_themed_icon I had suggest to jump to Gtk.Image.from_icon_name as simple as thay :-) Besides I'm not sure the Xfce themed icon stuff is in libxfce4ui or will ever be there.

Comment 6 Ali Abdallah 2009-10-09 06:53:02 CEST

(In reply to comment #5)
> When I start a song the Pause icon is displayed and when I stop it then it is
> blank.
> 
> Now looking at it, and I covered it. Xfce themed icon load is doing some crap.
> In fact I extended my test program, and I added a Xfce.Icon.load("player_play",
> 16) under the Gtk.Image.from_icon_name and what I now see is a play button and
> a ... stop button!
> 
> If there is no good reason to keep xfce_themed_icon I had suggest to jump to
> Gtk.Image.from_icon_name as simple as thay :-) Besides I'm not sure the Xfce
> themed icon stuff is in libxfce4ui or will ever be there.

Please try out the latest commit if you have time, i replaced the call.

Comment 7 Mike Massonnet 2009-10-09 07:18:54 CEST

Nope. Gtk icon theme load displays the stop icon too :-/

Btw, the decl. of the about function in parole-about.h has not been updated.

Comment 8 Mike Massonnet 2009-10-09 07:30:31 CEST

WTFLOL...

The icon in the theme shows of course up like a stop button. Gonna open a bug on moblin. So much for the noise here.

Comment 9 Ali Abdallah 2009-10-09 07:31:35 CEST

(In reply to comment #8)
> WTFLOL...
> 
> The icon in the theme shows of course up like a stop button. Gonna open a bug
> on moblin. So much for the noise here.

Yeah, this bug was very strange to me from the beginning, but anyway i had to get rid of xfce_themed_icon ;).

Comment 10 Mike Massonnet 2009-10-09 07:32:15 CEST

FTR, it looks like the from_icon_name didn't pick up the 16x16 version, maybe the svg or else. In fact the 16x16 version is the only that has a stop icon.