! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Play button kept insensitive
Status:
RESOLVED: FIXED

Comments

Description Mike Massonnet editbugs 2009-09-16 22:06:48 CEST
After running parole from the command line I filled the playlist with several medias, the play button was left insensitive, I had except it to be clickable at this point.

After clicking inside the playlist I see that the play button gets sensitive. So my request would be, when there isn't any row selected, play the first media of the list when pressing the play button.

Playing a little more... there aren't any next/previous track buttons. That's ok, tho I catched another bug, first when I clicked play there appears a "stop" icon beneath the current media in the playlist, I think it should be "play". Second when I clicked stop, the row was still selected in the playlist but the play button wents insensitive.
Comment 1 Ali Abdallah editbugs 2009-09-28 13:21:56 CEST
(In reply to comment #0)
> After running parole from the command line I filled the playlist with several
> medias, the play button was left insensitive, I had except it to be clickable
> at this point.
> 
> After clicking inside the playlist I see that the play button gets sensitive.
> So my request would be, when there isn't any row selected, play the first media
> of the list when pressing the play button.
> 
> Playing a little more... there aren't any next/previous track buttons. That's
> ok, tho I catched another bug, first when I clicked play there appears a "stop"
> icon beneath the current media in the playlist, I think it should be "play".
> Second when I clicked stop, the row was still selected in the playlist but the
> play button wents insensitive.

Sorry for the late reply, i just arrived from my vacation, i will try to fix these issues this evening.
Comment 2 Mike Massonnet editbugs 2009-09-28 13:38:35 CEST
I think it would be useful to track the position in the playlist independently of the selected row, in a way that pressing the play button doesn't necessarely follow the row selection. It sounds simpler to do it like that, but it's just my quick opinion.
Comment 3 Ali Abdallah editbugs 2009-09-29 09:57:24 CEST
(In reply to comment #2)
> I think it would be useful to track the position in the playlist independently
> of the selected row, in a way that pressing the play button doesn't necessarely
> follow the row selection. 

Usually when the user clicks play he is expecting the selected media to be played, i dunno how i can keep track of position without having to use the selected row as a starting point.

Anyway, please have a look to the latest commit, it should fix these issues.
Comment 4 Mike Massonnet editbugs 2009-09-30 07:23:17 CEST
Yes, it works fine. If you ask me, it is ok to play the selected row, it is just uncommon with regard to e.g. winamp.

Btw, I noted that when a song is played it has a stop icon beneath it in the playlist, should this really be a stop icon, not rather a play icon?

Marking the bug as resolved.
Comment 5 Ali Abdallah editbugs 2009-09-30 07:52:36 CEST
(In reply to comment #4)

> Btw, I noted that when a song is played it has a stop icon beneath it in the
> playlist, should this really be a stop icon, not rather a play icon?

Which icon you see when you click pause, probably the play pixbuf is not loaded correctly and the pause pixbuf were not overwritten.
Comment 6 Mike Massonnet editbugs 2009-09-30 09:13:03 CEST
(In reply to comment #5)
> (In reply to comment #4)
> 
> > Btw, I noted that when a song is played it has a stop icon beneath it in the
> > playlist, should this really be a stop icon, not rather a play icon?
> 
> Which icon you see when you click pause, probably the play pixbuf is not loaded
> correctly and the pause pixbuf were not overwritten.

When I click pause I see the pause icon, reclicking shows stop again.
Comment 7 Ali Abdallah editbugs 2009-10-01 06:44:56 CEST
(In reply to comment #6)
> When I click pause I see the pause icon, reclicking shows stop again.

Weired, can you make a small screenshot to make it more clear to me please.

Bug #5766

Reported by:
Mike Massonnet
Reported on: 2009-09-16
Last modified on: 2009-10-06

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information