! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
New windows have mnemonics even when disabled on GTK+ 2.16.5
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description michael@elehack.net 2009-08-30 17:11:20 CEST
Created attachment 2523 
Patch to delay mnemonic update

After some updates on my Debian system, the terminal started enabling menu
access keys on all new windows even if I had them disabled.  Enabling and
re-disabling them fixed it.  I reported this to Debian as bug 539940[1].

Today I went digging to try to figure it out and discovered that
terminal_window_init calls terminal_window_update_mnemonics to disable access
keys, but the GtkAction proxy widgets weren't yet created so it didn't have
anything to do; the proxy widgets don't exist until after terminal_window_init
returns.  I have attached a patch which connects
terminal_window_update_mnemonics to the TerminalWindow::show signal; this seems
to delay the mnemonic update until after the proxy widgets are created and thus
fix the problem.

I am guessing that this problem was brought to light by a GTK update, but I am
not sure.

1. http://bugs.debian.org/539940
Comment 1 michael@elehack.net 2009-08-30 17:16:10 CEST
The patch is against 0.4.0.
Comment 2 Nick Schermer editbugs 2009-08-31 07:04:05 CEST
Good catch. However there is a good way to disable mnemonics since Gtk 2.12. This does however disable them application wide (so also in the preferences dialog), but I can live with that.
Comment 3 michael@elehack.net 2009-08-31 15:23:53 CEST
What about the case where someone needs/wants accessibility, but also wants meta keys to work correctly in the terminal; thus they disable access keys but leave F10 enabled to activate the menu and then want access keys in the preferences dialog.

I am not in this situation, so the global disable works for me, but long-term it might be a good idea to facilitate this use pattern.  Probably not high-priority, though, unless someone specifically requests it.
Comment 4 Nick Schermer editbugs 2009-08-31 16:11:03 CEST
Well the previous way was more of a hack too. Gnome terminal does the same thing right now (application wide settings), so I guess it's fine.
A way to fix it is taking the preferences dialog code out of the terminal and put it in a separate binary.
Comment 5 Nick Schermer editbugs 2010-01-29 09:44:31 CET
*** Bug 6190 has been marked as a duplicate of this bug. ***

Bug #5714

Reported by:
michael@elehack.net
Reported on: 2009-08-30
Last modified on: 2010-01-29
Duplicates (1):
  • 6190 Disable all menu access keys isn't persistent

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Attachments

Patch to delay mnemonic update (621 bytes, patch)
2009-08-30 17:11 CEST , michael@elehack.net
no flags

Additional information