! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
weather plugin may deadlock on network error
Status:
CLOSED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Leonid Evdokimov 2009-08-24 11:55:58 CEST
Created attachment 2517 
possible fix

Weather plugin may block on recv() forever* in some cases: it should be trivial
to reproduce the bug with combination of laggy network & suspend-resume.
Connection remains alive from kernel's point of view but no data comes and
plugin deadlocks.

I append possible patch fixing the issue for me, though it's rather ugly. See
FIXME comment in the code.

*) I waited for some hours.
Comment 1 Josh Saddler 2009-12-29 23:59:50 CET
I think this is what's happening today. Suddenly the plugin is totally dead. (Re)Adding it doesn't work, because the initial window is completely frozen.

This is confirmed with other users that I asked on #xfce. Maybe it is when weather.com (or xoap.weather.com, which is unreachable today) has problems that the weather applet hardlocks.

Please, we need this fix ASAP! My logs are filled with snippets like:


(xfce4-weather-plugin:10344): weather-WARNING **: Unable to open image: /usr/share/xfce4/weather/icons/liquid/-.png

(xfce4-weather-plugin:10344): weather-WARNING **: Unable to open image: /usr/share/xfce4/weather/icons/liquid/-.png

(xfce4-weather-plugin:10344): weather-WARNING **: Unable to open image: /usr/share/xfce4/weather/icons/liquid/-.png
libxfce4panel-Message: Weather Update: screen changed: 0

libxfce4panel-Message: No valid plug window.


. . . if there is a deadlock as described above, that could certainly lead to the rest of the program not loading normally.
Comment 2 Christoph Wickert editbugs 2009-12-30 00:14:14 CET
Same here with 0.7.3, stopped working half an hour ago. Cannot ping xoap.weather.com and the plugin freezes:
- The existing one still works but shows no data, and freezes after entering the prefs dialog.
- Adding a new instance doesn't work any longer because it freezes on initial configuration.
Comment 3 Christoph Wickert editbugs 2009-12-30 00:35:14 CET
(In reply to comment #2)
> - Adding a new instance doesn't work any longer because it freezes on initial
> configuration.

OK, it never really freezes, it is just unresponsive for a long time.
Comment 4 Colin Leroy 2010-01-22 08:54:25 CET
*** Bug 6057 has been marked as a duplicate of this bug. ***
Comment 5 Harald Judt 2010-01-22 09:45:36 CET
Created attachment 2790 
Fix very long update time

I've solved this by applying the patch from comment #1 and setting update time to 60.
However, I think this is not really a solution to this problem.
Comment 6 charlie-tca 2010-05-14 04:15:54 CEST
This bug has also been reported to Ubuntu Launchpad as:
https://launchpad.net/bugs/546450 .

Please advise if additional logs or backtrace is needed.
Comment 7 Harald Judt 2012-08-09 12:59:26 CEST
Is this still an issue? The FIXME in the code is still there, but does anyone actually experience any deadlocks? If so, is there some way to reproduce it?
Comment 8 Harald Judt 2012-08-19 15:51:47 CEST
It doesn't seem so. I haven't experienced any lockups anymore, and do hibernate/suspend and resume my machines a lot, therefore closing this long-standing bug now.

Bug #5695

Reported by:
Leonid Evdokimov
Reported on: 2009-08-24
Last modified on: 2012-08-19
Duplicates (1):
  • 6057 xfce4-weather-plugin-0.7.3 stops working when network connection is lost after hibernate/resume

People

Assignee:
Harald Judt
CC List:
4 users

Version

Version:
0.7.3 or older

Attachments

possible fix (3.17 KB, patch)
2009-08-24 11:55 CEST , Leonid Evdokimov
no flags
Fix very long update time (504 bytes, patch)
2010-01-22 09:45 CET , Harald Judt
no flags

Additional information