! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Do not mark GTK+ stock strings translatable
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
General

Comments

Description Jari Rahkonen 2008-12-15 17:48:38 CET
There are ten GTK+ stock strings in xfce4-settings that have been marked as translatable. In a thread[0] on the xfce-i18n mailing list I was told that this should not be the case and was asked to file a bug. Individual stock strings should only be marked translatable if a translator requests this due to specific needs of their language.


The strings are as follows (in PO template format):

#: ../dialogs/accessibility-settings/accessibility-dialog.glade.h:35
#: ../dialogs/appearance-settings/appearance-dialog.glade.h:34
#: ../dialogs/display-settings/display-dialog.glade.h:8
#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:29
#: ../dialogs/mouse-settings/mouse-dialog.glade.h:28
#: ../xfce4-settings-editor/xfce4-settings-editor.glade.h:12
msgid "gtk-close"

#: ../dialogs/display-settings/display-dialog.glade.h:7
msgid "gtk-apply"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:27
msgid "gtk-add"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:28
#: ../xfce4-settings-editor/xfce4-settings-editor.glade.h:11
msgid "gtk-cancel"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:30
msgid "gtk-delete"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:31
msgid "gtk-edit"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:32
msgid "gtk-help"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:33
msgid "gtk-ok"

#: ../dialogs/keyboard-settings/keyboard-dialog.glade.h:34
msgid "gtk-remove"

#: ../xfce4-settings-editor/xfce4-settings-editor.glade.h:13
msgid "gtk-save"



[0] http://foo-projects.org/pipermail/xfce-i18n/2008-December/007651.html
Comment 1 Stephan Arts editbugs 2008-12-20 22:58:22 CET
looking at it.
Comment 2 Stephan Arts editbugs 2008-12-20 23:11:29 CET
This is caused by glade, I guess we could patch the files... 

I think it should be fixed there.
Comment 3 Stefan Stuhr 2009-02-09 15:55:52 CET
Created attachment 2162 
Proposed patch

I have finally become annoyed enough by these having been translated in the
Danish translation to make this patch :-)
Comment 4 Jannis Pohlmann editbugs 2009-02-22 13:05:58 CET
Hey. I've completely overseen this one. I just committed the same fix to SVN (revisions 29529 and 29531). But thanks for the patch. I would've used it if I had known about its existence ;)

Bug #4720

Reported by:
Jari Rahkonen
Reported on: 2008-12-15
Last modified on: 2009-07-14

People

Assignee:
Stephan Arts
CC List:
3 users

Version

Attachments

Proposed patch (10.48 KB, patch)
2009-02-09 15:55 CET , Stefan Stuhr
no flags

Additional information