! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Uniformisation of test method
Status:
RESOLVED: INVALID
Severity:
enhancement
Product:
Xfce-utils
Component:
General

Comments

Description William Bonnet 2008-11-06 20:52:17 CET
Created attachment 1958 
Uniformisation of test method

xinitrc script does not use the same test method to evaluate executable names. This patch propose a fix to uniformize some of the tests.
Comment 1 Brian J. Tarricone (not reading bugmail) 2008-11-06 21:12:27 CET
No, this patch is completely wrong.

1.  It removes the test of DBUS_SESSION_BUS_ADDRESS to ensure a bus isn't already running.

2.  It removes the use of 'eval', so the new environment variables don't get propagated into the shell.

Did you even test this?  There's no way it can work.

Really, there's no reason to change how it is now, except maybe to use 'type -p dbus-launch' instead of 'which dbus-launch', esp since 'which' differs in its output on different platforms when it fails to find an executable.

(Also: xinitrc gets generated from xinitrc.in; no need to patch them both.)
Comment 2 William Bonnet 2008-11-06 21:38:00 CET
Sorry i attached the wrong patch file. You are completly right about this the error. 

If there is no reason to change it, so no need to fix my error. Just ignore this :) Sorry for the noise. I let you mark the bug to the good status (rejected or so)

Regards,
Comment 3 Jérôme Guelfucci editbugs 2010-10-17 12:25:30 CEST
Closing this as per user request.

Bug #4583

Reported by:
William Bonnet
Reported on: 2008-11-06
Last modified on: 2010-10-17

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Uniformisation of test method (1.45 KB, patch)
2008-11-06 20:52 CET , William Bonnet
no flags

Additional information