! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal-0.2.8 can't handle clickable URIs correctly
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Josh Saddler 2008-10-12 03:36:25 CEST
This bug is possibly related to bug #3210 -- only it doesn't matter what webbrowser is set.

Terminal cuts off URIs as soon as it reaches an apostrophe ('). Thus when the following URI appears in the window:

http://www.google.com/search?q=+nightmorph%0D&btnI=I'm+Feeling+Lucky

. . . it gets reduced to the following underlined, clickable form:

http://www.google.com/search?q=+nightmorph%0D&btnI=I'

It's kind of annoying. Not a critical blocker, but definitely buggy.

(Also, why isn't 0.2.8 available as a selection for the bug's Version field?)
Comment 1 Nick Schermer editbugs 2009-06-27 21:05:58 CEST
Bug in the google page, ' is not allowed in html and they should use ' for
this char. In the terminal this is also the start of an escaped string, so it
will break anyways.
Comment 2 Josh Saddler 2009-06-28 03:29:56 CEST
(In reply to comment #1)
> Bug in the google page, ' is not allowed in html and they should use ' for
> this char. In the terminal this is also the start of an escaped string, so it
> will break anyways.

This is not just for Google; that was merely the most convenient example. Many web pages, especially those involving server-side processing, feature ' marks.

Additionally, this error happens in IRC conversations, where quotation marks appear around URIs. Other types of punctuation at the end or beginning of URIs, including commas (commas!) break up the URI handling. It assumes that it's all part of the link for some reason.

I don't believe that contacting a few million website owners and telling them to use ASCII escape characters for their URIs is a real solution. But perhaps adding a bit smarter detection and underlining to Terminal is feasible? It really can't make sense of any punctuation except ? = + . and then only if they fall in the right place in a random text fragment.
Comment 3 Nick Schermer editbugs 2009-06-28 09:42:09 CEST
Well play around with the regexes in terminal-widget.c, see if you can fix it.
Comment 4 Nick Schermer editbugs 2009-07-05 14:30:19 CEST
Fixed in revision 30198.

Bug #4465

Reported by:
Josh Saddler
Reported on: 2008-10-12
Last modified on: 2009-07-05

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information