Since some weeks/months I always get crashes when I quit Xfce. I tracked down the cause to the sensors plugin which seems to free() an invalid pointer in sensors_free(). Using latest SVN version.
Created attachment 1735 Crash log of the sensors plugin at exit
OK, I don't see these errors when closing the panel; but I don't have ACPI running. In the ACPI implementation, I wasn't able to find anything specific; though I found one statically assigned variable in all three sensor interfaces that is now given a string duplicate in order to be free()able. It still works for me, and also introduces some more string freeing, thus statically saving a minor amount of memory. Please try and report, I am curious :)
No changes at all :(. I also don't have any ACPI sensors. The plugin is compiled with ACPI support but the configure dialog tells me: "Beschreibung: ACPI v<Unbekannt>" and doesn't list any sensors. The crashes when plugin gets unloaded are still present.
Created attachment 1850 Possible fix for the crashes I spent some more time on this issue since it still exists and is very annoying. This time I was more successful and this patch fixes these issues (actually it was not only one bug but a whole couple). The reason for the crashes is that you use often things like: chip->name = _("blah"); and then later in the code you use: g_free(chip->name); this must crash, obviously. I fixed all relevant occurrences I could find, see attached patch. Please don't mix static and dynamically allocated strings :).
(In reply to comment #4) > > The reason for the crashes is that you use often things like: > chip->name = _("blah"); > and then later in the code you use: > g_free(chip->name); > this must crash, obviously. For sure. > > I fixed all relevant occurrences I could find, see attached patch. > Please don't mix static and dynamically allocated strings :). Actually, I thought I already had had a look into all statically allocated strings; thanks a lot for investigating further - at least I did not look into the backend implementations.
*** Bug 4833 has been marked as a duplicate of this bug. ***