! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar: Thunar does not save position after deleting File in detailed list vi...
Status:
RESOLVED: FIXED

Comments

Description Yves-Alexis Perez editbugs 2008-02-27 14:43:32 CET
A debian user reported that when deleting a file in detailed view mode, the focus was reseted to the first file in the list, and not (for example) the next one.

This makes keyboard navigation harder.

This is on 0.9.0 (but this one doesnt exist on bugzilla)

Cheers,
Comment 1 Maximilian Schleiss editbugs 2008-11-24 17:51:09 CET
*** Bug 4108 has been marked as a duplicate of this bug. ***
Comment 2 Jannis Pohlmann editbugs 2008-11-24 23:29:25 CET
Reproducable here. I'm working on a fix right now.
Comment 3 Jannis Pohlmann editbugs 2008-11-25 01:06:44 CET
Okay, this was a tricky one. It actually affected all views, not only the detailed list view. I hope I've fixed it permanently and I tried to fix it as clean as possible. 

	* thunar/thunar-standard-view.c: Restore the selection after deleting
	  a file/folder. This is done by connecting to the "row-deleted"
	  signal of the model twice. The first handler saves the tree path to
	  be selected after the removal in the selection_before_delete member.
	  The second handler (which is called after the signal is emitted)
	  selects this path. Selection is not modified if there are two or
	  more files selected.

@Yves-Alexis: The commit diff should apply fine to beta 2. Could you check before and after applying it to your package?
Comment 4 Jannis Pohlmann editbugs 2008-11-25 02:15:17 CET
(In reply to comment #3)
> Okay, this was a tricky one. It actually affected all views, not only the
> detailed list view. I hope I've fixed it permanently and I tried to fix it as
> clean as possible. 
> 
>     * thunar/thunar-standard-view.c: Restore the selection after deleting
>       a file/folder. This is done by connecting to the "row-deleted"
>       signal of the model twice. The first handler saves the tree path to
>       be selected after the removal in the selection_before_delete member.
>       The second handler (which is called after the signal is emitted)
>       selects this path. Selection is not modified if there are two or
>       more files selected.

This is revision 28902 btw.
Comment 5 Yves-Alexis Perez editbugs 2008-11-25 06:32:55 CET
(In reply to comment #4)
> (In reply to comment #3)
> > Okay, this was a tricky one. It actually affected all views, not only the
> > detailed list view. I hope I've fixed it permanently and I tried to fix it as
> > clean as possible. 
> > 
> >     * thunar/thunar-standard-view.c: Restore the selection after deleting
> >       a file/folder. This is done by connecting to the "row-deleted"
> >       signal of the model twice. The first handler saves the tree path to
> >       be selected after the removal in the selection_before_delete member.
> >       The second handler (which is called after the signal is emitted)
> >       selects this path. Selection is not modified if there are two or
> >       more files selected.
> 
> This is revision 28902 btw.

Is 28903 part of the fix too?
Comment 6 Yves-Alexis Perez editbugs 2008-11-25 06:53:01 CET
(In reply to comment #3)
> @Yves-Alexis: The commit diff should apply fine to beta 2. Could you check
> before and after applying it to your package?

Ok, it works fine, thanks!
Comment 7 Jannis Pohlmann editbugs 2008-11-25 11:01:43 CET
Ok, I'm marking this one as fixed then.

Bug #3884

Reported by:
Yves-Alexis Perez
Reported on: 2008-02-27
Last modified on: 2009-07-17
Duplicates (1):
  • 4108 Deleting selected file in detailed list view makes 'positioner' go back to top of list

People

Assignee:
Jannis Pohlmann
CC List:
3 users

Version

Attachments

Additional information