! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Appointment end time not updated when start time is changed
Status:
CLOSED: FIXED

Comments

Description carbonfreeze 2008-02-11 03:46:50 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080203 Firefox/2.0.0.12
Build Identifier: 

XFCE/Orage 4.4.2
Suse 10.3

When adding an appointment, if the start time is changed to be later than the end time, an error is displayed when changes to the appointment are saved "The end of this appointment is earlier than the beginning".

Reproducible: Always

Steps to Reproduce:
1). Open Orage, select day to create appointment on calendar
2). Select "New" on Orage appointment window.
3). Change start time to a later time.
4). Attempt to close/save appointment
Actual Results:  
"The end of this appointment is earlier than the beginning"

error is displayed.

Expected Results:  
When creating an appointment & setting start time, end time should automatically be adjusted to be later than the start time. The error noted above should only be shown if the user manually selects an invalid end time.
Comment 1 juha editbugs 2008-02-11 07:08:35 CET
Why should it be different if the problem comes from changing the start time or
end time?
I think it is confusing id Orage starts changing times on its own. It is 
impossible to know when it s right. So I think it is beter to notify the user
that something may be wrong. Perhaps he selected start time accidentally wrong.

You can avoid this error if you cross duration check box. Then Orage uses
duration instead of end time. 

Perhaps duration should actually be default with new appointments. That would
eliminate this error with new appointments. hmm.
Comment 2 carbonfreeze 2008-02-11 07:49:12 CET
(In reply to comment #1)
> Why should it be different if the problem comes from changing the start time or
> end time?

I don't know. I'm just used to the behavior in Kontact; you set the start time of the event, kontact loads your default event duration from settings, and then increments the end time of the event to be +whatever you default duration setting is. If you change the event start time, end time is automatically adjusted.

> I think it is confusing id Orage starts changing times on its own. It is 
> impossible to know when it s right. So I think it is beter to notify the user
> that something may be wrong. Perhaps he selected start time accidentally wrong.

I would agree with this, if the user attempted to set an end time that was before the start time of the event. However, I think most users expect the application to automatically adjust the end time to be after the start time. I don't think Orage should change the start time, only the end time if the user is adjusting the start time. Perhaps there should be a default duration setting which can be adjusted in the preferences; this could apply to both the start/end time event behavior and the "Duration" event behavior. Ex. if user sets this to 1 hr, event is automaticially 1hr long in "Duration" or Start/End event mode.

> You can avoid this error if you cross duration check box. Then Orage uses
> duration instead of end time. 
> 
> Perhaps duration should actually be default with new appointments. That would
> eliminate this error with new appointments. hmm.

I just tried using "Duration" setting. It seems more intuitive compared to the current behavior of Start/End time mode; I don't have to change end time each time I try to create an event that does not start at the default time. But using "Duration" I still have to set the event duration manually. Additionally, it does not seem possible to set "Duration" as the default behavior when creating events. File as separate bug?
Comment 3 juha editbugs 2008-02-11 08:28:42 CET
" But using "Duration" I still have to set the event duration manually. "
What do you mean? The duration should not change if you move the start time?

I will change duration to be the default instead of end time. No BUG needed.
I tested that in my dev version and it seems to work better indeed.

Orage was planned to work mainly with copy appointment, so that creating new
appointments from scratch should happen rarely. That is why there are no 
user modifiable defaults or templates available in Orage. In my opinion there
is no real need for these since usually new appointments are similar to some
old one and if it really is new, Orage can not quess the settings anyway and 
1 default would not be enough; we would need bunch of templates. But those are
then actually very similar that just copying an existent appointment.
Comment 4 carbonfreeze 2008-02-11 09:26:27 CET
(In reply to comment #3)
> " But using "Duration" I still have to set the event duration manually. "
> What do you mean? The duration should not change if you move the start time?

When creating a new event in Orage 4.4.2 and selecting "Duration," the default event duration is 0 days/hours/minutes. This is also the case if you initially use the Start/End method of setting the appointment up; when changing from Start/End to duration mode, duration does not use your start/end settings as a basis for its own settings (not that I would expect it to).

> I will change duration to be the default instead of end time. No BUG needed.
> I tested that in my dev version and it seems to work better indeed.
> 
> Orage was planned to work mainly with copy appointment, so that creating new
> appointments from scratch should happen rarely. That is why there are no 
> user modifiable defaults or templates available in Orage. In my opinion there
> is no real need for these since usually new appointments are similar to some
> old one and if it really is new, Orage can not quess the settings anyway and 
> 1 default would not be enough; we would need bunch of templates. But those are
> then actually very similar that just copying an existent appointment.

Is there a way to view a list of past events without having to select the individual days? Perhaps add the ability for the user to click on the week # or month to bring up a list of events for the entire week/month instead of day? Up to this point, duplication of events did not seem intuitive to me; I had not even thought of the possibility, however I am used to other calendar/PIM applications such as gpe, kontact or thunderbird where I created events individually from defaults.

Being able to either use the 'copy old appointments' method or the 'create new appointments with reasonable defaults' method would be nice. This way users who are not used to the "copy old appointment" method can still use the application without unnecessary frustration. Or maybe, as an option, Orage could use the settings from your last created appointment when creating a new appointment (removing the duplicate step if an appointment is the same).
Comment 5 juha editbugs 2008-02-14 11:33:16 CET
This is fixed in svn Orage 4.5.12.7 (revision 26610).

Changed Orage to use duration by default for new appointments, so that now
changing start date is enough.

> Is there a way to view a list of past events without having to select the
> individual days? Perhaps add the ability for the user to click on the week # or
> month to bring up a list of events for the entire week/month instead of day

Orage 4.5 has new day list view, which shows days instead of event lists.
Gtk calendar view does not offer possibility to click week or month, so doing
that would mean recoding the whole Gtk widget.

(You can see past events also in the event list view.)

Enhancing the defaults handling will be discussed in BUG 3842.

Bug #3841

Reported by:
carbonfreeze
Reported on: 2008-02-11
Last modified on: 2009-02-28

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information