! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Special tabs configuration causes a segfault
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
major
Product:
Xfce4-terminal
Component:
General

Comments

Description Mike Massonnet editbugs 2008-01-19 16:32:20 CET 
Hi Benny,

I updated my system today, and it introduced a new libvte version.  Well everything fine, except in the case where you set MiscAlwaysShowTabs=TRUE.  In that case the app starts and inside terminal_window_notebook_visibility it calls active = terminal_window_get_active (window); but gets a NULL value in return.

I attach a patch where:
1) I moved the settings for the notebook in the beginning of the if condition
2) A modified call to gtk_notebook_set_show_tabs with "always_show_tabs | !tabs_shown"
2) A check for a nil value on active, with a direct return in case it is true

Cheers,
mike
Comment 1 Mike Massonnet editbugs 2008-01-19 16:33:52 CET 
Created attachment 1494 
nil value check + always_show_tabs fix
Comment 2 Mike Massonnet editbugs 2008-01-19 16:35:44 CET 
Ooops, please take care of the tabs :/
Comment 3 Mike Massonnet editbugs 2008-01-30 20:34:57 CET 
I figured out a bug inside GtkNotebook, which may be the same cause for this segfault.

http://bugzilla.gnome.org/show_bug.cgi?id=513230
Comment 4 David Mohr 2009-03-09 20:06:21 CET 
I saw that the gtk fix was applied, but can the workaround still go into Terminal for older gtk versions?
Comment 5 Mike Massonnet editbugs 2009-03-10 00:09:11 CET 
I builded Terminal as-is without the patch with GTK+ 2.14.7, and I still get crashes if I set the tabs to be always displayed (hidden option). In fact I was wrong and the GNOME bug #513230 has nothing to do with this.
Comment 6 Piotr Smyrak 2009-05-02 21:08:20 CEST 
I'm seeing it now on FreeBSD, too. I was used to set MiscAlwaysShowTabs=TRUE due to http://bugzilla.xfce.org/show_bug.cgi?id=4331, and got bitten by this new issue after upgrading.
Comment 7 Nick Schermer editbugs 2009-06-27 19:23:26 CEST 
Fixed in revision 30084

Bug #3809

Reported by:
Mike Massonnet
Reported on: 2008-01-19
Last modified on: 2009-06-27

People

Assignee:
Benedikt Meurer
CC List:
3 users

Version

Version:
unspecified
Target Milestone:
0.2

Attachments

nil value check + always_show_tabs fix (1.18 KB, patch)
2008-01-19 16:33 CET , Mike Massonnet 		no flags

Additional information