! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Launcher button without button border
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Yves-Alexis Perez editbugs 2007-03-17 09:16:07 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8.0.10) Gecko/20070209 (Debian-1.8.0.10-3) Epiphany/2.14
Build Identifier: 

Hi,

I use xfce4-panel with a small size (24/25 mostly), and I think that launchers icons are quite smaller than the panel size itself. Looking at the code, it seems that a fixed margin is added around the icon, 2px wide. I've tried removing this margin and I find the panel more good looking without it.

It looks good at every size, but maybe at large size it would make more sense to remove the variable size margin, I don't know.

Anyway, I've attached the patch, if you want to try it. I guess there are design  issue I didn't see so maybe it's a very bad idea, but anyway here is a wishlist bug to reduce margin size :)

Reproducible: Always
Comment 1 Yves-Alexis Perez editbugs 2007-03-17 09:17:12 CET
Created attachment 1036 
disable fixed-width margin on launchers
Comment 2 Jasper Huijsmans editbugs 2007-03-17 09:36:45 CET
Hmm, those margins are there not because I like the extra empty space, but rather to prevent cut-off icons. 

The plugin size is not currently used as the icon size (there's a bug open about this from Benedikt), so we need to take into account the extra space used by the button. As far as I know a gtk button uses at least a fixed border of 1 plus the theme-dependend x/ythickness. 

If there is a plugin on your panel that is bigger than than the size you set in the configuration it may happen that the launcher icons are smaller than the available space.

I just tested by just removing the fixed border and I already see cut-off icons, so I don't think I can commit this patch.
Comment 3 Yves-Alexis Perez editbugs 2007-03-17 09:51:28 CET
(In reply to comment #2)
> Hmm, those margins are there not because I like the extra empty space, but
> rather to prevent cut-off icons. 

Yes, I wasn't implying this :)
> 
> The plugin size is not currently used as the icon size (there's a bug open
> about this from Benedikt), so we need to take into account the extra space used
> by the button. As far as I know a gtk button uses at least a fixed border of 1
> plus the theme-dependend x/ythickness. 
> 
> If there is a plugin on your panel that is bigger than than the size you set in
> the configuration it may happen that the launcher icons are smaller than the
> available space.
> 
> I just tested by just removing the fixed border and I already see cut-off
> icons, so I don't think I can commit this patch.

I see, and it was the "design issues" I feared. But in this case, shouldn't the plugin be fixed to respect the panel size? When I set a panel size I expect all plugins to respect it so I end with a panel which size *is* the size I've chosen and not the size a plugin requested. In case a plugin size and the panel size mismatchs, the launcher icon may be really tiny (because it follow the panel requested size, minus margin, while the panel at the end has the "bad" plugin size.)

Regards,
Comment 4 Nick Schermer editbugs 2008-10-24 07:15:44 CEST
We can only improve this by using XfceScaledImage. I've fixed some issues in this widget and it will be available in the 4.8 panel. Maybe I'll add an icon-only mode to the launcher too (without gtkbutton), since that might look better with a transparent panel, but I'm not sure yet.
Comment 5 Nick Schermer editbugs 2010-02-02 19:01:24 CET
The XfcePanelImage widget should automatically set the biggest icon possible (based on the widget allocation), so that part is fixed.

Changing the bug to allow a button-less launcher.
Comment 6 Simon Steinbeiss editbugs 2018-12-06 00:46:07 CET
This is possible with Gtk+3 theming now.

Bug #3022

Reported by:
Yves-Alexis Perez
Reported on: 2007-03-17
Last modified on: 2018-12-06

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Attachments

disable fixed-width margin on launchers (825 bytes, patch)
2007-03-17 09:17 CET , Yves-Alexis Perez
no flags

Additional information