! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Trash plugin resizes the panel
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Nick Schermer editbugs 2006-07-29 16:45:42 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060727 Firefox/1.5.0.5 (Swiftfox)
Build Identifier: 0.3.3svn-r22558

The trash panel plugin resizes the panel, probably because
gtk used some convenience function to prevent blurred icons.

Comment from Benny @ ML:
That was my initial idea too, but that breaks with my top panel
(probably because some plugins are set to expand then) and only a
crippled trash icon is displayed. Maybe Jasper can sched some light on this.

Btw. maybe there should be a "panel plugin" component in the
bugzilla?

Reproducible: Always

Steps to Reproduce:
Comment 1 Nick Schermer editbugs 2006-07-29 16:46:31 CEST
Created attachment 680 
Fixed button size
Comment 2 Benedikt Meurer editbugs 2006-07-29 17:09:49 CEST
Jasper, any idea?

BTW: Scaling down icons at any rate doesn't look like a good idea either, i.e. as done by the launcher and several other plugins. That way setting panel size to 48px makes some non-SVG icons look ugly, even tho they are available at 48px. I'd say if the size is around 48px, the plugins should be allowed to use 48px for the icon plus the additional overhead for the button border, margin, etc. (same for 16px, 22px, 24px, 32px, ...)
Comment 3 Jasper Huijsmans editbugs 2006-07-29 18:12:18 CEST
(In reply to comment #2)
> Jasper, any idea?
> 
> BTW: Scaling down icons at any rate doesn't look like a good idea either, i.e.
> as done by the launcher and several other plugins. That way setting panel size
> to 48px makes some non-SVG icons look ugly, even tho they are available at
> 48px. I'd say if the size is around 48px, the plugins should be allowed to use
> 48px for the icon plus the additional overhead for the button border, margin,
> etc. (same for 16px, 22px, 24px, 32px, ...)
> 

I don't remember exactly, but I thought the panel border is already drawn outside this size, I mean, the item already gets the full 48px. Unfortunately, if you use a button that will take additional space. 

Maybe I could assume everything is using a button and add another [xy]thickness + 1? 

Comment 4 Benedikt Meurer editbugs 2006-07-29 18:50:20 CEST
Better use the real size request of the button border. See the tpa source.
Comment 5 Benedikt Meurer editbugs 2006-08-12 16:13:33 CEST
Any news?
Comment 6 Jasper Huijsmans editbugs 2006-08-12 16:19:51 CEST
Sorry, I lost track of this bug :(

I'll have a look at it tonight or tomorrow.
Comment 7 Benedikt Meurer editbugs 2006-08-12 16:55:31 CEST
Assigning to you, so you don't forget again. ;-)
Comment 8 Jérôme Guelfucci editbugs 2007-08-10 22:47:50 CEST
Any news on this ? 
Comment 9 Nick Schermer editbugs 2009-03-23 08:01:54 CET
One the 4.8 panel api is stable, I'll port the thunar plugin and use the improved scaled image object.
Comment 10 Nick Schermer editbugs 2009-05-26 07:00:20 CEST
Fixed with plugin migration patch, which can be found here:
http://foo-projects.org/~nick/plugin-migration/thunar.patch.
Comment 11 Nick Schermer editbugs 2010-02-27 15:09:03 CET
Devel branch has been merged in master. A 4.7.0 release will follow soon. If you think this bug is not fixed? Feel free to reopen the bug.

Bug #2084

Reported by:
Nick Schermer
Reported on: 2006-07-29
Last modified on: 2010-02-27

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Attachments

Fixed button size (463 bytes, patch)
2006-07-29 16:46 CEST , Nick Schermer
no flags

Additional information