User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060413 Ubuntu/dapper Firefox/1.5.0.1 Trying to copy a >2000 files folder from a USB stick I found that the copy does not progress unless the mouse is moved. Stracing Thunar indicates it stays in poll until mouse it pressed/moved. It also happens with copying between folders on the hard drive, it's just easier to see with many files and slower media. Moving the mouse over the progress dialog causes it to progress. Clicking or scrolling the mousewheel even when thunar is not focused again causes progress. Moving the mouse on the panel OTOH does not, it's stuck. Sometimes even when not moving the mouse it seems to go ahead but at a much slower rate (watch du -ks destdir while thunar is minimised). gtk 2.8.17 on ubuntu dapper Reproducible: Always
Created attachment 531 Suggested fix There's indeed a race condition between the job and the main loop. Please try this patch.
the patch does not seem to help
Created attachment 534 Next try Ok, please try this one then.
umm, actually the first patch worked. Have thunar installed in 3 places and launched an old one. Sorry.
No biggie, the second patch is better anyways. :-)
Committed with revision 21421. 2006-05-01 Benedikt Meurer <benny@xfce.org> * thunar-vfs/thunar-vfs-job.c: Fix a possible race condition when emit- ting signals from another thread, and make sure the prepare source method doesn't return -1 for the timeout if the source is ready to be dispatched. Bug #1743.