Created attachment 9662 patch for thunar As mentioned bug 10694, we should add keywords to .desktop files to improve search in whisker menu.
Good idea ! ... though your patch fails for me when applied to thunar-master Would be nice to have keywords as well for thunar-bulk-rename.desktop Regarding the keywords: File Manager: finder --> dont add this .. so far we dont have proper a search widget attributes --> dont add it ... its too generic. If every single application would add that keyword, nothing at all could be found Settings: I would not add all these internals keys. I e.g. if I search for "date" I would not expect to get the preferences of thunar (or of any application where I can configure a date format) Considering that, I would add the following: thunar;setting;preference;configure;folder;file;manage;explore;browse;directory;directories Proposal for bulk renamer: bulk;rename;thunar;folders;directory;directories;
(In reply to alexxcons from comment #1) > Good idea ! ... though your patch fails for me when applied to thunar-master No probs, will create a new one. > Would be nice to have keywords as well for thunar-bulk-rename.desktop roger. > finder --> dont add this .. so far we dont have proper a search widget This is meant as the name of the mac file manager - https://en.wikipedia.org/wiki/Finder_(software) > attributes --> dont add it ... its too generic. If every single application > would add that keyword, nothing at all could be found okay. > Settings: > I would not add all these internals keys. > I e.g. if I search for "date" I would not expect to get the preferences of > thunar (or of any application where I can configure a date format) Yes i do agree some keys can be removed. Search for 'date' now and it will show results with 'update', which i wouldn't expect, but its a basic search. The display of the date in a file manager is something important and being able to configure it is an important feature of a file manager's settings app, so if a user search for 'configure date' or 'date format', settings showing up is useful. > Considering that, I would add the following: > > thunar;setting;preference;configure;folder;file;manage;explore;browse; > directory;directories Repeating so many entries that are already in thunar's keywords here isn't beneficial to search. Here is my counter. thunar;settings;preferences;configure;thumbnails;file size;date format;shortcuts pane;tree view;tabs; > Proposal for bulk renamer: > > bulk;rename;thunar;folders;directory;directories; My suggestion bulk;renamer;renaming;thunar;files;folders;directory;directories;
So I filed bug 16628 as you brought up searching for 'date' and found some weird results and boy was i surprised.
> This is meant as the name of the mac file manager - https://en.wikipedia.org/wiki/Finder_(software) Ok, I did not know finder. Though I still would not add it ... It's just a name of a file-manager, we as well dont want to add norton commander, nautilus and dolphin here. > thunar;settings;preferences;configure;thumbnails;file size;date format;shortcuts pane;tree view;tabs; ok, fine. lets take a try for it > bulk;renamer;renaming;thunar;files;folders;directory;directories; fine fo me > So I filed bug 16628 as you brought up searching for 'date' and found some weird results and boy was i surprised. True .. possibly would give more accurate results to only match the name and the keywords (or only match the comment if no keywords are set?)
Same bug for other component: Bug#16618, Bug#16619, Bug#16620, Bug#16621
Created attachment 9668 patch for thunar attempt 2 (In reply to alexxcons from comment #4) > Ok, I did not know finder. Though I still would not add it ... It's just a > name of a file-manager, we as well dont want to add norton commander, > nautilus and dolphin here. Added it as its the default on mac, similar to having 'explorer' as its the default on windows. If you still disagree, you can remove it from the patch > True .. possibly would give more accurate results to only match the name and > the keywords (or only match the comment if no keywords are set?) Yes it would be good to optimize the search but keywords should be pulled from all three (name, comment, keywords) which would then reduce duplication across them.
Yousuf Philips referenced this bugreport in commit 8ee6f6601f1e8b465ee366238aa92ac74aba94e5 Add keywords to .desktop files to thunar (bug #16618) https://git.xfce.org/xfce/thunar/commit?id=8ee6f6601f1e8b465ee366238aa92ac74aba94e5
Ok, I kept explorer and finder. ... pushed to master.
can this be cherry-picked into 4.14 like bug 16618 and bug 16621?
Rather not, because these strings would need translation as well for 4.14 ... not sure how smart tranifex is these days. I dont want to punish our translators too much. On top it's not directly a bugfix, more like a feature.