The partition order shown in tree view compared to shortcuts view or the desktop isnt the same and the order in tree view constantly changes after closing and reopening. Here is a screencast showing the problem which was tested on Xubuntu 20.04 from Feb 24th. https://www.youtube.com/watch?v=TrZDVlcifIY
Thanks for reporting! Its unlikely that I will have time to work on a fix for that myself in the near future, so patches would be very welcome !
The device entries in shortcuts view are sorted by timestamp. No sorting is applied in tree view. https://git.xfce.org/xfce/thunar/tree/thunar/thunar-shortcuts-model.c#n1121
Created attachment 9491 diff Does this look good? How about inserting the entries below the "File System" one.
Just noticed that I cannot test, because I only have a single partition :F (Saw that my USB devices are as well shown in different order, in bookmark/tree view, though not sure if that belongs here) remark on the patch: This check can be removed: if (item->device != NULL && device != NULL) - The if in 1085 already protects from item->device != NULL - "_thunar_return_if_fail (THUNAR_IS_DEVICE (device));" already protects from "device == NULL" a "git format-patch" would be nice. Besides that, it looks good to me. @Jay: Could you please give it a try ?
@alexxcons: dont know how to build, so unfortunately cant test. i hit you up on irc with my jphilips handle asking how i can setup a build environment.
Seems like my irc bouncer is offline today :F .... could you please send me a mail instead ? ( So you implemented the patches on Bug #16472 without any building/testing? nice ;) )
I've mailed you now. ( Yes those patches are just me, git, and no C++ experience :D )
Tested it and it seems to be working
Created attachment 9497 patch
Note that entries for remote folders still appear at random positions (Bug #10815). The following condition could be used to move those entries up so that they appear below the "Network": /* sort devices by type */ if (thunar_device_get_kind (item->device) < thunar_device_get_kind (device)) continue; https://git.xfce.org/xfce/thunar/tree/thunar/thunar-device.h#n35
Theo Linkspfeifer referenced this bugreport in commit 97420d160ab845cc8852b2e63e1de4b971d3b1d9 Sort device entries in tree view (Bug #16471) https://git.xfce.org/xfce/thunar/commit?id=97420d160ab845cc8852b2e63e1de4b971d3b1d9
Theo Linkspfeifer referenced this bugreport in commit 1d46702563be0418cc3a18e413f958bb86ba30c8 Sort device entries in tree view (Bug #16471) https://git.xfce.org/xfce/thunar/commit?id=1d46702563be0418cc3a18e413f958bb86ba30c8
Pushed to master and 4.14 branch, to be released in thunar 1.8.13 Thank you for your contribution ! (In reply to Theo Linkspfeifer from comment #10) > Note that entries for remote folders still appear at random positions (Bug > #10815). > > > The following condition could be used to move those entries up so that they > appear below the "Network": > /* sort devices by type */ > if (thunar_device_get_kind (item->device) < thunar_device_get_kind (device)) > continue; > > https://git.xfce.org/xfce/thunar/tree/thunar/thunar-device.h#n35 Hmm, that would not help that much imo .. I would prefer the approach proposed in #10815 .. though imo it should be consistent for bookmark view and tree-view.