Special paths like trash:/// and network:/// are easily discoverable in thunar, as they are both found in the side pane and in the Go menu, but the computer:/// isnt and i'd like to recommend that it be added.
Would be ok for me .. though per default I would hide it from the sidepane, since we already have all drives listed there. Patches would be welcome ! P.S: Note that you already can drag%drop "computer:///" to the bookmarks in the sidepane when using the pathbar ... however that is a very hidden option :)
Created attachment 9488 patch for the menu Hidden in the sidepane with easy access to unhide it from the right-click context menu would be great. Not sure if the patch is sufficient to get computer:/// into the Go menu, but here's an attempt. P.S. I tried to drag and drop it but I use toolbar style for the location bar. :D
Created attachment 9489 patch for the menu (amended) Thanks for the patch! Here is an amended version to fix a compiler error and update some comments. The patch does indeed add computer:/// to the Go menu and seems to work fine. To add computer:/// to the side pane, you could start by modifying thunar_shortcuts_model_shortcut_places in thunar-shortcuts-model.c to add computer:/// in the way that home, desktop, and trash are added. There will probably be more to it than that to make it work correctly, but that would be a starting place.
Created attachment 9490 add to side pane Thanks for the adjustments Reuben. Thanks for the pointer for the side pane. I've created a patch, but wouldnt need to add it after the first one to test.
Yousuf Philips referenced this bugreport in commit e0def00a1fbb858e7cc0deef66162d672eb60d0f Add computer:/// to Go menu (Bug #16472) https://git.xfce.org/xfce/thunar/commit?id=e0def00a1fbb858e7cc0deef66162d672eb60d0f
Yousuf Philips referenced this bugreport in commit 789fce6433bc8f8d6e11b506d8a89a853e9b3c3e Add computer:/// to side pane (Bug #16472) https://git.xfce.org/xfce/thunar/commit?id=789fce6433bc8f8d6e11b506d8a89a853e9b3c3e
Both patches look good to me & seem to work fine. I added both to thunar master. Thanks alot for your contribution !
Created attachment 9493 correct symbolic icon in menu patch One more patch needed to correct the symbolic icon used in the menu.
Thinking more about Computer's position in the sidepane and menu and think it likely should be positioned above Home or alternatively i should fix it to be located below Desktop in the sidepane as it is in the menu. https://i.imgur.com/Y5ijF49.png
Created attachment 9494 add to side pane tree view Forgot the side pane's tree view. :D
Yousuf Philips referenced this bugreport in commit 5e55b00ceb76dae15aea7914ec52255826392f9b computer:/// menu item shouldnt use symbolic icon (Bug #16472) https://git.xfce.org/xfce/thunar/commit?id=5e55b00ceb76dae15aea7914ec52255826392f9b
uh, yes, did not notice that only one of them is symbolic .. pushed. (In reply to Jay Philips from comment #9) > Thinking more about Computer's position in the sidepane and menu and think > it likely should be positioned above Home or alternatively i should fix it > to be located below Desktop in the sidepane as it is in the menu. > > https://i.imgur.com/Y5ijF49.png Dont bother for that .. I am anyhow about to re-implement all the menus .. gosh, need to rebase to have all these recent changes. If you want to have a look: https://github.com/alexxcons/thunar/tree/MergeAllContextMenus5 (In reply to Jay Philips from comment #10) > Created attachment 9494 > add to side pane tree view > > Forgot the side pane's tree view. :D Not sure if that would be a good idea, since afaik you cannot hide the item in tree-view. (Would be y nice feature to be able to hide tree-view items, like in the shortcut view)
Created attachment 9505 move computer above home in bookmark view (In reply to alexxcons from comment #12) > Dont bother for that .. I am anyhow about to re-implement all the menus .. > gosh, need to rebase to have all these recent changes. If you want to have a > look: https://github.com/alexxcons/thunar/tree/MergeAllContextMenus5 I'll can leave it to you to fix the position in the menu and think it being above Home is good, but a fix is also needed for the sidepane, as presently its below Home, though it appeared like it was above Home in the screenshot. (patch provided) > Not sure if that would be a good idea, since afaik you cannot hide the item > in tree-view. (Would be y nice feature to be able to hide tree-view items, > like in the shortcut view) Its not intended to be hidden, but is intended to be noticed and easily accessible when necessary, just like 'File System'.
Yousuf Philips referenced this bugreport in commit 1c31f137080fecdecafbf974eba6bdf3b916d858 Move computer:/// above Home in bookmark view (Bug #16472) https://git.xfce.org/xfce/thunar/commit?id=1c31f137080fecdecafbf974eba6bdf3b916d858
(In reply to Jay Philips from comment #13) > I'll can leave it to you to fix the position in the menu and think it being > above Home is good, but a fix is also needed for the sidepane, as presently > its below Home, though it appeared like it was above Home in the screenshot. > (patch provided) True, it should be above home in the sidepane Thanks, pushed to master ! > > Not sure if that would be a good idea, since afaik you cannot hide the item > > in tree-view. (Would be y nice feature to be able to hide tree-view items, > > like in the shortcut view) > > Its not intended to be hidden, but is intended to be noticed and easily > accessible when necessary, just like 'File System'. Ok, I buy it :) ... but please move it as well above $HOME, so that the order is consistant with the shortcut view.
Created attachment 9527 computer:/// in tree view (In reply to alexxcons from comment #12) > uh, yes, did not notice that only one of them is symbolic .. pushed. Home is symbolic in the menu, so it might be good to fix that, though maybe it was meant to be symbolic so it patches the toolbar button, but it being the only symbolic item in the menu seems bad.
Yousuf Philips referenced this bugreport in commit cdb516d09cbc0e7c1995188407a672869cba8c89 Add computer:/// to side pane tree view (Bug #16472) https://git.xfce.org/xfce/thunar/commit?id=cdb516d09cbc0e7c1995188407a672869cba8c89
pushed, thanks ! (In reply to Jay Philips from comment #16) > Home is symbolic in the menu, so it might be good to fix that, though maybe > it was meant to be symbolic so it patches the toolbar button, but it being > the only symbolic item in the menu seems bad. Yes, possibly related to the toolbar-icon .. gues it uses the same GtkAction. Again something that could be fixed after I merged my WIP branch (https://github.com/alexxcons/thunar/tree/MergeAllContextMenus5) .. hope I will find some time to continue working on it soon.
Created attachment 9565 a few fixes Theo noticed these issues in my earlier patches
Created attachment 9566 a few more fixes forgot a few and messed up a few, which are now fixed.
Theo suggested these additional changes https://paste.debian.net/1134384/
Yousuf Philips referenced this bugreport in commit 7acdd87ff7dbf10a3dfd4ea6a263a9aeca7817b8 Computer (Bug #16472) - Change menu tooltip - use the predefined sorting - Fixed comments https://git.xfce.org/xfce/thunar/commit?id=7acdd87ff7dbf10a3dfd4ea6a263a9aeca7817b8
Theo Linkspfeifer referenced this bugreport in commit c9ae13f7b40ef4ce233324b4308171ef325f5c17 Computer: (Bug 16472) - make use of "thunar_g_vfs_is_uri_scheme_supported" to check for computer support - fixed some comments - Use "g_file_new_for_uri" directly https://git.xfce.org/xfce/thunar/commit?id=c9ae13f7b40ef4ce233324b4308171ef325f5c17
Thanks ! Hope we are done this time :)