16254 – Make use of "close multi tab" dialog from libxfce4ui

Make use of "close multi tab" dialog from libxfce4ui

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
enhancement

Product:
Thunar

Component:

General

Comments

Description alexxcons editbugs

2019-12-06 22:28:00 CET

Bug #15873 introduced a general "close multi tab" dialog.
Since libxfce4ui  4.15.0 just got released, we can make use of it in thunar now.

Comment 1 Reuben Green editbugs

2020-02-02 00:33:36 CET

Created attachment 9417 
Replaces custom code with libxfce4ui function

Apologies for the long absence!

So here is a patch to do this. Comments and criticisms welcome as always!

Comment 2 alexxcons editbugs

2020-02-02 21:26:57 CET

Created attachment 9421 
patch

Thanks alot for the patch !

I just fixed some gtk compile warnings and bumped the minimum required xfce4ui version to 4.15.

Ok for you if I push it like that ?

Comment 3 Reuben Green editbugs

2020-02-02 23:35:53 CET

Yep, that patch looks fine to me. Thanks!

Comment 4 Git Bot editbugs

2020-02-03 22:21:18 CET

Reuben Green referenced this bugreport in commit 59244a32f25dae0aae51a595e383ab49fe255887

Use libxfce4ui close-multiple-tab dialog (Bug #16254)

https://git.xfce.org/xfce/thunar/commit?id=59244a32f25dae0aae51a595e383ab49fe255887

Comment 5 alexxcons editbugs

2020-02-03 22:25:52 CET

Pushed it to master.

Thank you for your contribution!   .. was a long way for that dialog :)

A bit sad that Igor seems not to be interest in using it in xfce4-terminal any more (Bug #16255) .. possibly that will change some day :)

Bug #16254

Reported by:
alexxcons

Reported on: 2019-12-06
Last modified on: 2020-02-03

People

Assignee:
alexxcons

CC List:
2 users

Version

Version:
git

Target Milestone:
1.8.10

Attachments

Replaces custom code with libxfce4ui function (3.74 KB, patch) 2020-02-02 00:33 CET , Reuben Green	no flags
patch (4.49 KB, patch) 2020-02-02 21:26 CET , alexxcons	no flags

Additional information