! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Make use of "close multi tab" dialog from libxfce4ui
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Xfce4-terminal
Component:
General

Comments

Description alexxcons editbugs 2019-12-06 22:29:37 CET
Bug #15873 introduced a general "close multi tab" dialog.
Since libxfce4ui  4.15.0 just got released, we can make use of it in thunar now.
Comment 1 Igor editbugs 2019-12-08 19:13:49 CET
I've almost finished implementing the support for the new function when I suddenly realized that the function doesn't entirely fulfill the needs of the terminal: the terminal not only checks the number of open tabs but also verifies whether any of the tabs is running an active process. When there's a process running, a similar dialog but with different text is shown. It wouldn't make sense to have different implementations for two similar dialogs, imho.
Comment 2 alexxcons editbugs 2019-12-08 21:43:21 CET
Meh, that's a pity.

How about some optional parameter "gchar* additional_text" for xfce_dialog_confirm_close_tabs in order to cover that usecase ?

Bug #16255

Reported by:
alexxcons
Reported on: 2019-12-06
Last modified on: 2019-12-08

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information