! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Not possible to grab scrollbar on the very right pixels when Thunar is maximized
Status:
RESOLVED: MOVED

Comments

Description Yury Martynov 2019-10-15 00:36:50 CEST
Created attachment 9120 
screen record

Hi!
I have a problem in the latest 1.8.9 version of the Thunar and I need help

by default, the Thunar always open maximized (Alt+F10/Alt+F11) and I often need to quickly scroll down using mouse cursor. It worked for me in 1.6 when i enabled it by `gtk-primary-button-warps-slider = 1` param in `~/.config/gtk-*/settings.ini` file. But now in 1.8.9 version, it doesn't work as if have an invisible border in the right side and I constantly have to be distracted by this so that the scroll bar appears

Thank you!
Comment 1 Adam Purkrt 2019-10-15 21:40:20 CEST
You mean you can not scroll the maximized window with the mouse pointer on the right edge of the screen? I find that a drawback (too). But perhaps you are writing about something else.
Comment 2 alexxcons editbugs 2019-10-15 22:06:05 CEST
Thanks for reporting !

Interesting .. I use two monitors, where I almost always use thunar on the left one .. so until now I never noticed that the scrollbar has some "dead pixels" on the right :)

I have no idea about "gtk-primary-button-warps-slider" .. though IMO it should not be required at all to run some specific settings, just to be able to use all pixels of the scrollbar on fullscreen.

Though the provided "gtk-primary-button-warps-slider" may help to figure out what is needed to get it to work.

The used theme seems not to matter.
Comment 3 alexxcons editbugs 2019-10-15 22:13:31 CEST
Happens as well for mousepad, though xfce4-terminal seems not to be affected.

Possibly related to that "auto enlarge" feature of the scrollbar, which is not used by xfce4-terminal.

No time to work on this currently, busy with some other bug .. patches would be very welcome !
Comment 4 Theo Linkspfeifer editbugs 2019-10-16 00:22:19 CEST
No patch, but a workaround:

.thunar .standard-view.frame {
  border-right: 0px;
}

This CSS snippet can be added to ~/.config/gtk-3.0/gtk.css .
Comment 5 Yury Martynov 2019-10-16 12:29:13 CEST
>You mean you can not scroll the maximized window with the mouse pointer on the right edge of the screen

yes. Sorry for my English!

>This CSS snippet can be added to...

wow!! Thank you very much!

P.S. It works too for me using this patch

diff -ur a/thunar/thunar-application.c b/thunar/thunar-application.c
--- a/thunar/thunar-application.c	2019-08-11 03:33:53.000000000 +0300
+++ b/thunar/thunar-application.c	2019-10-16 13:17:12.097528291 +0300
@@ -593,7 +593,7 @@
     /* add missing top border to side pane */
     ".shortcuts-pane { border-top-style: solid; }"
     /* make border thicker during DnD */
-    ".standard-view { border-left-width: 0px; }"
+    ".standard-view { border-left-width: 0px; border-right: 0px; }"
     ".standard-view:drop(active) { border-width: 2px; }", -1, NULL);
   screen = gdk_screen_get_default ();
   gtk_style_context_add_provider_for_screen (screen, GTK_STYLE_PROVIDER (css_provider), GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
Comment 6 Yury Martynov 2019-10-16 12:31:06 CEST
Created attachment 9123 
fix_scrollbar_in_standart_view.patch

fix_scrollbar_in_standart_view.patch

Please, review this patch before using
Comment 7 Theo Linkspfeifer editbugs 2019-10-16 12:47:23 CEST
Ideally, you should rename "border-right" to "border-right-width" and use git format-patch to create the patch file.
Comment 8 Yury Martynov 2019-10-16 13:01:41 CEST
Created attachment 9124 
fix_scrollbar_in_standart_view-r1.patch

>rename "border-right" to "border-right-width"

i can create a pull request on the github mirror
Comment 9 Yury Martynov 2019-10-16 13:47:32 CEST
Created attachment 9125 
fix_scrollbar_in_standart_view-r2.patch
Comment 10 Git Bot editbugs 2019-10-16 22:41:16 CEST
Yury Martynov referenced this bugreport in commit b486e473eb947f4ba96e4ac370c8669553ead5a2

Not possible to grab scrollbar on the very right pixels when Thunar is maximized (Bug #16050)

https://git.xfce.org/xfce/thunar/commit?id=b486e473eb947f4ba96e4ac370c8669553ead5a2
Comment 11 Git Bot editbugs 2019-10-16 22:44:44 CEST
Yury Martynov referenced this bugreport in commit a87c890d78d749cc69125bf744913d9ea6576617

Not possible to grab scrollbar on the very right pixels when Thunar is maximized (Bug #16050)

https://git.xfce.org/xfce/thunar/commit?id=a87c890d78d749cc69125bf744913d9ea6576617
Comment 12 alexxcons editbugs 2019-10-16 22:46:32 CEST
Works fine! Patch applied to master and 4.14 branch, to be released in 1.8.10

Thanks alot for your contribution !
Comment 13 alexxcons editbugs 2019-10-17 08:50:35 CEST
I opened Bug #16056 for the same issue with mousepad .... would be great if you could take a look as well.

In addition, there is a overall bug, which possibly can be closed: Bug #15911
Comment 14 alexxcons editbugs 2019-10-22 21:45:09 CEST
> Keep in mind that there will be an additional border when multiple tabs are open (see comment #2).

 Meh, same problem than for mousepad .. fix works for single tab, but not for multitab.
Comment 15 Adam Purkrt 2019-10-24 01:01:48 CEST
As I have written over irc, I do not see any problem with multitab, the patch still works. I can scroll on the right edge with more than one tab in the patched version.
Comment 16 alexxcons editbugs 2019-10-24 09:56:06 CEST
Just took another try. This time I as well checked different themes:
Bug with multitab occurs with greybird / bluebird
Bug does not occur with blackbird, adwaita, adwaita-dark, high-contrast

If its only greybird / bluebird, probably it should be fixed there ... though when more themes are buggy, possibly it is worth fixng it in thunar.

I'll ask someone with better theming knowledge what would be preferred.
Comment 17 Git Bot editbugs 2020-05-26 23:46:11 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/265.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #16050

Reported by:
Yury Martynov
Reported on: 2019-10-15
Last modified on: 2020-05-26

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Attachments

screen record (862.87 KB, video/mp4)
2019-10-15 00:36 CEST , Yury Martynov
no flags
fix_scrollbar_in_standart_view.patch (729 bytes, patch)
2019-10-16 12:31 CEST , Yury Martynov
no flags
fix_scrollbar_in_standart_view-r1.patch (732 bytes, patch)
2019-10-16 13:01 CEST , Yury Martynov
no flags
fix_scrollbar_in_standart_view-r2.patch (1.00 KB, patch)
2019-10-16 13:47 CEST , Yury Martynov
no flags

Additional information