! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Added menu options (items) to create new folder/document.
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-panel
Component:
Directory Menu

Comments

Description cryptogopher 2019-06-24 23:55:50 CEST
Created attachment 8680 
Patch for described changes

To be able to use Directory Menu plugin as a notes app I created additional menu items:
1. to create new folder
2. to create empty file
User is asked for folder/file name and has possibility to open folder/file right after creating in default app.

Both menu items can be disabled in preferences.

The attached patch assumes, that patch in https://bugzilla.xfce.org/show_bug.cgi?id=15630 is applied as well.
Comment 1 cryptogopher 2019-12-07 22:37:37 CET
Created attachment 9298 
Patch updated with separator hiding

Similarly to patch in https://bugzilla.xfce.org/show_bug.cgi?id=15630
Comment 2 Simon Steinbeiss editbugs 2019-12-10 16:26:36 CET
I modified the dialog a bit to look more like Thunar's.

I'm also wondering whether to look into enabling the creation of other document types, similar to Thunar's context menu.

https://git.xfce.org/users/ochosi/xfce4-panel/log/?h=bug15639
Comment 3 Simon Steinbeiss editbugs 2019-12-10 16:27:14 CET
(Note that the separator hiding is not yet merged into this branch. Also, please mark patches as obsolete when you upload new versions)
Comment 4 cryptogopher 2019-12-10 18:53:40 CET
(In reply to Simon Steinbeiss from comment #2)

Thank you for merging!

> I'm also wondering whether to look into enabling the creation of other
> document types, similar to Thunar's context menu.

That sounds interesting. The problem I see here is that eventually 'action menu' of the plugin would take quite a bit of space. What I was thinking about is whether the 'action menu' could be displayed as a context menu on a right-click of file item (kind of context menu inception here :). That would give best UX compatibility with Thunar in my opinion. Unfortunately I recall reading somewhere that it is technically hard/impossible to do something like that in GTK. I can't remember source, but I may take a look at such possibility if you think it's a good idea.

> (Note that the separator hiding is not yet merged into this branch. Also, please mark patches as obsolete
> when you upload new versions)

I'm not sure how to mark patch as obsolete. Is it by setting 'review' flag to '-' on that file?
Comment 5 Simon Steinbeiss editbugs 2019-12-12 15:02:06 CET
In this case it would become a sub-menu. Otherwise I would try to make it clear that it's a *text*file.


Regarding marking a patch as obsolete - you can only do that when uploading a new patch.
Comment 6 cryptogopher 2019-12-13 22:09:13 CET
(In reply to Simon Steinbeiss from comment #5)
> In this case it would become a sub-menu. Otherwise I would try to make it
> clear that it's a *text*file.

Somehow while replying in https://bugzilla.xfce.org/show_bug.cgi?id=15639#c4 I had some different menu on my mind, not Thunar's. I rechecked and actually Thunar uses submenu as you described. Sorry for the confusion caused.

I'm not sure if it's worth creating submenu:
* on the one hand submenu allows creation of different file types (though I don't have any templates on my system and I don't know if they are really that popular/used),
* on the other submenu will introduce one additional click for creation of simple file and less efficient UX.

What about leaving menu as it is now (only changing item name to "New text file" as you suggested) and see whether there will be any feature request for extended menu like in Thunar?


Thanks for remark reg. patches.
Comment 7 Git Bot editbugs 2020-01-05 00:09:46 CET
cryptogopher referenced this bugreport in commit ab86c3c8a1c075b2a5ca4c70b7272ea36b301faf

directorymenu: Add create folder/document menuitems (Bug #15639)

https://git.xfce.org/xfce/xfce4-panel/commit?id=ab86c3c8a1c075b2a5ca4c70b7272ea36b301faf

Bug #15639

Reported by:
cryptogopher
Reported on: 2019-06-24
Last modified on: 2020-01-05

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Version:
4.13.5

Attachments

Patch for described changes (15.12 KB, patch)
2019-06-24 23:55 CEST , cryptogopher
no flags
Patch updated with separator hiding (13.72 KB, patch)
2019-12-07 22:37 CET , cryptogopher
no flags

Additional information