! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add ability to hide Open Folder/Open in Terminal menu items
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-panel
Component:
Directory Menu

Comments

Description cryptogopher 2019-06-23 00:42:00 CEST
Created attachment 8668 
Patch for described changes

Some use cases of Directory Menu may not require Open Folder/Open in Terminal commands. For example I use Directory Menu as a way to list txt files with notes. In such case removal of menu items makes for better experience.

I prepared patch, which enables user to switch off displaying those menu items through plugin properties.
Comment 1 Simon Steinbeiss editbugs 2019-10-03 01:36:06 CEST
Thanks for the patch!
While it mostly works as expected, the separator that is above the "Open Folder" / "Open in Terminal" menuitems always remains visible, which looks strange.

Would you mind updating your patch to take this into account?
Comment 2 cryptogopher 2019-10-08 18:02:50 CEST
> Would you mind updating your patch to take this into account?

Thank you for taking care :) Actually I thought that leaving separator allows users to better recognize that the menu is absent and the 1st item is file/directory item and not menu item.

But no problem, I will add code to hide it as you suggest.
Comment 3 Simon Steinbeiss editbugs 2019-12-04 23:59:38 CET
Just a reminder to amend your patch so it can get merged.
Comment 4 cryptogopher 2019-12-07 22:36:13 CET
Created attachment 9297 
Patch updated with separator hiding
Comment 5 Git Bot editbugs 2019-12-08 21:59:57 CET
Simon Steinbeiss referenced this bugreport in commit a13494d184b8888f16d080dbd03ab79fb33a0f46

directorymenu: Add option to hide folder/terminal menuitems (Bug #15630)

https://git.xfce.org/xfce/xfce4-panel/commit?id=a13494d184b8888f16d080dbd03ab79fb33a0f46
Comment 6 Simon Steinbeiss editbugs 2019-12-08 23:48:41 CET
I apologize for the slightly hasty push - I forgot to change the patch author to your name :/
(I had to fix the wording of the menuitems because you spelled "Folder" vs "folder" inconsistently in your patch.)

I hope you still appreciate the merging of your patch!
I'm on to review your second patch now...
Comment 7 cryptogopher 2019-12-08 23:50:54 CET
(In reply to Simon Steinbeiss from comment #6)
> I apologize for the slightly hasty push - I forgot to change the patch
> author to your name :/

Not a problem, really. Don't waste your time changing it.

> I hope you still appreciate the merging of your patch!
> I'm on to review your second patch now...

Yes, that's perfect! Thank you!

Bug #15630

Reported by:
cryptogopher
Reported on: 2019-06-23
Last modified on: 2019-12-08

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.13.5

Attachments

Patch for described changes (9.97 KB, patch)
2019-06-23 00:42 CEST , cryptogopher
no flags
Patch updated with separator hiding (10.28 KB, patch)
2019-12-07 22:36 CET , cryptogopher
no flags

Additional information