! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Improve layout in permissions tab
Status:
RESOLVED: FIXED

Comments

Description scootergrisen 2019-06-06 03:21:53 CEST
Created attachment 8619 
Idea for permissions layout

In file properties permissions tabs i think the elements are to close together.
It dont look so much as 3 sections (owner, group, others) like it could.
So its not clear that the access dropdown lists is connected to the element above it.

I would like if owner, group, and others section was more clearly separated.
Maybe move the permissions dropdowns to the right and remove "access:" text for a more cleaner layout. See attached image.
I dont know if this can give problems with long owner/group names.

Else maybe just add more space between the 3 sections so its more clear what belongs to what.
Comment 1 alexxcons editbugs 2019-06-06 11:53:04 CEST
I agree on your considerations.

Though I would not put 3 elements in one line, since it will for sure expand the complete settings GUI for long user names / for some languages.

I would suggest to put the label "user" / "group" / "other" in a separate line before, and possibly add separators between the sections.

I dont have time to work on this currently. Though I can review/apply patches. So please take a try for yourself, if you can !

The file of interest is thunar-permissions-chooser.cpp, the method "thunar_permissions_chooser_init".
Comment 2 alexxcons editbugs 2019-06-06 11:54:07 CEST
*** Bug 15556 has been marked as a duplicate of this bug. ***
Comment 3 Git Bot editbugs 2019-06-13 00:18:08 CEST
Theo Linkspfeifer referenced this bugreport in commit 209a3fc232ca148db8a43f7c4693e022a2b2d3f9

Improve layout of Permissions tab (Bug #15557)

https://git.xfce.org/xfce/thunar/commit?id=209a3fc232ca148db8a43f7c4693e022a2b2d3f9
Comment 4 alexxcons editbugs 2019-06-13 00:21:48 CEST
Thanks for the patch ! Applied it to master

The patch does not restructure the whole GUI, instead it just adds another "Access" label and some space between the sections.

Bug #15557

Reported by:
scootergrisen
Reported on: 2019-06-06
Last modified on: 2019-06-13
Duplicates (1):
  • 15556 Add "access:" to permissions tab

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

Idea for permissions layout (14.37 KB, image/jpeg)
2019-06-06 03:21 CEST , scootergrisen
no flags

Additional information