! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
creating an smb share saves a wrong port
Status:
RESOLVED: FIXED

Comments

Description Landry Breuil editbugs 2019-05-24 08:53:57 CEST
with 0.4.91, if i create a new bookmark it defaults to FTP/port 21. if i switch to SMB type, the port field is hidden, but the value is retained, and saved in the config. Trying to connect to the share will fail with connection refused, as it tries on port 21.

to make the smb share work, i need to edit .config/gigolo/bookmark and remove the port line for the given bookmark.

a bit similar to bug #14928 ? probably easy to fix, just filing it so its tracked..
Comment 1 Theo Linkspfeifer editbugs 2020-02-28 12:34:48 CET
*** Bug 16275 has been marked as a duplicate of this bug. ***
Comment 2 Landry Breuil editbugs 2020-02-28 19:04:03 CET
Created attachment 9499 
always set port when changing method

sean, does this make sense to you as a potential fix ?
Comment 3 Landry Breuil editbugs 2020-02-29 18:27:08 CET
with the patch, if i create an smb share, no port is saved in the bookmark (which i think is the expected behaviour):

[test]
host=test
folder=
user=
scheme=smb
share=test
domain=
path=

changing share type updates the port field with the default value for the method.
Comment 4 Git Bot editbugs 2020-03-14 09:23:56 CET
Landry Breuil referenced this bugreport in commit f951a478c99784d12e1d22c5809b87989bebde10

ensure port is always reset to the method port (bug #15455)

https://git.xfce.org/apps/gigolo/commit?id=f951a478c99784d12e1d22c5809b87989bebde10
Comment 5 Landry Breuil editbugs 2020-03-14 09:25:19 CET
fixed in the just released 0.5.1.

Bug #15455

Reported by:
Landry Breuil
Reported on: 2019-05-24
Last modified on: 2020-03-14
Duplicates (1):
  • 16275 Gigolo SMB share adds port 21 to config file

People

Assignee:
Landry Breuil
CC List:
2 users

Version

Version:
unspecified

Attachments

always set port when changing method (837 bytes, patch)
2020-02-28 19:04 CET , Landry Breuil
landry : review? ( bluesabre )

Additional information