Created attachment 8142 error dialog screenshot Steps to reproduce: 1. Launch Gigolo 2. Action > Connect 3. Select FTP or WebDav 4. Enter server address in "Server" 5. Enter username 6. Click "Connect" Behavior: Error Dialog prompts with message: "You must enter a share name". For WebDav or FTP it should not ask for share name and also there is no place to enter it. Expected behavior: After connect it should prompt dialog for username and password and connect to the WebDav or FTP server. Gigolo 0.4.90 (GTK+ 3.24.1, GLib 2.58.1) openSUSE Tumbleweed
*** Bug 14974 has been marked as a duplicate of this bug. ***
I've seen the same bug for smb shares, it wasnt possible to create new shares/bookmarks - sean, since you finished the porting to gtk3, any idea ? The https://git.xfce.org/apps/gigolo/tree/src/bookmarkeditdialog.c logic where the error comes from hasnt really been modified since a while.. will eventually look at the code this weekend..
did some git bisect, and it points at https://git.xfce.org/apps/gigolo/commit/?id=862e5aac606acdaa787112fd01358f4c4964e15b as the one causing the bug. Will dig deeper :)
Looking at the code, my understanding is that before this commit, the 'unneeded' widgets were removed from the container in setup_for_type(), while they're just hidden after the commit - so that might explain why the validity controls triggers on share, which is only used for smb method.
Thanks a lot for looking into this :-)
Created attachment 8315 potential fix v1 Here's a potential fix on top of master, which this i'm able to create ssh & ftp mounts - havent tested smb yet. I'm not 100% happy with it, since the logic changed in the commit might have to be improved instead of adding kludges like this. The 'port' value from the method isnt used either, the port field always default to 0 while to my understanding it should change when switching methods.
Created attachment 8316 Set port on connection type change I think the proposed patch is sufficient and correctly handles the validation. The attached patch resolves the port number not changing when the connection type is changed.
Sean Davis referenced this bugreport in commit eeb13ae0a74ab49643298fcb12f38e5d6f473acc Set port number when connection type changes (Bug #14928) https://git.xfce.org/apps/gigolo/commit?id=eeb13ae0a74ab49643298fcb12f38e5d6f473acc
Landry Breuil referenced this bugreport in commit 077282fa40daeaae623a0f5fa239ff8aab370b61 Only show an error dialog if the share name/uri field is visible/required (bug #14928) https://git.xfce.org/apps/gigolo/commit?id=077282fa40daeaae623a0f5fa239ff8aab370b61
0.4.91 just shipped with the fix.
Thank you I confirm the issue is resolved.