! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Remove superfluous shell script "ThunarBulkRename"
Status:
RESOLVED: FIXED
Priority:
Very Low
Severity:
enhancement

Comments

Description ctac 2019-05-09 19:45:39 CEST
The desktop file for Bulk Rename use a shell script :
Exec=/usr/lib/x86_64-linux-gnu/Thunar/ThunarBulkRename %F on debian
Exec=/usr/local/lib/Thunar/ThunarBulkRename %F on OpenBSD
This shell script say :
# This is an ugly hack, required because xfdesktop simply
# strips off all parameters from the Exec field, and so
# we cannot just invoke Thunar --bulk-rename %F there
exec /usr/bin/Thunar --bulk-rename "$@"

If this  line in the desktop file is replace by :
Exec=thunar '-B' %F
No need of additional shell script !
Comment 1 ctac 2019-05-09 20:14:37 CEST
The desktop file for Bulk Rename use a shell script :
Exec=/usr/lib/x86_64-linux-gnu/Thunar/ThunarBulkRename %F on debian
Exec=/usr/local/lib/Thunar/ThunarBulkRename %F on OpenBSD
This shell script say :
# This is an ugly hack, required because xfdesktop simply
# strips off all parameters from the Exec field, and so
# we cannot just invoke Thunar --bulk-rename %F there
exec /usr/bin/Thunar --bulk-rename "$@"

If this  line in the desktop file is replace by :
Exec=thunar -B %F
or
Exec=thunar --bulk-rename %F
No need of additional shell script !
xfdesktop no more strips off all parameters from the Exec field.
Comment 2 alexxcons editbugs 2019-05-09 23:40:47 CEST
Thanks for reporting !

I can reproduce that "Exec=thunar -B %F" and "Exec=thunar --bulk-rename %F" both work fine with xfdesktop 4.13.

( Dropped some selected files on bulkRenamer.desktop .... is there a better way to test ? )

Possibly you already have a patch in work to fix the generated .desktop file and dump the script and it's installation ?
Comment 3 alexxcons editbugs 2019-06-03 23:57:39 CEST
Created attachment 8609 
patch

ok, here a patch to remove the script. WOrks fine for me .. could you please give it a try as well ?

Since it is no bugfix, I would apply the patch to master only.
Comment 4 alexxcons editbugs 2019-06-04 00:03:28 CEST
Created attachment 8610 
patch

ops, wrong patch :X  .... this time
Comment 5 Maurizio Galli 2019-06-04 15:11:05 CEST
Many of the file names installed are still uppercase, is it intentional?

[   83s]     Installed (but unpackaged) file(s) found:
[   83s]    /etc/xdg/Thunar/uca.xml
[   83s]    /usr/bin/Thunar
[   83s]    /usr/bin/thunar

[   83s]    /usr/lib/Thunar/thunar-sendto-email

[   83s]    /usr/lib64/girepository-1.0/Thunarx-3.0.typelib

[   83s]    /usr/share/Thunar/sendto/thunar-sendto-email.desktop

[   83s]    /usr/share/dbus-1/services/org.xfce.FileManager.service
[   83s]    /usr/share/dbus-1/services/org.xfce.Thunar.FileManager1.service
[   83s]    /usr/share/dbus-1/services/org.xfce.Thunar.service
[   83s]    /usr/share/gir-1.0/Thunarx-3.0.gir
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxFileInfo.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxMenu.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxMenuItem.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxMenuProvider.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxPreferencesProvider.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxPropertyPage.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxPropertyPageProvider.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxProviderFactory.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxProviderPlugin.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxRenamer.html
[   83s]    /usr/share/gtk-doc/html/thunarx/ThunarxRenamerProvider.html

[   83s]    /usr/share/icons/hicolor/128x128/apps/Thunar.png
[   83s]    /usr/share/icons/hicolor/16x16/apps/Thunar.png

[   83s]    /usr/share/icons/hicolor/24x24/apps/Thunar.png

[   83s]    /usr/share/icons/hicolor/48x48/apps/Thunar.png
[   83s]    /usr/share/icons/hicolor/64x64/apps/Thunar.png
[   83s]    /usr/share/icons/hicolor/scalable/apps/Thunar.svg
[   83s]    /usr/share/locale/am/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ar/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ast/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/be/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/bg/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/bn/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ca/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/cs/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/da/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/de/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/el/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/en_AU/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/en_GB/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/eo/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/es/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/et/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/eu/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/fa_IR/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/fi/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/fr/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/gl/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/he/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/hr/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/hu/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/id/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ie/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/is/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/it/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ja/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/kk/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ko/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/lt/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/lv/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ms/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/nb/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/nl/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/nn/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/oc/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/pa/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/pl/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/pt/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/pt_BR/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ro/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ru/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/si/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/sk/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/sl/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/sq/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/sr/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/sv/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/te/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/th/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/tr/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ug/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/uk/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ur/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/ur_PK/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/vi/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/zh_CN/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/zh_HK/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/locale/zh_TW/LC_MESSAGES/Thunar.mo
[   83s]    /usr/share/man/man1/Thunar.1.gz
[   83s]    /usr/share/pixmaps/Thunar/Thunar-about-logo.png

]
Comment 6 Andre Miranda editbugs 2019-06-04 15:17:00 CEST
(In reply to Maurizio Galli from comment #5)
> Many of the file names installed are still uppercase, is it intentional?
No, see Bug 15394.
Comment 7 Git Bot editbugs 2019-06-04 21:58:19 CEST
Alexander Schwinn referenced this bugreport in commit 7bb356d918eb4a8b2aa26ab600738edb7cb48eec

Remove superfluous shell script "ThunarBulkRename" (Bug #15373)

https://git.xfce.org/xfce/thunar/commit?id=7bb356d918eb4a8b2aa26ab600738edb7cb48eec
Comment 8 alexxcons editbugs 2019-06-04 21:59:27 CEST
fixed for master

Bug #15373

Reported by:
ctac
Reported on: 2019-05-09
Last modified on: 2019-06-04

People

Assignee:
alexxcons
CC List:
3 users

Version

Attachments

patch (1.91 KB, patch)
2019-06-03 23:57 CEST , alexxcons
no flags
patch (3.44 KB, patch)
2019-06-04 00:03 CEST , alexxcons
no flags

Additional information