! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Change Thunar.mo to thunar.mo
Status:
RESOLVED: FIXED

Comments

Description scootergrisen 2019-05-13 20:14:22 CEST
Seems like Thunar.mo in /usr/share/locale/ is the only Xfce translation file that uses big character.

So maybe change Thunar.mo to thunar.mo (small t) so the filenames are consistent (all small).

I tried renaming Thunar.mo to thunar.mo and logging out and in and starting Thunar but then the translation was not used in Thunar it showed the english strings.



Bonus info:

I can run both these commands:
Thunar
thunar

Thunar seems to be pointing to thunar:
ls -l /usr/bin/Thunar
lrwxrwxrwx 1 root root 6 apr 19 20:48 /usr/bin/Thunar -> thunar
Comment 1 Andre Miranda editbugs 2019-05-14 06:37:30 CEST
It's necessary to update the translation domain, for this you need to change the package name set in AC_INIT at configure.ac.in.

I have no idea why the original devs decided to use "Thunar", investigating a bit I found the following commits:
https://git.xfce.org/xfce/thunar/commit/?id=1212ec4
https://git.xfce.org/xfce/thunar/commit/?id=bb18fa8

The first one is the most important, besides learning that Thunar was initially written in Python, one can notice that back then uppercased binaries were already created (see Makefiles). Then in 2011 Nick decided to rename the binary to "thunar" and rename symlink to "Thunar" to keep compatibility.

I think it's safe to change the translation domain and rename the .mo file, just not completely sure.

If we decide to go forward with this, we will also need to update "translation" org.xfce.thunar.appdata.xml.in.
Comment 2 Andre Miranda editbugs 2019-05-18 22:49:00 CEST
Note to myself: the tarball is also "Thunar"
Comment 3 Andre Miranda editbugs 2019-05-21 02:13:22 CEST
Created attachment 8556 
fix.diff

Changing the AC_INIT parameters yielded the following results:
- thunar-prefix/share/locale/*/LC_MESSAGES/Thunar.mo -> thunar-prefix/share/locale/*/LC_MESSAGES/thunar.mo
- thunar-prefix/share/doc/Thunar -> thunar-prefix/share/doc/thunar
- Tarballs are completely lowercase

I'm just reluctant to push this change now that are so close to Xfce 4.14.
Comment 4 scootergrisen 2019-05-21 03:43:24 CEST
Are you afraid something will go wrong and not work?
For other software that have releases often it might not matter if it happens in the next release of the release after but if it takes another 4-5 years for the next release its not so much fun to wait so long to see things changed.
Comment 5 Andre Miranda editbugs 2019-05-21 18:36:16 CEST
(In reply to scootergrisen from comment #4)
> Are you afraid something will go wrong and not work?
Yes, we are in the stabilization phase for 4.14, so better safe than sorry.

> For other software that have releases often it might not matter if it
> happens in the next release of the release after but if it takes another 4-5
> years for the next release its not so much fun to wait so long to see things
> changed.
Thunar has received updates more frequently, in part for not following the 4.x versioning scheme.
My idea is to not release unless necessary until 4.14-final, after this we can issue another release, i.e. 1.8.7.
Comment 6 scootergrisen 2019-05-21 19:49:22 CEST
Ok you know best.
Comment 7 scootergrisen 2019-05-22 21:17:58 CEST
Also fix .desktop files:
https://bugzilla.xfce.org/show_bug.cgi?id=13398
Comment 8 scootergrisen 2019-05-22 21:24:16 CEST
These are the files i see containing big charachters to compare with:
Thunar-bulk-rename.desktop
Thunar-folder-handler.desktop
Thunar.desktop
io.github.Hexchat.desktop
org.gnome.Mines.desktop
org.gnome.Software.Editor.desktop
org.gnome.Software.desktop
org.gnome.Sudoku.desktop
org.gnome.Terminal.desktop
org.gnome.seahorse.Application.desktop
org.xfce.Catfish.desktop
org.xfce.Parole.desktop

There with small:
thunar-settings.desktop
thunar-volman-settings.desktop

Seems some application use org.xfce.Big.
I dont know if all Xfce applications are suppose to be named like that.
But at least alle the files starting with thunar/Thunar will be consistent if they are changed to small.
Comment 9 Git Bot editbugs 2019-08-30 03:41:45 CEST
Andre Miranda referenced this bugreport in commit 358879e93f3e9f5f2c85ba81d27d92e2af86af68

All glory to lowercase (Bug #15394)

https://git.xfce.org/xfce/thunar/commit?id=358879e93f3e9f5f2c85ba81d27d92e2af86af68
Comment 10 Git Bot editbugs 2019-08-30 03:42:15 CEST
Andre Miranda referenced this bugreport in commit d67c06aaddc98cd48aa81fc9029fa682f187ca12

All glory to lowercase (Bug #15394)

https://git.xfce.org/xfce/thunar/commit?id=d67c06aaddc98cd48aa81fc9029fa682f187ca12

Bug #15394

Reported by:
scootergrisen
Reported on: 2019-05-13
Last modified on: 2019-08-30

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Attachments

fix.diff (551 bytes, patch)
2019-05-21 02:13 CEST , Andre Miranda
no flags

Additional information