! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Text in help-window garbled
Status:
RESOLVED: MOVED
Product:
Libxfce4ui
Component:
General

Comments

Description Mikhail T. 2019-05-01 17:17:53 CEST
Created attachment 8469 
Window-shot illustrating the problem

I set the LANG environment variable is set to uk_UA.KOI8-U. The help is trying to show me the Ukrainian version, but messes things up -- most likely, because no one has ever tested it in any encoding other than UTF-8.
Comment 1 Andre Miranda editbugs 2019-05-02 21:02:06 CEST
That help dialog is from libxfce4ui, but before moving to that component, the text is also garbled for screenshooter's dialogs?
Out of curiosity, why use an encoding other than UTF-8?
Comment 2 Andre Miranda editbugs 2019-05-02 21:03:02 CEST
Using the solution from Bug #15350 makes any difference?
Comment 3 Mikhail T. 2019-05-03 17:43:55 CEST
> the text is also garbled for screenshooter's dialogs?

No, the buttons and other GUI-elements are all fine...

> Out of curiosity, why use an encoding other than UTF-8?

I, and all of my local users, only know three languages -- Ukrainian, Russian, and English. Character-sets of all three can be expressed in KOI8-U -- a single-byte encoding. Why do we need to use a multi-byte encoding?

> Using the solution from Bug #15350 makes any difference?

Of course, not -- that's only applicable to names of the files on the filesystem...

This might be the same problem as in Bug #11317, however -- where the already-UTF8 text was, erroneously, passed through "g_locale_to_utf8" again. That was fixed in:

https://git.xfce.org/xfce/xfce4-settings/commit/?id=0cd22546f9d64cbb47697f23d62ed099378617e1

(P.S. I can not change the status from "NEEDINFO" to anything other than a "RESOLVED something". This is, probably, a bug in your Bugzilla workflow.)
Comment 4 Andre Miranda editbugs 2019-05-14 04:33:48 CEST
I'm running "LANG=uk_UA.koi8u xfce4-screenshooter" and that dialog looks just right.
What libxfce4ui version do you have installed?
Try to call this help dialog from other apps, such as Thunar, panel or xfdesktop (settings), what happens?

> Why do we need to use a multi-byte encoding?
Because except for very specific use cases, saving some megabytes on a desktop might not be worth the trouble of breaking some apps. I know they are supposed to work with whatever encoding is out there, but UTF-8 is so much more easy for devs... 

> This might be the same problem as in Bug #11317, however -- where the
> already-UTF8 text was, erroneously, passed through "g_locale_to_utf8" again.
> That was fixed in:
> 
> https://git.xfce.org/xfce/xfce4-settings/commit/
> ?id=0cd22546f9d64cbb47697f23d62ed099378617e1
I can't find any occurrence of that function in xfce4-screenshooter nor libxfce4ui.

> (P.S. I can not change the status from "NEEDINFO" to anything other than a
> "RESOLVED something". This is, probably, a bug in your Bugzilla workflow.)
Hopefully we will move to gitlab after 4.14, so this will not be a problem anymore.

Note to myself: Need to remove "auto-online" from ~/.config/xfce4/help.rc to get this dialog again.
Comment 5 Andre Miranda editbugs 2019-05-14 04:34:37 CEST
Created attachment 8519 
Screenshooter in Ukranian(KOI)
Comment 6 Mikhail T. 2019-05-17 22:19:55 CEST
> What libxfce4ui version do you have installed?

I have the following libxfce* packages installed:

libxfce4gui-4.10.0_6
libxfce4menu-4.12.1_2
libxfce4util-4.12.1

> saving some megabytes on a desktop

I started using computers, when 64Kb of RAM was A LOT -- for a mainframe... Besides, it could be a lot more -- any text using Cyrillics _doubles_ in size, when converted to UTF8.

> might not be worth the trouble of breaking some apps

Such apps are already broken 8)
Comment 7 Andre Miranda editbugs 2019-05-19 18:03:03 CEST
> Try to call this help dialog from other apps, such as Thunar, panel or
> xfdesktop (settings), what happens?
This is the part I'm most interested, did you try?
Comment 8 Mikhail T. 2019-05-19 19:35:16 CEST
> Try to call this help dialog from other apps, such as Thunar

Yes, you're right. Thunar's Help is messed up too -- in both Title and inner text. Only the "Cancel" button is properly rendered...
Comment 9 Andre Miranda editbugs 2019-05-19 19:38:29 CEST
(In reply to Mikhail T. from comment #6)
> > What libxfce4ui version do you have installed?
> 
> I have the following libxfce* packages installed:
> 
> libxfce4gui-4.10.0_6
> libxfce4menu-4.12.1_2
> libxfce4util-4.12.1

Are you sure libxfce4ui is properly installed?
libxfce4menu and libxfce4gui were deprecated and archived long ago.
Comment 10 Mikhail T. 2019-05-19 20:20:19 CEST
> Are you sure libxfce4ui is properly installed?

I'm installing through FreeBSD ports... 🤷
Comment 11 Git Bot editbugs 2020-05-25 23:02:15 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/libxfce4ui/-/issues/10.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #15349

Reported by:
Mikhail T.
Reported on: 2019-05-01
Last modified on: 2020-05-25

People

Assignee:
Xfce Bug Triage
CC List:
1 user

Version

Version:
4.12.1

Attachments

Window-shot illustrating the problem (14.84 KB, image/png)
2019-05-01 17:17 CEST , Mikhail T.
no flags
Screenshooter in Ukranian(KOI) (35.47 KB, image/png)
2019-05-14 04:34 CEST , Andre Miranda
no flags

Additional information