The list of possible keyboards and layouts is internationalized, which is nice. However, when the LANG is set to a non-UTF locale (such as my uk_UA.KOI8-U), the list appears garbled. Again, the problem affects both -- list of keyboard models and list of available keyboard layouts. To actual add new layouts I had to unset the LANG environment variable in one xterm, start xfce4-keyboard-settings command-line and do the needful in English.
Fixed in master.
Created attachment 8470 Reduce string copy/freeing... With the strings being used verbatim now, do we even need to dup/free destroy them? How about this patch?..