! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop crashing after some time, any further xfdesktop commands give error...
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description sonicx00222 2019-01-19 17:21:15 CET
As described in this StackOverflow question (https://stackoverflow.com/questions/54225932/xfdesktop-commands-returning-error-in-terminal), after the desktop has been open for some time (say, 30 minutes or so) xfdesktop seems to crash.

After xfdesktop has crashed, any icons on the desktop are unresponsive (or disappear entirely) and any xfdesktop commands (xfdesktop -R, etc., except for xfdesktop -V) return the following error:

> ** (xfdesktop:13267): CRITICAL **: 16:18:15.893: xfdesktop: already running, quitting.
Behavior persists until the offending xfdesktop instance is manually killed and allowed to restart automatically, in which case the desktop works fine for some more time before repeating the behavior. Bug is apparently reproducible on other computers using 4.13.2, but not with 4.12.4.
Comment 1 Andre Miranda editbugs 2019-02-06 03:03:56 CET
Running watch -n 1 xfdesktop --reload for about 10 seconds is enough to get this bug.
Then xfdesktop does not respond to any interaction, pkill xfdesktop, xfdesktop --quit or --reload won't work. Only pkill -9 xfdesktop is able to destroy the faulty instance.
Comment 2 Julien [nodiscc] editbugs 2019-02-28 15:51:18 CET
Cannot reproduce this bug with 4.12.3-3 on Debian
Comment 3 sonicx00222 2019-02-28 19:34:09 CET
(In reply to Julien [nodiscc] from comment #2)
> Cannot reproduce this bug with 4.12.3-3 on Debian

It seems to be a new bug for 4.13.2, StackExchange users couldn't reproduce it on earlier versions either
Comment 4 Andre Miranda editbugs 2019-03-03 17:26:19 CET
Still reproducible with xfdesktop from git.
Comment 5 Skunnyk editbugs 2019-03-23 16:12:27 CET
Created attachment 8356 
xfdesktop git master debug enabled

I can reproduce the git master. I'm attaching the debug. Seems to be related to a gbus thing.
Comment 6 Skunnyk editbugs 2019-03-23 16:23:02 CET
The problem only occurs when desktop Icons are displayed. 
If "Icons" Appareance is set to "None" in xfdesktop-settings, I can xfdesktop --reload dozens of time without triggering the bug.
Comment 7 Skunnyk editbugs 2019-03-23 18:22:40 CET
For whatever reason, it fails on reload (after 8 reloads every time!) on xfdesktop_file_icon_manager_new, when it tries to run the xfconf_g_property_bind functions ((xfdesktop:2189): GLib-GIO-CRITICAL **: 18:21:22.155: g_dbus_connection_call_sync_internal: assertion 'G_IS_DBUS_CONNECTION (connection)' failed)

I don't understand why.
Comment 8 Skunnyk editbugs 2019-03-23 19:48:42 CET
Created attachment 8359 
Fix xfdesktop crashes after multiples --reload

More a workaround than a real fix (why it crashes after *8* reload ?), the removal of icon view reload on --reload fix the problem and seems to not introduce any regressions.
See patch description for more informations.

Please test on top of 4.13.x release or git master !
Comment 9 Skunnyk editbugs 2019-03-23 20:03:14 CET
But maybe a better alternative is to remove the "reload" functionnality of xfdesktop. I don't see what is it purpose since 4.10.
Changing the background automatically can be done dynamically in settings or with xfconf-query
Comment 10 Git Bot editbugs 2019-04-07 16:18:43 CEST
Romain B referenced this bugreport in commit 1455a1780a89ca2253c2deb457e49b78df0555d8

Bug #15060: Fix xfdesktop crashes after multiples --reload

https://git.xfce.org/xfce/xfdesktop/commit?id=1455a1780a89ca2253c2deb457e49b78df0555d8

Bug #15060

Reported by:
sonicx00222
Reported on: 2019-01-19
Last modified on: 2019-04-07

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Version:
4.13.2

Attachments

Additional information