From 9856d7217da9f028ede71e8f08659f7f2afec4d6 Mon Sep 17 00:00:00 2001 From: Romain B Date: Sat, 23 Mar 2019 19:42:20 +0100 Subject: [PATCH] Bug #15060: Fix xfdesktop crashes after multiples --reload - Since the gtk3/gdbus port, xfdesktop crashes when trying to contact xfconfd after around 8 "--reload" commands - The crash only appears if Desktop Icons are enabled in settings - This patch workaround the situation by disabling the icon view reload on "--reload". - This does not seems to introduce any regressions. --- src/xfce-desktop.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/xfce-desktop.c b/src/xfce-desktop.c index 65306100..069416e3 100644 --- a/src/xfce-desktop.c +++ b/src/xfce-desktop.c @@ -1934,16 +1934,6 @@ xfce_desktop_refresh(XfceDesktop *desktop, gboolean advance_wallpaper) /* If we're only advancing the wallpaper we can exit here */ if(advance_wallpaper) return; - -#ifdef ENABLE_DESKTOP_ICONS - /* reload icon view */ - if(desktop->priv->icon_view) { - gtk_widget_destroy(desktop->priv->icon_view); - desktop->priv->icon_view = NULL; - } - xfce_desktop_setup_icon_view(desktop); -#endif - } void xfce_desktop_arrange_icons(XfceDesktop *desktop) -- 2.21.0